local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 51 Pull requests 14 Projects 1 Releases Packages 1 Activity Actions

refactor: rename custom_fields/member_fields to extract_*_field_keys for clarity

Browse source
This commit is contained in:
Moritz 2025-12-03 18:44:17 +01:00
parent 6029920c3f
commit fabfe64468
1 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
lib/mv_web/live/components/field_visibility_dropdown_component.ex
View file

@ -45,13 +45,13 @@ defmodule MvWeb.Components.FieldVisibilityDropdownComponent do
custom_fields = assigns.custom_fields || [] custom_fields = assigns.custom_fields || []
all_items = all_items =
Enum.map(member_fields(all_fields), fn field -> Enum.map(extract_member_field_keys(all_fields), fn field ->
%{ %{
value: field_to_string(field), value: field_to_string(field),
label: format_field_label(field) label: format_field_label(field)
} }
end) ++ end) ++
Enum.map(custom_fields(all_fields), fn field -> Enum.map(extract_custom_field_keys(all_fields), fn field ->
%{ %{
value: field, value: field,
label: format_custom_field_label(field, custom_fields) label: format_custom_field_label(field, custom_fields)
@ -128,18 +128,18 @@ defmodule MvWeb.Components.FieldVisibilityDropdownComponent do
# HELPERS (with defensive nil guards) # HELPERS (with defensive nil guards)
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
defp member_fields(nil), do: [] defp extract_member_field_keys(nil), do: []
defp member_fields(fields) do defp extract_member_field_keys(fields) do
Enum.filter(fields, fn field -> Enum.filter(fields, fn field ->
is_atom(field) || is_atom(field) ||
(is_binary(field) && not String.starts_with?(field, "custom_field_")) (is_binary(field) && not String.starts_with?(field, "custom_field_"))
end) end)
end end
defp custom_fields(nil), do: [] defp extract_custom_field_keys(nil), do: []
defp custom_fields(fields) do defp extract_custom_field_keys(fields) do
Enum.filter(fields, fn field -> Enum.filter(fields, fn field ->
is_binary(field) && String.starts_with?(field, "custom_field_") is_binary(field) && String.starts_with?(field, "custom_field_")
end) end)