Code review: SignInLive locale fallback, single root + id, CSS scoped to #sign-in-page, remove or-hack, refresh oidc_configured after save, tests assert English only

This commit is contained in:
Moritz 2026-02-24 15:41:30 +01:00
parent 951d01dc4d
commit fae1804fb1
Signed by: moritz
GPG key ID: 1020A035E5DD0824
4 changed files with 33 additions and 51 deletions

View file

@ -34,8 +34,8 @@ defmodule MvWeb.GlobalSettingsLive do
def mount(_params, session, socket) do
{:ok, settings} = Membership.get_settings()
# Get locale from session for translations
locale = session["locale"] || "de"
# Get locale from session; same fallback as router/LiveUserAuth (respects config :default_locale in test)
locale = session["locale"] || Application.get_env(:mv, :default_locale, "de")
Gettext.put_locale(MvWeb.Gettext, locale)
socket =
@ -407,6 +407,7 @@ defmodule MvWeb.GlobalSettingsLive do
|> assign(:settings, fresh_settings)
|> assign(:vereinfacht_api_key_set, present?(fresh_settings.vereinfacht_api_key))
|> assign(:oidc_client_secret_set, present?(fresh_settings.oidc_client_secret))
|> assign(:oidc_configured, Mv.Config.oidc_configured?())
|> assign(:vereinfacht_test_result, test_result)
|> put_flash(:info, gettext("Settings updated successfully"))
|> assign_form()