149 commits

Author	SHA1	Message	Date
Moritz	7eba21dc9c	Hide Regenerate Cycles button when no membership fee type assigned ... - Button only shown when @member.membership_fee_type is set (same as Create Cycle). - Test: no-type view asserts Regenerate Cycles button is not present.	2026-02-04 09:38:26 +01:00
Moritz	dbd0a57292	Secure regenerate_cycles: require can?(:create, MembershipFeeCycle) in handler ... - Handler returns flash error when non-admin triggers event (e.g. DevTools). - Test: read_only cannot create MembershipFeeCycle so handler rejects.	2026-02-04 09:19:37 +01:00
Moritz	182d34fe58	MemberLive: confirm_delete_all_cycles via Ash.destroy, reduce current_actor ... - Delete each cycle with Ash.destroy(actor:) so policies apply; add do_delete_all_cycles/5. - Use positive can? check; remove duplicate current_actor(socket) in change_membership_fee_type.	2026-02-04 00:34:00 +01:00
Moritz	e3bea17827	Member show & MembershipFees: permissions, delete all, regenerate, errors ... - Show: handle_info :member_updated and :put_flash; Linked User only when can_access_page? /users - MembershipFeesComponent: can_create_cycle/can_destroy_cycle/can_update_cycle; buttons gated - Delete all cycles via Ash.destroy (policy enforced); format_error Forbidden - Regenerate cycles for normal_user and admin (no admin-only check) - Member form: format_error tuple for membership_fee_type_id; Select a membership fee type (no None) - show_membership_fees_test: read_only UI and policy tests	2026-02-03 23:52:24 +01:00
Moritz	a4b13cef49	Member LiveViews: row_id and data-testid for actions ... Table row_id for scoped selectors; data-testid on New/Edit/Delete.	2026-02-03 17:16:11 +01:00
Moritz	505e31653a	Apply UI authorization to Member LiveViews (Index and Show) ... Gate New Member button, Edit and Delete links with can?/3. Edit button on Member Show visible only when user can update the member.	2026-02-03 16:56:51 +01:00
Moritz	1d17c4f2dd	fix: CustomField policies, no system-actor fallback, guidelines ... - Tests and UI pass actor for CustomField create/read/destroy; seeds use actor - Member required-custom-fields validation uses context.actor only (no fallback) - CODE_GUIDELINES: add rule forbidding system-actor fallbacks	2026-01-29 16:10:12 +01:00
Simon	bb7e3cbe77	fix: make sure all tests run	2026-01-29 14:49:39 +01:00
Simon	1b44730b95	Fix: Ensure members are loaded in handle_params when signature unchanged	2026-01-23 14:48:37 +01:00
Simon	672b4a8250	Merge branch 'main' into feature/filter-boolean-custom-fields	2026-01-23 14:41:48 +01:00
Simon	20c96123e1	fix: failing test	2026-01-23 14:33:54 +01:00
Simon	1d46fd1baf	feat: improve filter performance by reducing Ash.read! calls	2026-01-23 14:22:57 +01:00
Simon	b4657cae23	fix: resolve pr remarks	2026-01-23 14:00:18 +01:00
Moritz	47c938cc50	Centralize role preloading in global LiveView on_mount ... Add ensure_user_role_loaded to global live_view quote block. Remove redundant on_mount calls from individual LiveViews.	2026-01-22 21:36:15 +01:00
Moritz	b0ddf99117	Add admin authorization check for regenerate cycles button ... Restrict UI access to cycle regeneration to administrators only to prevent policy bypass via user interface	2026-01-21 08:02:38 +01:00
Simon	f996aee6b2	feat: add new filter component to members view	2026-01-21 00:47:01 +01:00
Moritz	c64b74588f	Use system actor for cycle generation ... Update cycle generator, member hooks, and job to use system actor. Remove actor parameters as cycle generation is a mandatory side effect.	2026-01-20 22:09:20 +01:00
Simon	1011b94acf	feat: load boolean custom fields	2026-01-20 19:12:13 +01:00
Simon	fbf3b64192	refactor: fix credo issues	2026-01-20 18:34:17 +01:00
Simon	01dea8bb8b	Merge branch 'main' into feature/filter-boolean-custom-fields	2026-01-20 18:13:20 +01:00
Simon	ff8b29cffe	feat: implement filter logic for boolean ustom fields	2026-01-20 18:08:41 +01:00
Moritz	433f008af8	refactor: Reduce function complexity and nesting depth ... - Extract helper functions from process_chunk to reduce nesting - Extract format_error_message from extract_changeset_error - Split extract_error_message into smaller functions to reduce complexity - Fixes Credo refactoring opportunities	2026-01-20 16:05:32 +01:00
Moritz	0abcf540bb	refactor: Replace length/1 with empty list comparison ... Replace expensive length/1 calls with direct list comparison to fix Credo warnings about performance	2026-01-20 15:58:15 +01:00
Simon	37e1553a02	feat: add custom boolean field state & URL-Parameter	2026-01-20 15:55:08 +01:00
Moritz	9c2cff6307	docs: Update domain Public API documentation	2026-01-20 15:50:08 +01:00
Moritz	b380f63cf6	chore: update docs	2026-01-20 14:31:13 +01:00
Simon	d9b659e5ea	fix: linting + tests	2026-01-19 14:09:19 +01:00
Simon	584442076e	fix: add error message to form	2026-01-19 12:47:17 +01:00
Moritz	b103ae3a5f	i18n: Update English translations	2026-01-13 16:30:32 +01:00
Moritz	a22081f288	refactor: Replace bang calls with error handling in Index LiveViews ... - Replace Ash.get!/Ash.destroy! with Ash.get/Ash.destroy - Add case statements for Forbidden, NotFound, and generic errors - Display user-friendly flash messages for all error cases - Use Enum.map_join/3 for efficient error formatting	2026-01-13 15:17:07 +01:00
Moritz	77ae5c4888	refactor: Use submit_form wrapper in all LiveView forms ... - Replace AshPhoenix.Form.submit with submit_form/3 wrapper - Import current_actor and submit_form from LiveHelpers - Consistent actor handling in all form submissions	2026-01-13 15:17:06 +01:00
Moritz	351eac4c02	Fix error handling and actor access in MemberLive.Index ... Replace bang calls with proper error handling and use current_actor/1 helper for consistent actor access.	2026-01-13 15:17:05 +01:00
Moritz	cd7e6b0843	Use current_actor/1 helper in all LiveViews ... Replace inconsistent actor access patterns with current_actor/1 helper and ensure actor is passed to all Ash operations for proper authorization.	2026-01-13 15:16:00 +01:00
Moritz	075a06ba6f	Refactor test setup: use global setup and fix MembershipFees domain alias ... - Remove redundant setup blocks from member_live tests - Add build_unauthenticated_conn helper for AuthController tests - Add global setup in conn_case.ex	2026-01-13 15:15:56 +01:00
Moritz	bc87893134	Integrate Member policies in LiveViews ... - Add on_mount hook to ensure user role is loaded in all Member LiveViews - Pass actor parameter to all Ash operations (read, get, create, update, destroy, load)	2026-01-13 15:12:24 +01:00
carla	35895ac7fd	fix tests	2026-01-13 10:48:44 +01:00
carla	47c46eaebf	i18n: update translations	2026-01-08 11:40:04 +01:00
carla	30c43271ea	refactor: remove code duplication using helper modules	2026-01-08 11:37:07 +01:00
carla	36776f8e28	fix tests and linting	2026-01-07 18:11:36 +01:00
carla	38d106a69e	fix: exit date as default hidden column	2026-01-07 12:14:41 +01:00
carla	a5a1cb7fdd	style: remove display name helper in member overview for UX	2026-01-07 09:55:06 +01:00
carla	9f97515d74	chore: movs display name helper to won helper module	2026-01-07 09:54:37 +01:00
carla	e1211fcf0f	fix linting	2026-01-07 09:05:51 +01:00
carla	b59a4ef61a	feat: adds email as fallback for name in member details	2026-01-06 16:43:13 +01:00
carla	dc8271451d	feat: adapt UI	2026-01-02 16:20:23 +01:00
carla	08f563a412	Merge branch 'main' into bugfix/274_required_custom_fields	2026-01-02 13:47:24 +01:00
Moritz	0df5d1c0b9	Merge branch 'main' into feature/280_membership_fee_ui	2025-12-26 23:14:10 +01:00
Moritz	77ac3d1b18	fix: remove duplicate toggle button in table header ... Keep only the toggle button in toolbar for better UX.	2025-12-26 21:41:22 +01:00
Moritz	856ce53295	fix: improve MembershipFeesComponent state management and error handling ... Replace assign_new with assign for cycles and available_fee_types. Set regenerating flag at event start. Fix create_cycle parsing with explicit error handling. Use atomic bulk delete for all cycles. Improve delete confirmation robustness. Fix unless/else pattern for Credo compliance.	2025-12-26 21:41:05 +01:00
carla	3cf8244cd6	fix linting errors	2025-12-23 18:14:59 +01:00