209 commits

Author	SHA1	Message	Date
Moritz	5eadd5f090	Refactor test setup into helper functions ... Extract setup code into reusable helper functions to reduce duplication and improve maintainability.	2026-01-20 23:16:40 +01:00
Moritz	a3cf8571ff	Document System Actor pattern in code guidelines ... Add section explaining when and how to use system actor for systemic operations. Include examples and distinction between user mode and system mode.	2026-01-20 22:10:11 +01:00
Moritz	f1bb6a0f9a	Add tests for System Actor helper ... Test system actor retrieval, caching, fallback behavior, and auto-creation in test environment.	2026-01-20 22:09:21 +01:00
Moritz	235154a102	test: Remove outdated TODO for auto-assignment feature ... Auto-assignment of default membership fee type is already implemented via SetDefaultMembershipFeeType change. Test assertion is now active.	2026-01-20 16:33:50 +01:00
Moritz	0abcf540bb	refactor: Replace length/1 with empty list comparison ... Replace expensive length/1 calls with direct list comparison to fix Credo warnings about performance	2026-01-20 15:58:15 +01:00
Moritz	32e0adb664	test: Add tests for UserLive.Show and RoleLive.Show ... - Add comprehensive tests for UserLive.Show - Add comprehensive tests for RoleLive.Show - Cover mount, display, navigation, and error handling	2026-01-20 15:50:08 +01:00
Moritz	cafd1d4ebc	refactor: Remove deprecated LiveViews ... - Remove CustomFieldValueLive (Index, Form, Show) - Remove ContributionTypeLive.Index - Remove ContributionPeriodLive.Show - Remove corresponding routes from router - Remove references in CustomFieldValueLive.Index	2026-01-20 15:50:08 +01:00
simon	b84431879c	Merge pull request 'fix admin database seeding closes #357' (#358) from bugfix/reseeding-database-not-working into main ... Reviewed-on: #358	2026-01-19 14:17:12 +01:00
Simon	d9b659e5ea	fix: linting + tests	2026-01-19 14:09:19 +01:00
Simon	bc4bcd0089	fix: change creation of admin user	2026-01-19 13:40:28 +01:00
Simon	584442076e	fix: add error message to form	2026-01-19 12:47:17 +01:00
carla	3cbd90ecdd	feat: adds error capping	2026-01-19 12:02:28 +01:00
carla	24426c7786	Merge branch 'main' into feature/333_validation	2026-01-19 11:46:14 +01:00
carla	7da037d81d	refactor: adds schemales changeset and validation constant	2026-01-19 11:43:51 +01:00
carla	8b3cc6a6b2	feat: adds row validation	2026-01-19 11:22:11 +01:00
Simon	c86ae6aa9d	fix: sidebar accessibility	2026-01-16 14:17:15 +01:00
Simon	d6173571b5	test: make tests more structural, less dependend on specific values	2026-01-16 12:48:35 +01:00
carla	6dc398fa5a	refactor: reduce complexity	2026-01-15 17:00:17 +01:00
carla	0673684cc1	test: adds tests for header normalization	2026-01-15 16:11:02 +01:00
carla	3bbe9895ee	fix: improve CSV parser error handling	2026-01-15 11:08:22 +01:00
carla	31cf07c071	test: updated tests	2026-01-15 10:10:14 +01:00
carla	4b41ab37bb	Merge branch 'main' into feature/330_import_service_skeleton	2026-01-14 12:30:40 +01:00
carla	aa3fb0c49b	fix linting	2026-01-14 10:48:36 +01:00
carla	aa62e03409	skip test for now	2026-01-14 09:11:44 +01:00
Moritz	970c749a92	test: Add role tag support to ConnCase and fix test issues ... - Add role tag support (@tag role: :admin/:member/:unauthenticated) to ConnCase - Fix Keyword.get -> Map.get for tags Map - Remove duplicate test file index_display_name_test.exs - Fix CustomField creation in tests (remove slug, use :string instead of :text) - Fix CustomFieldValue value format to use _union_type/_union_value	2026-01-13 15:17:06 +01:00
Moritz	145a76348c	Pass actor parameter in seeds and update test setup ... Ensure cycle generation in seeds uses admin actor and update test to use global admin_user from ConnCase setup.	2026-01-13 15:17:05 +01:00
Moritz	075a06ba6f	Refactor test setup: use global setup and fix MembershipFees domain alias ... - Remove redundant setup blocks from member_live tests - Add build_unauthenticated_conn helper for AuthController tests - Add global setup in conn_case.ex	2026-01-13 15:15:56 +01:00
Moritz	c95a6fac69	Improve: Make deny_filter robust and add regression test ... - Change deny_filter from [id: {:in, []}] to expr(false) - Add regression test to ensure deny-filter matches 0 records	2026-01-13 15:01:55 +01:00
Moritz	42a463f422	Security: Fix critical deny-filter bug and improve authorization ... CRITICAL FIX: Deny-filter was allowing all records instead of denying Fix: User validation in Member now uses actor from changeset.context	2026-01-13 15:01:55 +01:00
Moritz	70729bdd73	Fix: HasPermission auto_filter and strict_check implementation ... Fixes security issue where auto_filter returned nil instead of proper filter expressions, which could lead to incorrect authorization behavior.	2026-01-13 15:01:54 +01:00
Moritz	93190d558f	test: add Member resource policy tests	2026-01-13 15:01:53 +01:00
carla	cc6d72b6b1	feat: add service skeleton and tests	2026-01-13 11:44:40 +01:00
carla	6fe75db56d	formatting	2026-01-13 10:50:33 +01:00
carla	35895ac7fd	fix tests	2026-01-13 10:48:44 +01:00
Simon	8a1b14fc79	fix: fix tests and remove navbar remainings	2026-01-12 15:16:31 +01:00
Simon	e7515b5450	Merge remote-tracking branch 'origin/main' into sidebar	2026-01-12 14:15:12 +01:00
carla	922f9f93d0	Merge branch 'main' into feature/223_memberfields_settings	2026-01-12 13:15:40 +01:00
carla	77908a1467	fix tests	2026-01-12 11:45:44 +01:00
Moritz	db0a187058	fix: correct relationship filter paths in HasPermission check ... - Use user.id instead of user_id for Member linked scope - Use member.user.id for CustomFieldValue linked scope - Add lazy logger evaluation - Improve action nil handling - Add integration tests for filter expressions	2026-01-08 17:45:02 +01:00
Moritz	cba471dcac	test: add tests for HasPermission policy check ... Add comprehensive test suite for the HasPermission Ash Policy Check covering permission lookup, scope application, error handling, and logging.	2026-01-08 16:48:42 +01:00
Moritz	03c1f747c5	chore: update gettext files and test cleanup ... Update translation files after code changes and remove unused debug logging code from tests.	2026-01-08 16:20:22 +01:00
Moritz	c9b83a501f	fix: prefix unused view variable with underscore ... Fix compiler warning for unused variable in role_live_test.exs	2026-01-08 16:16:54 +01:00
Moritz	9a86e0ec01	feat: implement role management LiveViews ... Add complete CRUD interface for role management under /admin/roles. - Index page with table showing name, description, permission_set_name, is_system_role - Show page for role details - Form component for create/edit with permission_set_name dropdown - System role badge and disabled delete button - Flash messages for success/error - Authorization checks using MvWeb.Authorization helpers - Comprehensive test coverage (22 tests) Routes added under /admin scope. All LiveViews load user role for authorization checks. Form uses custom dropdown for permission sets.	2026-01-08 16:16:53 +01:00
Moritz	ff9c8d2d64	feat: add UI-level authorization helpers ... Implement MvWeb.Authorization module with can?/3 and can_access_page?/2 functions for conditional rendering in LiveView templates. - can?/3 supports both resource atoms and record structs with scope checking - can_access_page?/2 checks page access permissions - All functions use PermissionSets module for consistency with backend - Graceful handling of nil users and invalid permission sets - Comprehensive test coverage with 17 test cases	2026-01-08 16:16:53 +01:00
carla	e565d1748e	test: add tests for atomic member field visibility updates	2026-01-08 11:38:41 +01:00
carla	36776f8e28	fix tests and linting	2026-01-07 18:11:36 +01:00
carla	df8c6a1854	Merge branch 'main' into feature/223_memberfields_settings	2026-01-07 11:42:54 +01:00
carla	909d4af2a2	Merge branch 'main' into feature/223_memberfields_settings	2026-01-07 11:11:02 +01:00
carla	0c8a255476	Merge branch 'main' into feature/273_member_fields	2026-01-07 10:22:18 +01:00
carla	9f97515d74	chore: movs display name helper to won helper module	2026-01-07 09:54:37 +01:00