Commit graph

5 commits

Author SHA1 Message Date
e3d615acb8
Fix failing tests after filter refactoring
Some checks failed
continuous-integration/drone/push Build is failing
Update tests to use new cycle_status_filter parameter instead of
membership_fee_filter. Fix button selector for toggle_cycle_view to
target the header button. Fix edit cycle amount test to click on
span element instead of button.
2025-12-18 15:11:04 +01:00
128c712dbc
fix: improve get_last_completed_cycle and fix test helpers
- Fix get_last_completed_cycle to find most recent completed cycle
- Fix create_cycle helpers to delete auto-generated cycles first
- Fix Ash.destroy return value handling
- Fix form selectors to use specific IDs
- Fix URL parameter names for filters
- Fix Ash.read_one return value expectations in tests
2025-12-18 15:10:35 +01:00
98dc73ee37
refactor: fix credo warnings and format code
- Replace Enum.map/2 |> Enum.join/2 with Enum.map_join/3 for efficiency
- Refactor get_existing_form_values to reduce cyclomatic complexity
- Replace length/1 with Enum.empty?/1 for better performance
- Update gettext translations
2025-12-18 15:10:07 +01:00
355d5bea9e
fix: use conn_with_password_user instead of log_in_user in test
- Replace log_in_user with conn_with_password_user for consistency
- Fixes compilation error in membership fee integration test
2025-12-18 15:08:33 +01:00
5789079ab0
test: add comprehensive tests for membership fee UI components
Add tests for all membership fee UI components following TDD principles:
2025-12-18 15:08:32 +01:00