feature/account_view closes #106 #109

Merged
moritz merged 10 commits from feature/account_view into main 2025-07-24 17:08:34 +02:00
Owner
http://localhost:4000/users
moritz added this to the Accounts & Logins milestone 2025-07-17 22:17:11 +02:00
moritz self-assigned this 2025-07-17 22:17:11 +02:00
moritz added 2 commits 2025-07-17 22:17:13 +02:00
moritz added this to the Sprint 4 - 09.07 - 30.07 project 2025-07-17 22:17:14 +02:00
moritz force-pushed feature/account_view from ccf2d61d84 to edb3978b64 2025-07-17 22:35:31 +02:00 Compare
moritz force-pushed feature/account_view from edb3978b64 to ff9b3bc5f3 2025-07-22 23:59:14 +02:00 Compare
moritz added 1 commit 2025-07-23 00:08:19 +02:00
fix: formatting
All checks were successful
continuous-integration/drone/push Build is passing
a6f9de3eab
moritz changed title from WIP: feature/account_view closes #106 to feature/account_view closes #106 2025-07-23 00:09:57 +02:00
requested reviews from simon, carla, rafael 2025-07-23 00:19:47 +02:00
carla approved these changes 2025-07-24 13:24:03 +02:00
carla left a comment
Owner

Overall it looks good 👍
just the few (more questions than comments) I added.

Overall it looks good 👍 just the few (more questions than comments) I added.
@ -8,3 +8,3 @@
resources do
resource Mv.Accounts.User do
define :create_user, action: :create
define :create_user, action: :create_user
Owner

Was there a reson to rename it?

Was there a reson to rename it?
Author
Owner

I needed to define a custom create_user and update_user, so these actions can accept email as argument. The default actions don't accept any arguments. See user.ex

I needed to define a custom create_user and update_user, so these actions can accept `email` as argument. The default actions don't accept any arguments. See `user.ex`
moritz marked this conversation as resolved
@ -0,0 +38,4 @@
{:noreply, assign(socket, :selected_users, selected)}
end
# Sorts the list of users according to a field, when you click on the column header
Owner

maybe at some point we can seperate the sort function as we use the same in members?

maybe at some point we can seperate the sort function as we use the same in members?
Author
Owner

Yes I think we can do some refactoring like this in a few weeks to merge some duplicated functions. I created this issue to collect some refactor steps: #122

Yes I think we can do some refactoring like this in a few weeks to merge some duplicated functions. I created this issue to collect some refactor steps: https://git.local-it.org/local-it/mitgliederverwaltung/issues/122
moritz marked this conversation as resolved
mix.lock Outdated
@ -6,3 +6,3 @@
"ash_phoenix": {:hex, :ash_phoenix, "2.3.11", "3003cb7fbda4eba829a67a064af15bc23f4032b86c768c3336e3a04218d19f37", [:mix], [{:ash, ">= 3.5.13 and < 4.0.0-0", [hex: :ash, repo: "hexpm", optional: false]}, {:igniter, "~> 0.6", [hex: :igniter, repo: "hexpm", optional: true]}, {:inertia, "~> 2.3", [hex: :inertia, repo: "hexpm", optional: true]}, {:phoenix, "~> 1.5.6 or ~> 1.6", [hex: :phoenix, repo: "hexpm", optional: false]}, {:phoenix_html, "~> 4.0", [hex: :phoenix_html, repo: "hexpm", optional: false]}, {:phoenix_live_view, "~> 0.20.3 or ~> 1.0-rc.1", [hex: :phoenix_live_view, repo: "hexpm", optional: false]}, {:spark, ">= 2.2.29 and < 3.0.0-0", [hex: :spark, repo: "hexpm", optional: false]}], "hexpm", "33294de690af8c408759c629fd4212e1b4639b1da8417f5c7b31cb3898e6cb4f"},
"ash_postgres": {:hex, :ash_postgres, "2.6.11", "7c6b4fa9b8725c6644dd863323f8a2dae93f5df8ddae4b53df5dabde451a8b0c", [:mix], [{:ash, ">= 3.5.13 and < 4.0.0-0", [hex: :ash, repo: "hexpm", optional: false]}, {:ash_sql, ">= 0.2.72 and < 1.0.0-0", [hex: :ash_sql, repo: "hexpm", optional: false]}, {:ecto, "~> 3.13", [hex: :ecto, repo: "hexpm", optional: false]}, {:ecto_sql, "~> 3.13", [hex: :ecto_sql, repo: "hexpm", optional: false]}, {:igniter, ">= 0.6.14 and < 1.0.0-0", [hex: :igniter, repo: "hexpm", optional: true]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}, {:postgrex, ">= 0.0.0", [hex: :postgrex, repo: "hexpm", optional: false]}], "hexpm", "d915f06406b46130559481b8b4290fd3bf60b0bd57bf5a4903cde0613b642c36"},
"ash_sql": {:hex, :ash_sql, "0.2.87", "17197c643918cdaee657946a1998860402dcf53a980f7665bb81d1fa53c224e7", [], [{:ash, ">= 3.5.25 and < 4.0.0-0", [hex: :ash, repo: "hexpm", optional: false]}, {:ecto, "~> 3.9", [hex: :ecto, repo: "hexpm", optional: false]}, {:ecto_sql, "~> 3.9", [hex: :ecto_sql, repo: "hexpm", optional: false]}], "hexpm", "f82d6bf78f08bd9040af3adc28676965421598c88866074d8b1ccca65978d774"},
"ash_sql": {:hex, :ash_sql, "0.2.87", "17197c643918cdaee657946a1998860402dcf53a980f7665bb81d1fa53c224e7", [:mix], [{:ash, ">= 3.5.25 and < 4.0.0-0", [hex: :ash, repo: "hexpm", optional: false]}, {:ecto, "~> 3.9", [hex: :ecto, repo: "hexpm", optional: false]}, {:ecto_sql, "~> 3.9", [hex: :ecto_sql, repo: "hexpm", optional: false]}], "hexpm", "f82d6bf78f08bd9040af3adc28676965421598c88866074d8b1ccca65978d774"},
Owner

What does that do?

What does that do?
Author
Owner

This was generated by mix deps.update It just means that ash_sql was installed by mix and its used for mix.

This was generated by `mix deps.update` It just means that ash_sql was installed by mix and its used for mix.
moritz marked this conversation as resolved
moritz force-pushed feature/account_view from a6f9de3eab to 845f347fac 2025-07-24 16:03:09 +02:00 Compare
moritz force-pushed feature/account_view from 845f347fac to a6f9de3eab 2025-07-24 16:50:50 +02:00 Compare
moritz force-pushed feature/account_view from a6f9de3eab to 06574a932d 2025-07-24 17:07:30 +02:00 Compare
moritz merged commit 25473afc43 into main 2025-07-24 17:08:34 +02:00
moritz deleted branch feature/account_view 2025-07-24 17:08:39 +02:00
Sign in to join this conversation.
No description provided.