local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 51 Pull requests 13 Projects 1 Releases Packages 1 Activity Actions

feature/96_design_memberlist closes #96 #112

Merged
moritz merged 6 commits from feature/96_design_memberlist into main 2025-07-22 18:36:46 +02:00
Conversation 2 Commits 6 Files changed 9 +903 -396
carla commented 2025-07-21 11:50:08 +02:00
Owner
Copy link

I updated the memberslist just a little bit, I think more changes should be done after the first workshop and we have clearer insights.
Additionally I updated the navbar with the DaisyUI Navbar component. Also just as a first draft.

I updated the memberslist just a little bit, I think more changes should be done after the first workshop and we have clearer insights. Additionally I updated the navbar with the DaisyUI Navbar component. Also just as a first draft.
carla added 6 commits 2025-07-21 11:50:09 +02:00
chore; added translation for listing members
Some checks failed
continuous-integration/drone/push Build is failing
Details
6f59019868
requested reviews from moritz, simon, rafael 2025-07-21 11:50:34 +02:00
moritz requested changes 2025-07-21 12:48:44 +02:00
moritz left a comment
Owner
Copy link

Overall it looks very good 🚀

Overall it looks very good 🚀
lib/mv_web/components/layouts.ex Outdated
@ -56,4 +36,0 @@
<a href="https://github.com/phoenixframework/phoenix" class="btn btn-ghost">GitHub</a>
</li>
<li>
<.theme_toggle />
moritz commented 2025-07-21 12:39:14 +02:00
Owner
Copy link

Is it by purpose, that you removed the theme toggle?

Is it by purpose, that you removed the theme toggle?
carla commented 2025-07-21 14:34:07 +02:00
Author
Owner
Copy link

I actually just wanted to start with a more or less clean navbar. But of course we can also keep it!

I actually just wanted to start with a more or less clean navbar. But of course we can also keep it!
moritz marked this conversation as resolved
lib/mv_web/components/layouts.ex Outdated
@ -44,4 +36,0 @@
<form method="post" action="/set_locale" class="mr-4">
<input type="hidden" name="_csrf_token" value={Plug.CSRFProtection.get_csrf_token()} />
<select name="locale" onchange="this.form.submit()" class="select select-sm">
<option value="de" selected={Gettext.get_locale() == "de"}>Deutsch</option>
moritz commented 2025-07-21 12:37:16 +02:00
Owner
Copy link

Is it by purpose, that you removed the language selection?

Is it by purpose, that you removed the language selection?
carla commented 2025-07-21 14:34:25 +02:00
Author
Owner
Copy link

No, I will add it again :)

No, I will add it again :)
moritz marked this conversation as resolved
lib/mv_web/live/set_locale.ex Outdated
@ -0,0 +3,4 @@
The Module to make the locale available to all LiveViews
"""
import Phoenix.Component
import MvWeb.Gettext
moritz commented 2025-07-21 12:09:37 +02:00
Owner
Copy link

This line creates a linting error in the CI.
I think this commit can be removed at all, as I fixed the locale issue in the upgrade to phoenix 1.8 again.

This line creates a linting error in the CI. I think this commit can be removed at all, as I fixed the locale issue in the upgrade to phoenix 1.8 again.
moritz marked this conversation as resolved
mix.exs Outdated
@ -71,3 +71,3 @@
{:gettext, "~> 0.26"},
{:jason, "~> 1.2"},
{:dns_cluster, "~> 0.2.0"},
{:dns_cluster, "~> 0.1.1"},
moritz commented 2025-07-21 12:12:46 +02:00
Owner
Copy link

I think this is an old artifact from the unfinished migration branch. Or is there any reason for downgrading this package? Maybe this commit can be removed.

I think this is an old artifact from the unfinished migration branch. Or is there any reason for downgrading this package? Maybe this commit can be removed.
👍 1
moritz marked this conversation as resolved
mix.lock Outdated
@ -18,3 +18,3 @@
"db_connection": {:hex, :db_connection, "2.8.0", "64fd82cfa6d8e25ec6660cea73e92a4cbc6a18b31343910427b702838c4b33b2", [:mix], [{:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "008399dae5eee1bf5caa6e86d204dcb44242c82b1ed5e22c881f2c34da201b15"},
"decimal": {:hex, :decimal, "2.3.0", "3ad6255aa77b4a3c4f818171b12d237500e63525c2fd056699967a3e7ea20f62", [:mix], [], "hexpm", "a4d66355cb29cb47c3cf30e71329e58361cfcb37c34235ef3bf1d7bf3773aeac"},
"dns_cluster": {:hex, :dns_cluster, "0.2.0", "aa8eb46e3bd0326bd67b84790c561733b25c5ba2fe3c7e36f28e88f384ebcb33", [:mix], [], "hexpm", "ba6f1893411c69c01b9e8e8f772062535a4cf70f3f35bcc964a324078d8c8240"},
"dns_cluster": {:hex, :dns_cluster, "0.1.3", "0bc20a2c88ed6cc494f2964075c359f8c2d00e1bf25518a6a6c7fd277c9b0c66", [:mix], [], "hexpm", "46cb7c4a1b3e52c7ad4cbe33ca5079fbde4840dedeafca2baf77996c2da1bc33"},
moritz commented 2025-07-21 12:40:23 +02:00
Owner
Copy link

This downgrade belongs to the first commit and could be removed as well.

This downgrade belongs to the first commit and could be removed as well.
👍 1
moritz marked this conversation as resolved
priv/gettext/en/LC_MESSAGES/default.po Outdated
@ -92,3 +92,3 @@
#, elixir-autogen, elixir-format
msgid "Listing Members"
msgstr ""
msgstr "Members"
moritz commented 2025-07-21 12:46:11 +02:00
Owner
Copy link

Why is Listing Members translated to Members? Wouldn't it be easier to write Members in first place?

Why is `Listing Members` translated to `Members`? Wouldn't it be easier to write `Members` in first place?
carla commented 2025-07-21 14:36:15 +02:00
Author
Owner
Copy link

Listing Members was the automatically created id actually that I did not want to change but yes makes sense to than regen the id ;)

Listing Members was the automatically created id actually that I did not want to change but yes makes sense to than regen the id ;)
moritz marked this conversation as resolved
carla force-pushed feature/96_design_memberlist from 6f59019868 to 89eac7d8ca 2025-07-21 15:14:23 +02:00 Compare
carla force-pushed feature/96_design_memberlist from 89eac7d8ca to 50c80eed38 2025-07-21 15:24:13 +02:00 Compare
carla added 1 commit 2025-07-21 15:24:57 +02:00
feat (navbar): readded theme toggle and language picker
Some checks failed
continuous-integration/drone/push Build is failing
Details
ab81b29467
carla added 1 commit 2025-07-21 16:01:47 +02:00
feat (theme-toggle): replaced theme toggle with the one from daisy UI
All checks were successful
continuous-integration/drone/push Build is passing
Details
ed9616035b
moritz added this to the Sprint 4 - 09.07 - 30.07 project 2025-07-22 18:21:20 +02:00
moritz approved these changes 2025-07-22 18:35:59 +02:00
moritz left a comment
Owner
Copy link

The missing translations can be done later. The PR looks good, I will merge it.

The missing translations can be done later. The PR looks good, I will merge it.
priv/gettext/de/LC_MESSAGES/default.po
@ -275,0 +254,4 @@
#: lib/mv_web/live/property_type_live/form.ex:32
#, elixir-autogen, elixir-format
msgid "Cancel"
msgstr ""
moritz commented 2025-07-22 18:29:24 +02:00
Owner
Copy link

some german translations are missing here.

some german translations are missing here.
moritz merged commit 5c4f8ec07e into main 2025-07-22 18:36:46 +02:00
moritz deleted branch feature/96_design_memberlist 2025-07-22 18:36:48 +02:00
carla was assigned by moritz 2025-07-24 20:22:22 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
simon
rafael
moritz
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
high priority

   
invalid

Something is wrong

  
L

5 h

  
low priority

   
M

3 h

  
medium priority

   
needs refinement

   
question

More information is needed

  
S

1 h

  
UX research

   
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
question
S
UX research
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Sprint 4 - 09.07 - 30.07
Assignees
Clear assignees
No assignees
carla
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: local-it/mitgliederverwaltung#112
No description provided.
Delete branch "feature/96_design_memberlist"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?