Custom Fields: Harden implementation #194

New issue

Closed

opened 2025-11-10 15:04:44 +01:00 by simon · 0 comments

simon commented

2025-11-10 15:04:44 +01:00

Owner

Description

We agreed on hardening the implementation. This includes:

renaming the resources
adding validations - make sure the value matches the type before saving for the existing types :string, :integer, :boolean, :date, :email, provide error messages and proof via tests
make sure a member can only have one of each custom_field -> test!
make sure all custom_fields can be optional/empty (also mail!) -> test!
make sure custom_fields are also translated in the UI -> test!
add maximum for Custom Field names, e.g. 100 chars
add maximum for Custom Field values, e.g. 10k chars for strings
adding tests for the current basic implementation
add database seeds for the existing custom fields

Acceptance criteria

renamed property to custom_field_value
renamed property_type to custom_field
updated documentation and ERM where needed
hardened implementation according to description
added tests

## Description We agreed on hardening the implementation. This includes: - renaming the resources - adding validations - make sure the value matches the type before saving for the existing types `:string`, `:integer`, `:boolean`, `:date`, `:email`, provide error messages and proof via tests - make sure a member can only have one of each `custom_field` -> test! - make sure all custom_fields can be optional/empty (also mail!) -> test! - make sure custom_fields are also translated in the UI -> test! - add maximum for Custom Field names, e.g. 100 chars - add maximum for Custom Field values, e.g. 10k chars for strings - adding tests for the current basic implementation - add database seeds for the existing custom fields ## Acceptance criteria - [x] renamed `property` to `custom_field_value` - [x] renamed `property_type` to `custom_field` - [x] updated documentation and ERM where needed - [x] hardened implementation according to description - [x] added tests