local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 51 Pull requests 13 Projects 1 Releases Packages 1 Activity Actions

Custom Fields: Handle Deletion of custom fields, closes #199 #206

Merged
moritz merged 3 commits from feature/custom-field-deletion into main 2025-11-20 15:10:24 +01:00
Conversation 1 Commits 3 Files changed 11 +939 -16
moritz commented 2025-11-13 20:07:20 +01:00
Owner
Copy link

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

#199

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues
## Description of the implemented changes The changes were: - [ ] Bugfixing - [x] New Feature - [ ] Breaking Change - [ ] Refactoring https://git.local-it.org/local-it/mitgliederverwaltung/issues/199 ## Definition of Done ### Code Quality - [x] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [x] axe-core dev tools show no critical or major issues
moritz added 7 commits 2025-11-13 20:07:22 +01:00
refactor: Rename Property/PropertyType to CustomFieldValue/CustomField
All checks were successful
continuous-integration/drone/push Build is passing
Details
8400e727a7 
Complete refactoring of resources, database tables, code references, tests, and documentation for improved naming consistency.
fix: Allow optional email values in custom fields
All checks were successful
continuous-integration/drone/push Build is passing
Details
2b3c94d3b2
feat: Add Custom Fields link to navbar
All checks were successful
continuous-integration/drone/push Build is passing
Details
158ac52d97
feat: add custom field slug
All checks were successful
continuous-integration/drone/push Build is passing
Details
0135dafa3a
feat: custom field deletion
All checks were successful
continuous-integration/drone/push Build is passing
Details
b46598cf7a
requested reviews from simon, carla 2025-11-13 20:07:42 +01:00
moritz self-assigned this 2025-11-13 20:32:30 +01:00
carla added 1 commit 2025-11-18 09:06:37 +01:00
Merge branch 'main' into feature/custom-field-deletion
All checks were successful
continuous-integration/drone/push Build is passing
Details
da04ca2626
carla approved these changes 2025-11-19 16:23:17 +01:00
carla left a comment
Owner
Copy link

Great! 🎊

Great! 🎊
lib/mv_web/live/custom_field_live/index.ex Outdated
@ -68,1 +70,4 @@
</.table>
<%!-- Delete Confirmation Modal --%>
<dialog :if={@show_delete_modal} id="delete-custom-field-modal" class="modal modal-open">
carla commented 2025-11-19 16:21:03 +01:00
Owner
Copy link

One minor thing: The focus of the keyboard is not automatically set to the dialog. But I think we can have a seperate accessibility issue for that if you cannot take care of that easily now. Same of the contrast of the orange buttons, but that's a general thing.

One minor thing: The focus of the keyboard is not automatically set to the dialog. But I think we can have a seperate accessibility issue for that if you cannot take care of that easily now. Same of the contrast of the orange buttons, but that's a general thing.
moritz marked this conversation as resolved
lib/mv_web/live/custom_field_live/index.ex Outdated
@ -69,0 +86,4 @@
count: @custom_field_to_delete.assigned_members_count
)}
</p>
<p class="text-sm mt-2">
carla commented 2025-11-18 09:15:52 +01:00
Owner
Copy link

Cool that you already thought about the confirmation dialog, I like the way with entering the text 👍

Cool that you already thought about the confirmation dialog, I like the way with entering the text 👍
moritz marked this conversation as resolved
lib/mv_web/live/custom_field_live/index.ex Outdated
@ -69,0 +97,4 @@
<div>
<label for="slug-confirmation" class="label">
<span class="label-text">
{gettext("To confirm deletion, please enter the custom field slug:")}
carla commented 2025-11-18 09:15:00 +01:00
Owner
Copy link

Just a minor thing: The text is not wrapped and partly hidden (at least for me in the browser). And maybe we can just say: please enter the following text. Because the term slug might be confusing for the user.

Just a minor thing: The text is not wrapped and partly hidden (at least for me in the browser). And maybe we can just say: please enter the following text. Because the term slug might be confusing for the user.
moritz marked this conversation as resolved
lib/mv_web/live/custom_field_live/show.ex Outdated
@ -48,6 +50,8 @@ defmodule MvWeb.CustomFieldLive.Show do
<.list>
<:item title="Id">{@custom_field.id}</:item>
<:item title="Slug">{@custom_field.slug}</:item>
carla commented 2025-11-19 16:22:30 +01:00
Owner
Copy link

In general: Maybe we should not show the slug to the user as it is not relevant for them and they probably do not know what is it?
In the confirmation dialog we can maybe just write "text" instead of slug? :) Or phrase?

In general: Maybe we should not show the slug to the user as it is not relevant for them and they probably do not know what is it? In the confirmation dialog we can maybe just write "text" instead of slug? :) Or phrase?
moritz marked this conversation as resolved
moritz force-pushed feature/custom-field-deletion from da04ca2626 to 8ba15eb16b 2025-11-20 15:08:19 +01:00 Compare
moritz merged commit 70b3875154 into main 2025-11-20 15:10:24 +01:00
moritz deleted branch feature/custom-field-deletion 2025-11-20 15:10:25 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
simon
carla
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
high priority

   
invalid

Something is wrong

  
L

5 h

  
low priority

   
M

3 h

  
medium priority

   
needs refinement

   
question

More information is needed

  
S

1 h

  
UX research

   
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
question
S
UX research
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
moritz
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: local-it/mitgliederverwaltung#206
No description provided.
Delete branch "feature/custom-field-deletion"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?