local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 51 Pull requests 13 Projects 1 Releases Packages 1 Activity Actions

Implement setting to show/hide member fields technically closes #214 #232

Merged
rafael merged 7 commits from feature/214_hide_memberfields into main 2025-12-02 14:33:10 +01:00
Conversation 1 Commits 7 Files changed 11 +503 -55
carla commented 2025-12-02 09:26:03 +01:00
Owner
Copy link

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

What has been changed?

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues

Additional Notes

## Description of the implemented changes The changes were: - [ ] Bugfixing - [x] New Feature - [ ] Breaking Change - [ ] Refactoring <!--- Describe the goal of the PR in a few words --> ## What has been changed? <!--- List the things you changed --> ## Definition of Done ### Code Quality - [ ] No new technical depths - [x] Linting passed - [ ] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [ ] axe-core dev tools show no critical or major issues ## Additional Notes <!--- Add any additional information for the reviewers here -->
carla added 5 commits 2025-12-02 09:26:04 +01:00
feat: adds member visibility to live view
Some checks failed
continuous-integration/drone/push Build is failing
Details
7f0da693ee
carla added this to the Sprint 9: 20.11 - 11.12 project 2025-12-02 09:26:05 +01:00
carla added 1 commit 2025-12-02 10:03:00 +01:00
formatting and refactor member fields constant
All checks were successful
continuous-integration/drone/push Build is passing
Details
d039e4bb7d
requested reviews from moritz, simon, rafael 2025-12-02 10:03:52 +01:00
carla changed title from WIP: Implement setting to show/hide member fields technically closes #214 to Implement setting to show/hide member fields technically closes #214 2025-12-02 10:03:58 +01:00
removed review requests for moritz, simon 2025-12-02 11:44:15 +01:00
rafael reviewed 2025-12-02 12:02:22 +01:00
lib/mv/constants.ex Outdated
@ -0,0 +19,4 @@
:postal_code
]
def member_fields, do: @member_fields
rafael commented 2025-12-02 11:54:25 +01:00
Collaborator
Copy link

very nice 👌

very nice 👌
rafael force-pushed feature/214_hide_memberfields from d039e4bb7d to 827b2acd6a 2025-12-02 12:20:45 +01:00 Compare
rafael added 1 commit 2025-12-02 12:24:52 +01:00
Refactor field visibility logic
All checks were successful
continuous-integration/drone/push Build is passing
Details
2dbca05484
rafael force-pushed feature/214_hide_memberfields from 2dbca05484 to d3a346824e 2025-12-02 12:29:11 +01:00 Compare
rafael force-pushed feature/214_hide_memberfields from d3a346824e to f25f0216ec 2025-12-02 12:54:22 +01:00 Compare
rafael force-pushed feature/214_hide_memberfields from f25f0216ec to 13f77b5c0a 2025-12-02 14:18:35 +01:00 Compare
rafael merged commit 40835f7a2d into main 2025-12-02 14:33:10 +01:00
rafael deleted branch feature/214_hide_memberfields 2025-12-02 14:33:16 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
rafael
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
high priority

   
invalid

Something is wrong

  
L

5 h

  
low priority

   
M

3 h

  
medium priority

   
needs refinement

   
question

More information is needed

  
S

1 h

  
UX research

   
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
question
S
UX research
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Sprint 9: 20.11 - 11.12
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: local-it/mitgliederverwaltung#232
No description provided.
Delete branch "feature/214_hide_memberfields"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?