local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 51 Pull requests 13 Projects 1 Releases Packages 1 Activity Actions

Check translations when linting #236

Merged
moritz merged 2 commits from lint-translations into main 2025-12-02 16:51:47 +01:00
Conversation 1 Commits 2 Files changed 5 +143 -146
rafael commented 2025-12-02 11:42:10 +01:00
Collaborator
Copy link

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

In CI and when running just lint, check that translations are up to date.

What has been changed?

  • Added a line to the just lint task
  • Added a line to the CI job

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues

Additional Notes

## Description of the implemented changes The changes were: - [ ] Bugfixing - [ ] New Feature - [ ] Breaking Change - [ ] Refactoring In CI and when running `just lint`, check that translations are up to date. ## What has been changed? - Added a line to the `just lint` task - Added a line to the CI job ## Definition of Done ### Code Quality - [x] No new technical depths - [ ] Linting passed - [ ] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [ ] Tests for new code are written - [ ] All tests pass - [ ] axe-core dev tools show no critical or major issues ## Additional Notes <!--- Add any additional information for the reviewers here -->
rafael added 1 commit 2025-12-02 11:42:12 +01:00
Check translations when linting
All checks were successful
continuous-integration/drone/push Build is passing
Details
05770779a6
requested review from moritz 2025-12-02 11:43:05 +01:00
rafael self-assigned this 2025-12-02 11:43:08 +01:00
requested review from simon 2025-12-02 11:43:09 +01:00
rafael removed their assignment 2025-12-02 11:43:11 +01:00
rafael self-assigned this 2025-12-02 11:43:16 +01:00
rafael added this to the Sprint 9: 20.11 - 11.12 project 2025-12-02 16:16:12 +01:00
moritz approved these changes 2025-12-02 16:17:21 +01:00
moritz force-pushed lint-translations from 05770779a6 to 780f5f61ea 2025-12-02 16:17:57 +01:00 Compare
moritz added 1 commit 2025-12-02 16:46:14 +01:00
chore: update gettext
All checks were successful
continuous-integration/drone/push Build is passing
Details
b0c94234a9
moritz merged commit a143c4e243 into main 2025-12-02 16:51:47 +01:00
moritz deleted branch lint-translations 2025-12-02 16:51:47 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
simon
moritz
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
high priority

   
invalid

Something is wrong

  
L

5 h

  
low priority

   
M

3 h

  
medium priority

   
needs refinement

   
question

More information is needed

  
S

1 h

  
UX research

   
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
question
S
UX research
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Sprint 9: 20.11 - 11.12
Assignees
Clear assignees
No assignees
rafael
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: local-it/mitgliederverwaltung#236
No description provided.
Delete branch "lint-translations"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?