Visual hierarchy for fields in member view and edit form - closes #231 #247
No reviewers
Labels
No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
question
S
UX research
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: local-it/mitgliederverwaltung#247
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feature/231_member_view_ui"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Description of the implemented changes
The changes were:
Definition of Done
Code Quality
Accessibility
Testing
Additional Notes
710cd3538ftod24096ceaf@ -109,2 +241,2 @@action = if is_nil(member), do: "New", else: "Edit"page_title = action <> " " <> "Member"action = if is_nil(member), do: gettext("New"), else: gettext("Edit")page_title = "#{action} #{gettext("Member")}"This won't work in german, I think
@ -217,0 +372,4 @@# -----------------------------------------------------------------# Returns input type for custom field based on value typedefp custom_field_input_type(:string), do: "text"These functions should use gettext
the return values are HTML input types. So a translation doesn't make any sense here.
@ -117,0 +240,4 @@# Helper Functions# -----------------------------------------------------------------defp display_value(nil), do: "—"For nil, this should be an empty string (this is how we do it in other parts of the UI)
@ -117,0 +244,4 @@defp display_value(""), do: "—"defp display_value(value), do: valuedefp format_email_mailto(first_name, last_name, email) docan we move this somewhere else so we can reuse it in the member overview?
@ -82,0 +50,4 @@</.button></div><%!-- Tab Navigation --%>I think these tabs are confusing at the moment.
d24096ceafto2542bcf9e4