Small UX fixes closes #281

carla commented

2025-12-15 08:54:49 +01:00

Owner

Description of the implemented changes

The changes were:

Bugfixing
New Feature
Breaking Change
Refactoring

What has been changed?

payment translation changed
new member field translation fixes for german
copy mail adresses buttons not hiding but disabled
update club name on save implemented

Definition of Done

Code Quality

No new technical depths
Linting passed
Documentation is added were needed

Accessibility

New elements are properly defined with html-tags
Colour contrast follows WCAG criteria
Aria labels are added when needed
Everything is accessible by keyboard
Tab-Order is comprehensible
All interactive elements have a visible focus

Testing

Tests for new code are written
All tests pass
axe-core dev tools show no critical or major issues

Additional Notes

## Description of the implemented changes The changes were: - [X] Bugfixing - [X] New Feature - [ ] Breaking Change - [ ] Refactoring ## What has been changed? - payment translation changed - new member field translation fixes for german - copy mail adresses buttons not hiding but disabled - update club name on save implemented ## Definition of Done ### Code Quality - [x] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [ ] Tests for new code are written - [x] All tests pass - [x] axe-core dev tools show no critical or major issues ## Additional Notes

carla added 4 commits 2025-12-15 08:54:51 +01:00

chore: remove immutable from custom fields 6c38d7455f

feat: disable email buttons instead hide them b0daf8f28c

chore: change payment filter text 7d1a4fa166

fix: update clubname on save

continuous-integration/drone/push Build is passing

Details

2fa8f3eb2c

carla changed title from ~~#281Small UX fixes closes~~ to Small UX fixes closes #281

2025-12-15 09:06:31 +01:00

moritz force-pushed feature/281_uxfixes from 2fa8f3eb2c to dd4048669c

2025-12-16 14:35:03 +01:00

Compare

moritz added 6 commits 2025-12-16 14:58:03 +01:00

fix: make disabled links more robust in CoreComponents.button 222af635ae

Remove navigation attributes (href, navigate, patch) when disabled=true
to prevent 'Open in new tab' and 'Copy link' from working on disabled links.
This makes the disabled state semantically stronger and independent of CSS themes.

perf: optimize member index selection calculations fb91f748c2

Calculate selected_count, any_selected? and mailto_bcc once in assigns
instead of recalculating Enum.any? and Enum.count multiple times in template.
This improves render performance and makes the template code more readable.

fix: improve mailto BCC encoding be6ea56860

Use URI.encode_www_form() instead of URI.encode() for mailto query parameters.
This is the safer choice for query parameter encoding.

Add comment about mailto URL length limits that vary by email client.

test: add tests for disabled button states in member index 9f9d888657

Add tests to verify that copy and open-email buttons are disabled
when no members are selected and enabled after selection.
Also verify that the counter shows the correct count.

fix: standardize 'Custom Field' capitalization in i18n 62d04add8e

Change 'Save Custom field' to 'Save Custom Field' and
'Save Custom field value' to 'Save Custom Field Value' for consistency.
Update gettext files accordingly.

test: use data-testids instead of regex in a11y tests

continuous-integration/drone/push Build is passing

Details

1df1b4b238

Replace regex-based aria-label assertions with data-testid-based
has_element? checks for more stable tests that are resistant to
translation changes.

requested review from moritz

2025-12-16 14:59:21 +01:00

moritz merged commit 0a07f4f212 into main

2025-12-16 15:06:01 +01:00

moritz deleted branch feature/281_uxfixes

2025-12-16 15:06:02 +01:00

moritz referenced this pull request from a commit

2025-12-16 15:06:03 +01:00

Merge pull request 'Small UX fixes closes #281' (#293) from feature/281_uxfixes into main

Rows
Columns

Small UX fixes closes #281 #293