local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 60 Pull requests 4 Projects 2 Releases Packages 1 Activity Actions

Vereinfacht accounting software API closes #431 #432

Merged
moritz merged 31 commits from feature/vereinfacht_api into main 2026-02-23 21:18:46 +01:00
Conversation 0 Commits 31 Files changed 32 +3157 -16
moritz commented 2026-02-18 22:35:31 +01:00
Owner
Copy link

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

What has been changed?

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues

Additional Notes

## Description of the implemented changes The changes were: - [ ] Bugfixing - [x] New Feature - [ ] Breaking Change - [ ] Refactoring <!--- Describe the goal of the PR in a few words --> ## What has been changed? <!--- List the things you changed --> ## Definition of Done ### Code Quality - [x] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [x] axe-core dev tools show no critical or major issues ## Additional Notes <!--- Add any additional information for the reviewers here -->
moritz added this to the Import transactions via vereinfacht API milestone 2026-02-18 22:35:31 +01:00
moritz self-assigned this 2026-02-18 22:35:31 +01:00
moritz added 7 commits 2026-02-18 22:35:33 +01:00 
- Migrations: vereinfacht_contact_id on members, vereinfacht_* on settings
- Mv.Config: Vereinfacht ENV/Settings helpers, vereinfacht_configured?, contact_view_url
- Setting: vereinfacht_api_url, api_key, club_id
- Application: create SyncFlash ETS table on start
- Vereinfacht: Client, SyncFlash, sync_member, format_error, sync_members_without_contact
- SyncContact change on Member create_member and update_member
- Member: attribute vereinfacht_contact_id, internal action set_vereinfacht_contact_id
- SyncLinkedMemberAfterUserChange on update, create_user, update_user,
  admin_set_password, link_oidc_id, register_with_rauthy
- GlobalSettingsLive: Vereinfacht section, sync button, last sync result
- Test: Vereinfacht Integration section visible
- Form: show Vereinfacht sync warning after save via SyncFlash
- Show: load API debug response; MembershipFees: contact ID, link, no-contact warning
- POT/PO: Vereinfacht UI and API error message strings
test(vereinfacht): add tests and scope README
Some checks failed
continuous-integration/drone/push Build is failing
Details
f168d3f093 
- Config, Client, SyncContact, Vereinfacht module tests (no real API)
- vereinfacht_test_README: document test scope
moritz added 1 commit 2026-02-18 22:49:39 +01:00
fix(a11y): WCAG 2 AA contrast and keyboard access
Some checks failed
continuous-integration/drone/push Build is failing
Details
4a8926a3fa
moritz force-pushed feature/vereinfacht_api from 4a8926a3fa to 81f62a7c85 2026-02-18 22:52:40 +01:00 Compare
moritz added 9 commits 2026-02-19 00:55:02 +01:00 
Run SyncLinkedMemberAfterUserChange only when email or member
relationship changed to avoid unnecessary API calls.
VEREINFACHT_API_URL, VEREINFACHT_API_KEY, VEREINFACHT_CLUB_ID
with short comment that they override Settings when set.
vereinfacht_api_url_env_set?, vereinfacht_api_key_env_set?,
vereinfacht_club_id_env_set? for read-only Settings fields when set.
Never put API key in form/DOM; show (set) badge, drop blank on save.
Per-field disabled when ENV set; save button only when not all from ENV.
(set), Leave blank to keep current, env hint; DE msgstr added.
API does not allow filter[email]; fetch list and match client-side.
Disable Req retries in test for fast failure and less log noise.
Before saving contact_id to member, sync current data to the
existing contact so Vereinfacht stays up to date.
Gettext: translate Vereinfacht API validation messages to German
Some checks failed
continuous-integration/drone/push Build is failing
Details
17ef898274
moritz force-pushed feature/vereinfacht_api from 17ef898274 to fd6301efab 2026-02-23 19:55:30 +01:00 Compare
moritz changed title from WIP: Vereinfacht accounting software API closes #431 to Vereinfacht accounting software API closes #431 2026-02-23 19:56:01 +01:00
moritz force-pushed feature/vereinfacht_api from fd6301efab to 0f20e459e9 2026-02-23 20:50:02 +01:00 Compare
moritz merged commit a1684f485c into main 2026-02-23 21:18:46 +01:00
moritz deleted branch feature/vereinfacht_api 2026-02-23 21:18:47 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
high priority

   
invalid

Something is wrong

  
L

5 h

  
low priority

   
M

3 h

  
medium priority

   
needs refinement

   
optional

   
question

More information is needed

  
S

1 h

  
UX research

   
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
optional
question
S
UX research
wontfix
Milestone
Clear milestone
No items
No milestone
Import transactions via vereinfacht API
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
moritz
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: local-it/mitgliederverwaltung#432
No description provided.
Delete branch "feature/vereinfacht_api"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?