Remove the `join_date` future-date validation closes #482

moritz commented

2026-05-13 00:20:41 +02:00

Owner

Description of the implemented changes

The changes were:

Bugfixing
New Feature
Breaking Change
Refactoring

The restriction preventing a member's join date from being set in the future has been removed. This unblocked legitimate use cases such as pre-registering members ahead of their actual join date.

What has been changed?

Removed the join_date future-date validation from lib/membership/member.ex
Updated test/membership/member_test.exs: inverted the existing test (future date is now valid) and added four new tests covering today's date, a far-future date (2099), an update to a future join date, and rejection of an exit date that precedes a future join date
Removed stale references to the no-longer-existing restriction from docs/database-schema-readme.md and docs/database_schema.dbml
Updated the inline moduledoc comment in lib/membership/member.ex

Definition of Done

Code Quality

No new technical depths
Linting passed
Documentation is added were needed

Accessibility

New elements are properly defined with html-tags
Colour contrast follows WCAG criteria
Aria labels are added when needed
Everything is accessible by keyboard
Tab-Order is comprehensible
All interactive elements have a visible focus

Testing

Tests for new code are written
All tests pass
axe-core dev tools show no critical or major issues

Additional Notes

Server-side only change — no UI adjustments required. The accessibility checklist items are not applicable.

## Description of the implemented changes The changes were: - [x] Bugfixing - [ ] New Feature - [ ] Breaking Change - [ ] Refactoring The restriction preventing a member's join date from being set in the future has been removed. This unblocked legitimate use cases such as pre-registering members ahead of their actual join date. ## What has been changed? - Removed the `join_date` future-date validation from `lib/membership/member.ex` - Updated `test/membership/member_test.exs`: inverted the existing test (future date is now valid) and added four new tests covering today's date, a far-future date (2099), an update to a future join date, and rejection of an exit date that precedes a future join date - Removed stale references to the no-longer-existing restriction from `docs/database-schema-readme.md` and `docs/database_schema.dbml` - Updated the inline moduledoc comment in `lib/membership/member.ex` ## Definition of Done ### Code Quality - [x] No new technical depths - [x] Linting passed - [ ] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [ ] All tests pass - [ ] axe-core dev tools show no critical or major issues ## Additional Notes Server-side only change — no UI adjustments required. The accessibility checklist items are not applicable.

moritz added 2 commits 2026-05-13 00:20:41 +02:00