Credo ratchet: promote structural checks into the gate #541

New issue

Open

opened 2026-06-15 23:07:26 +02:00 by moritz · 0 comments

moritz commented

2026-06-15 23:07:26 +02:00

Owner

Motivation

The structural Credo checks that surfaced the refactoring backlog are still disabled in the gate .credo.exs. Once the
refactoring issues have reduced the violations, these checks should be promoted into the gate so the codebase
cannot regress. Two checks are already promoted by earlier issues (Readability.StrictModuleLayout in
"Mechanical cleanup …", Warning.UnsafeToAtom in "Correctness …"); this issue handles the remaining three.

It must run last, after the god-module splits, so the violation counts are at their minimum.

Scope

Re-measure current violation counts with the harvest config:
mix credo --strict --config-file .pipeline/refactoring/baseline/credo.harvest.exs
Promote each of the following into the gate .credo.exs at the tightest threshold the post-refactor code
already passes (a ratchet floor, not necessarily the Credo default), then fix any small remaining residue to
hit that floor:
- Design.DuplicatedCode
- Refactor.ModuleDependencies (set max_deps to the current max, e.g. 20, not the default 10 — many modules
  beyond the splits will still exceed 10)
- Refactor.ABCSize
Document, as a comment in .credo.exs, the intended downward tightening over time (e.g. max_deps 20 → 15
→ 10) so future work keeps ratcheting.
Optionally evaluate the lower-priority opt-ins noted in CREDO_RECOMMENDATION.md (e.g.
Refactor.VariableRebinding, Readability.Specs) — include only if low-noise.

Acceptance criteria

The three checks are enabled in the gate .credo.exs at a threshold the code passes; mix credo --strict
(the gate) is green.
The thresholds and the planned tightening are documented inline.
just ci-dev green.

Dependencies

Run after all god-module split issues (member_live/index, Member resource, Mv.Config + join workflow,
core_components, global_settings + fees_component) so the deps/ABC/duplication counts are at their minimum.

## Motivation The structural Credo checks that surfaced the refactoring backlog are still disabled in the gate `.credo.exs`. Once the refactoring issues have reduced the violations, these checks should be promoted into the gate so the codebase cannot regress. Two checks are already promoted by earlier issues (`Readability.StrictModuleLayout` in "Mechanical cleanup …", `Warning.UnsafeToAtom` in "Correctness …"); this issue handles the remaining three. It must run **last**, after the god-module splits, so the violation counts are at their minimum. ## Scope - Re-measure current violation counts with the harvest config: `mix credo --strict --config-file .pipeline/refactoring/baseline/credo.harvest.exs` - Promote each of the following into the gate `.credo.exs` at the **tightest threshold the post-refactor code already passes** (a ratchet floor, not necessarily the Credo default), then fix any small remaining residue to hit that floor: - `Design.DuplicatedCode` - `Refactor.ModuleDependencies` (set `max_deps` to the current max, e.g. 20, not the default 10 — many modules beyond the splits will still exceed 10) - `Refactor.ABCSize` - Document, as a comment in `.credo.exs`, the intended **downward** tightening over time (e.g. `max_deps` 20 → 15 → 10) so future work keeps ratcheting. - Optionally evaluate the lower-priority opt-ins noted in `CREDO_RECOMMENDATION.md` (e.g. `Refactor.VariableRebinding`, `Readability.Specs`) — include only if low-noise. ## Acceptance criteria - The three checks are enabled in the gate `.credo.exs` at a threshold the code passes; `mix credo --strict` (the gate) is green. - The thresholds and the planned tightening are documented inline. - `just ci-dev` green. ## Dependencies Run **after** all god-module split issues (member_live/index, Member resource, Mv.Config + join workflow, core_components, global_settings + fees_component) so the deps/ABC/duplication counts are at their minimum.