Let reviewers edit a join request before approving it #650

Open
opened 2026-11-09 17:20:49 +01:00 by simon · 0 comments
Owner

Motivation

A reviewer sometimes needs to correct or complete what an applicant submitted before the request becomes a member: a typo in the name, a missing value for a custom field that became required after the request was submitted, a wrong postal code the applicant confirmed by phone. Today the only options are to approve and fix the member afterwards, or to reject and ask the applicant to apply again.

#645 fixed approval for required custom fields and added a narrow version of this: when a required value is missing, the reviewer fills in just the missing values before approving. This issue generalizes it.

Current state (after #645)

  • The join request detail page (MvWeb.JoinRequestLive.Show) shows the applicant data read-only.
  • Missing required values are filled in through the step #645 introduced (see that PR); other fields cannot be changed.
  • Approval casts form_data per custom field type and creates the member in one transaction (Mv.Membership.JoinFlow.approve_join_request/2).

Proposal

  • An "Edit" action on a submitted join request that opens the applicant data as a form (same fields and order as the join form, same validation as the public form, required fields enforced).
  • Saving updates the request; the history keeps who changed what (reviewer and time), since the applicant's original submission is evidence of their consent.
  • The narrow "fill in missing required values" step of #645 becomes part of this form and is removed as a separate step.

Open questions

  • Should the applicant be notified when a reviewer changed their data?
  • Which fields may a reviewer change at all (e.g. consent checkboxes must not be ticked on the applicant's behalf)?
  • Is an edited original value kept for audit, and where is it shown?

Acceptance criteria

  • A reviewer with approval rights can edit a submitted join request's data; others cannot (forged events refused).
  • Consent fields cannot be set to "yes" by a reviewer.
  • Edits are validated like the public form and recorded with reviewer and time.
  • The separate fill-in step from #645 is gone; its tests move to the edit form.
## Motivation A reviewer sometimes needs to correct or complete what an applicant submitted before the request becomes a member: a typo in the name, a missing value for a custom field that became required after the request was submitted, a wrong postal code the applicant confirmed by phone. Today the only options are to approve and fix the member afterwards, or to reject and ask the applicant to apply again. #645 fixed approval for required custom fields and added a narrow version of this: when a required value is missing, the reviewer fills in just the missing values before approving. This issue generalizes it. ## Current state (after #645) - The join request detail page (`MvWeb.JoinRequestLive.Show`) shows the applicant data read-only. - Missing required values are filled in through the step #645 introduced (see that PR); other fields cannot be changed. - Approval casts `form_data` per custom field type and creates the member in one transaction (`Mv.Membership.JoinFlow.approve_join_request/2`). ## Proposal - An "Edit" action on a submitted join request that opens the applicant data as a form (same fields and order as the join form, same validation as the public form, required fields enforced). - Saving updates the request; the history keeps who changed what (reviewer and time), since the applicant's original submission is evidence of their consent. - The narrow "fill in missing required values" step of #645 becomes part of this form and is removed as a separate step. ## Open questions - Should the applicant be notified when a reviewer changed their data? - Which fields may a reviewer change at all (e.g. consent checkboxes must not be ticked on the applicant's behalf)? - Is an edited original value kept for audit, and where is it shown? ## Acceptance criteria - A reviewer with approval rights can edit a submitted join request's data; others cannot (forged events refused). - Consent fields cannot be set to "yes" by a reviewer. - Edits are validated like the public form and recorded with reviewer and time. - The separate fill-in step from #645 is gone; its tests move to the edit form.
Sign in to join this conversation.
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
local-it/mitgliederverwaltung#650
No description provided.