local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 72 Pull requests 5 Projects 4 Releases Packages 1 Activity Actions

customize login screen and mmbers as landing page closes #68 and #137 #138

Merged
carla merged 5 commits from feature/68_log_in_screen into main 2025-08-21 13:49:43 +02:00
Conversation 8 Commits 5 Files changed 13 +2 -1
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 7e2aa49674 - Show all commits

3
lib/mv_web/live_user_auth.ex
View file

@ -37,7 +37,8 @@ defmodule MvWeb.LiveUserAuth do
end end
def on_mount(:live_no_user, _params, session, socket) do def on_mount(:live_no_user, _params, session, socket) do
# Set the locale for not logged in user to set the language # Set the locale for not logged in user to set the language in the Log-In Screen
rafael marked this conversation as resolved Outdated
rafael commented 2025-08-14 10:55:46 +02:00
Outdated
Copy link

Is there a way to detect the language of the user automatically? Maybe phoenix has a feature for that. This would make sure that folks who don't speak german will get the english login page. I think it makes sense to display the login page in german as a fallback, if the browser doesn't send a preferred language. Maybe we can open an issue for that? :)

Is there a way to detect the language of the user automatically? Maybe phoenix has a feature for that. This would make sure that folks who don't speak german will get the english login page. I think it makes sense to display the login page in german as a fallback, if the browser doesn't send a preferred language. Maybe we can open an issue for that? :)
👍 1
carla commented 2025-08-14 14:44:21 +02:00
Outdated
Copy link

I think adding a language switch to the login screen needs more customization than the overrides AshAuthentication provides. As I think it's not that high priority right now I added another issue, but to not spend time on it right now. Is that fine?

I think adding a language switch to the login screen needs more customization than the overrides AshAuthentication provides. As I think it's not that high priority right now I added another issue, but to not spend time on it right now. Is that fine?
rafael commented 2025-08-15 09:46:03 +02:00
Outdated
Copy link

Yes, totally fine!

Yes, totally fine!
# otherwise the locale is not taken for the Log-In Screen
locale = session["locale"] || "en" locale = session["locale"] || "en"
rafael marked this conversation as resolved Outdated
rafael commented 2025-08-15 10:04:28 +02:00
Outdated
Copy link

Do we also need to set the locale here when the router already does it?

Do we also need to set the locale here when the router already does it?
carla commented 2025-08-19 10:24:39 +02:00
Outdated
Copy link

Yes, otherwise the login scren is not translated. At least I found no other way.

Yes, otherwise the login scren is not translated. At least I found no other way.
rafael commented 2025-08-21 12:37:11 +02:00
Outdated
Copy link

Okay, could you add a comment saying that this is the reason? This will make it easier to understand if somebody stumbles upon this in the future :)

Okay, could you add a comment saying that this is the reason? This will make it easier to understand if somebody stumbles upon this in the future :)
👍 1
Gettext.put_locale(MvWeb.Gettext, locale) Gettext.put_locale(MvWeb.Gettext, locale)
{:cont, assign(socket, :locale, locale)} {:cont, assign(socket, :locale, locale)}