local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 68 Pull requests 8 Projects 1 Releases Packages 1 Activity Actions

Membership Fee 6 - UI Components & LiveViews closes #280 #304

Open
moritz wants to merge 65 commits from feature/280_membership_fee_ui into main
pull from: feature/280_membership_fee_ui
merge into: local-it:main
Conversation 1 Commits 65 Files changed 42 +22 -3
1 changed files with 22 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 46af6bbbed - Show all commits

25
lib/mv_web/live/membership_fee_type_live/form.ex
View file

@ -49,14 +49,24 @@ defmodule MvWeb.MembershipFeeTypeLive.Form do
moritz marked this conversation as resolved
carla commented 2025-12-22 13:04:04 +01:00
Copy link

Interval is neccessary to create a fee type, but it is not marked as required. So when I leave it out there is no error message but my fee type is not created.

Interval is neccessary to create a fee type, but it is not marked as required. So when I leave it out there is no error message but my fee type is not created.
<div class="form-control"> <div class="form-control">
<label class="label"> <label class="label">
<span class="label-text font-semibold">{gettext("Interval")}</span> <span class="label-text font-semibold">
{gettext("Interval")}
<span
:if={is_nil(@membership_fee_type)}
class="text-red-700 tooltip tooltip-right"
data-tip={gettext("This field cannot be empty")}
>*</span>
moritz marked this conversation as resolved Outdated
carla commented 2025-12-22 12:33:05 +01:00
Outdated
Copy link

The form has alreday phx-change validate, I think it is redundant here

The form has alreday phx-change validate, I think it is redundant here
</span>
</label> </label>
<select <select
class="select select-bordered w-full" class={[
"select select-bordered w-full",
@form.errors[:interval] && "select-error"
]}
disabled={!is_nil(@membership_fee_type)} disabled={!is_nil(@membership_fee_type)}
name="membership_fee_type[interval]" name="membership_fee_type[interval]"
id="membership-fee-type-form_interval" id="membership-fee-type-form_interval"
phx-change="validate" required={is_nil(@membership_fee_type)}
> >
<option value="">{gettext("Select interval")}</option> <option value="">{gettext("Select interval")}</option>
<option <option
@ -86,6 +96,15 @@ defmodule MvWeb.MembershipFeeTypeLive.Form do
{gettext("Yearly")} {gettext("Yearly")}
</option> </option>
</select> </select>
<%= if @form.errors[:interval] do %>
<%= for error <- List.wrap(@form.errors[:interval]) do %>
<% {msg, _opts} = if is_tuple(error), do: error, else: {error, []} %>
<p class="mt-1.5 flex gap-2 items-center text-sm text-error">
<.icon name="hero-exclamation-circle" class="size-5" />
{msg}
</p>
<% end %>
<% end %>
<%= if !is_nil(@membership_fee_type) do %> <%= if !is_nil(@membership_fee_type) do %>
<label class="label"> <label class="label">
<span class="label-text-alt text-base-content/60"> <span class="label-text-alt text-base-content/60">