mitgliederverwaltung/test/mv_web/user_live/form_test.exs

defmodule MvWeb.UserLive.FormTest do
  # async: false to prevent PostgreSQL deadlocks when creating members and users
  use MvWeb.ConnCase, async: false
  import Phoenix.LiveViewTest

  # Helper to setup authenticated connection and live view
  defp setup_live_view(conn, path) do
    conn = conn_with_oidc_user(conn, %{email: "admin@example.com"})
    live(conn, path)
  end

  describe "new user form - display" do
    test "shows correct form elements", %{conn: conn} do
      {:ok, view, html} = setup_live_view(conn, "/users/new")

      assert html =~ "New User"
      assert html =~ "Email"
      assert html =~ "Set Password"
      assert has_element?(view, "form#user-form[phx-submit='save']")
      assert has_element?(view, "input[name='user[email]']")
      assert has_element?(view, "input[type='checkbox'][name='set_password']")
    end
  end

  describe "new user form - creation" do
    test "creates user without password", %{conn: conn} do
      {:ok, view, _html} = setup_live_view(conn, "/users/new")

      view
      |> form("#user-form", user: %{email: "newuser@example.com"})
      |> render_submit()

      assert_redirected(view, "/users")
    end

    test "creates user with password when enabled", %{conn: conn} do
      {:ok, view, _html} = setup_live_view(conn, "/users/new")

      view |> element("input[name='set_password']") |> render_click()

      view
      |> form("#user-form",
        user: %{
          email: "passworduser@example.com",
          password: "securepassword123",
          password_confirmation: "securepassword123"
        }
      )
      |> render_submit()

      assert_redirected(view, "/users")
    end

    test "stores user data correctly", %{conn: conn} do
      {:ok, view, _html} = setup_live_view(conn, "/users/new")

      view
      |> form("#user-form", user: %{email: "storetest@example.com"})
      |> render_submit()

      system_actor = Mv.Helpers.SystemActor.get_system_actor()

      user =
        Ash.get!(
          Mv.Accounts.User,
          [email: Ash.CiString.new("storetest@example.com")],
          domain: Mv.Accounts,
          actor: system_actor
        )

      assert to_string(user.email) == "storetest@example.com"
      assert is_nil(user.hashed_password)
    end
  end

  describe "edit user form - display" do
    test "shows correct form elements for existing user", %{conn: conn} do
      user = create_test_user(%{email: "editme@example.com"})
      {:ok, view, html} = setup_live_view(conn, "/users/#{user.id}/edit")

      assert html =~ "Edit User"
      assert html =~ "Change Password"
      assert has_element?(view, "input[name='user[email]'][value='editme@example.com']")
      assert html =~ "Check 'Change Password' above to set a new password for this user"
    end
  end

  describe "edit user form - updates" do
    test "updates email without changing password", %{conn: conn} do
      user = create_test_user(%{email: "old@example.com"})
      original_password = user.hashed_password
      {:ok, view, _html} = setup_live_view(conn, "/users/#{user.id}/edit")

      view
      |> form("#user-form", user: %{email: "new@example.com"})
      |> render_submit()

      assert_redirected(view, "/users")

      system_actor = Mv.Helpers.SystemActor.get_system_actor()
      updated_user = Ash.reload!(user, domain: Mv.Accounts, actor: system_actor)
      assert to_string(updated_user.email) == "new@example.com"
      assert updated_user.hashed_password == original_password
    end

    test "admin sets new password for user", %{conn: conn} do
      user = create_test_user(%{email: "user@example.com"})
      original_password = user.hashed_password
      {:ok, view, _html} = setup_live_view(conn, "/users/#{user.id}/edit")

      view |> element("input[name='set_password']") |> render_click()

      view
      |> form("#user-form",
        user: %{
          email: "user@example.com",
          password: "newadminpassword123"
        }
      )
      |> render_submit()

      assert_redirected(view, "/users")

      system_actor = Mv.Helpers.SystemActor.get_system_actor()
      updated_user = Ash.reload!(user, domain: Mv.Accounts, actor: system_actor)
      assert updated_user.hashed_password != original_password
      assert not is_nil(updated_user.hashed_password)
      assert updated_user.hashed_password != ""
    end
  end

  describe "member linking - display" do
    test "shows linked member with unlink button when user has member", %{conn: conn} do
      system_actor = Mv.Helpers.SystemActor.get_system_actor()

      # Create member
      {:ok, member} =
        Mv.Membership.create_member(
          %{
            first_name: "John",
            last_name: "Doe",
            email: "john@example.com"
          },
          actor: system_actor
        )

      # Create user linked to member
      user = create_test_user(%{email: "user@example.com"})

      {:ok, _updated_user} =
        Mv.Accounts.update_user(user, %{member: %{id: member.id}}, actor: system_actor)

      # Load form
      {:ok, view, html} = setup_live_view(conn, "/users/#{user.id}/edit")

      # Should show linked member section
      assert html =~ "Linked Member"
      assert html =~ "John Doe"
      assert html =~ "user@example.com"
      assert has_element?(view, "button[phx-click='unlink_member']")
      assert html =~ "Unlink Member"
    end

    test "shows member search field when user has no member", %{conn: conn} do
      user = create_test_user(%{email: "user@example.com"})
      {:ok, view, html} = setup_live_view(conn, "/users/#{user.id}/edit")

      # Should show member search section
      assert html =~ "Linked Member"
      assert has_element?(view, "input[phx-change='search_members']")
      # Should not show unlink button
      refute has_element?(view, "button[phx-click='unlink_member']")
    end
  end

  describe "member linking - workflow" do
    test "selecting member and saving links member to user", %{conn: conn} do
      system_actor = Mv.Helpers.SystemActor.get_system_actor()

      # Create unlinked member
      {:ok, member} =
        Mv.Membership.create_member(
          %{
            first_name: "Jane",
            last_name: "Smith",
            email: "jane@example.com"
          },
          actor: system_actor
        )

      # Create user without member
      user = create_test_user(%{email: "user@example.com"})
      {:ok, view, _html} = setup_live_view(conn, "/users/#{user.id}/edit")

      # Select member
      view |> element("div[data-member-id='#{member.id}']") |> render_click()

      # Submit form
      view
      |> form("#user-form", user: %{email: "user@example.com"})
      |> render_submit()

      assert_redirected(view, "/users")

      # Verify member is linked
      system_actor = Mv.Helpers.SystemActor.get_system_actor()

      updated_user =
        Ash.get!(Mv.Accounts.User, user.id,
          domain: Mv.Accounts,
          actor: system_actor,
          load: [:member]
        )

      assert updated_user.member.id == member.id
    end

    test "unlinking member and saving removes member from user", %{conn: conn} do
      system_actor = Mv.Helpers.SystemActor.get_system_actor()

      # Create member
      {:ok, member} =
        Mv.Membership.create_member(
          %{
            first_name: "Bob",
            last_name: "Wilson",
            email: "bob@example.com"
          },
          actor: system_actor
        )

      # Create user linked to member
      user = create_test_user(%{email: "user@example.com"})
      {:ok, _} = Mv.Accounts.update_user(user, %{member: %{id: member.id}}, actor: system_actor)

      {:ok, view, _html} = setup_live_view(conn, "/users/#{user.id}/edit")

      # Click unlink button
      view |> element("button[phx-click='unlink_member']") |> render_click()

      # Submit form
      view
      |> form("#user-form", user: %{email: "user@example.com"})
      |> render_submit()

      assert_redirected(view, "/users")

      # Verify member is unlinked
      system_actor = Mv.Helpers.SystemActor.get_system_actor()

      updated_user =
        Ash.get!(Mv.Accounts.User, user.id,
          domain: Mv.Accounts,
          actor: system_actor,
          load: [:member]
        )

      assert is_nil(updated_user.member)
    end
  end

  describe "system actor user" do
    test "redirects to user list when editing system actor user", %{conn: conn} do
      system_actor = Mv.Helpers.SystemActor.get_system_actor()
      conn = conn_with_oidc_user(conn, %{email: "admin@example.com"})

      assert {:error, {:live_redirect, %{to: "/users"}}} =
               live(conn, "/users/#{system_actor.id}/edit")
    end
  end
end