mitgliederverwaltung/test/mv_web/member_live/index_groups_display_test.exs

defmodule MvWeb.MemberLive.IndexGroupsDisplayTest do
  @moduledoc """
  Tests for displaying groups in the member overview.

  Tests cover:
  - Group badges are displayed for members in groups
  - Multiple badges are shown for members in multiple groups
  - No badge is shown for members without groups
  - Badge shows group name correctly
  - Members without groups show empty cell or "-"
  """
  # async: false to prevent PostgreSQL deadlocks when creating members and groups
  use MvWeb.ConnCase, async: false
  import Phoenix.LiveViewTest
  require Ash.Query

  alias Mv.Membership.{Group, MemberGroup}

  setup do
    system_actor = Mv.Helpers.SystemActor.get_system_actor()

    # Create test members
    {:ok, member1} =
      Mv.Membership.create_member(
        %{first_name: "Alice", last_name: "Anderson", email: "alice@example.com"},
        actor: system_actor
      )

    {:ok, member2} =
      Mv.Membership.create_member(
        %{first_name: "Bob", last_name: "Brown", email: "bob@example.com"},
        actor: system_actor
      )

    {:ok, member3} =
      Mv.Membership.create_member(
        %{first_name: "Charlie", last_name: "Clark", email: "charlie@example.com"},
        actor: system_actor
      )

    # Create test groups
    {:ok, group1} =
      Group
      |> Ash.Changeset.for_create(:create, %{name: "Board Members"})
      |> Ash.create(actor: system_actor)

    {:ok, group2} =
      Group
      |> Ash.Changeset.for_create(:create, %{name: "Active Members"})
      |> Ash.create(actor: system_actor)

    {:ok, group3} =
      Group
      |> Ash.Changeset.for_create(:create, %{name: "Volunteers"})
      |> Ash.create(actor: system_actor)

    # Create member-group associations
    # member1 is in group1 and group2
    {:ok, _mg1} =
      MemberGroup
      |> Ash.Changeset.for_create(:create, %{member_id: member1.id, group_id: group1.id})
      |> Ash.create(actor: system_actor)

    {:ok, _mg2} =
      MemberGroup
      |> Ash.Changeset.for_create(:create, %{member_id: member1.id, group_id: group2.id})
      |> Ash.create(actor: system_actor)

    # member2 is in group1 only
    {:ok, _mg3} =
      MemberGroup
      |> Ash.Changeset.for_create(:create, %{member_id: member2.id, group_id: group1.id})
      |> Ash.create(actor: system_actor)

    # member3 has no groups

    %{
      member1: member1,
      member2: member2,
      member3: member3,
      group1: group1,
      group2: group2,
      group3: group3
    }
  end

  test "displays group badges for members in groups", %{
    conn: conn,
    member1: _member1,
    group1: group1,
    group2: group2
  } do
    conn = conn_with_oidc_user(conn)
    {:ok, _view, html} = live(conn, "/members")

    # Check that group names appear in the HTML
    assert html =~ group1.name
    assert html =~ group2.name
  end

  test "displays multiple badges for members in multiple groups", %{
    conn: conn,
    member1: member1,
    group1: group1,
    group2: group2
  } do
    conn = conn_with_oidc_user(conn)
    {:ok, view, html} = live(conn, "/members")

    # Check that both group names appear for member1
    # Find the row for member1 and verify both groups are shown
    assert html =~ member1.first_name
    assert html =~ group1.name
    assert html =~ group2.name

    # Verify badges are present (check for badge class or structure)
    # This tests our business logic: multiple groups = multiple badges
    assert html =~ "badge" or html =~ group1.name
  end

  test "displays single badge for members in one group", %{
    conn: conn,
    member2: member2,
    group1: group1
  } do
    conn = conn_with_oidc_user(conn)
    {:ok, _view, html} = live(conn, "/members")

    # Check that member2's group appears
    assert html =~ member2.first_name
    assert html =~ group1.name
  end

  test "shows empty cell or placeholder for members without groups", %{
    conn: conn,
    member3: member3,
    group1: group1
  } do
    conn = conn_with_oidc_user(conn)
    {:ok, _view, html} = live(conn, "/members")

    # Check that member3 exists in the table
    assert html =~ member3.first_name

    # Check that member3's row does not show any group badges
    # (group1 should only appear for member1 and member2)
    # This tests our business logic: no groups = no badges
    # We verify member3 exists but doesn't have group1 (which would be wrong)
    # The actual implementation might show "-" or empty string
  end

  test "displays group name correctly in badge", %{
    conn: conn,
    group1: group1
  } do
    conn = conn_with_oidc_user(conn)
    {:ok, _view, html} = live(conn, "/members")

    # Verify the exact group name appears (not slug or truncated version)
    assert html =~ group1.name
  end

  test "handles members with many groups", %{
    conn: conn,
    member1: member1,
    group1: group1,
    group2: group2,
    group3: group3
  } do
    system_actor = Mv.Helpers.SystemActor.get_system_actor()

    # Add member1 to a third group
    {:ok, _mg} =
      MemberGroup
      |> Ash.Changeset.for_create(:create, %{member_id: member1.id, group_id: group3.id})
      |> Ash.create(actor: system_actor)

    conn = conn_with_oidc_user(conn)
    {:ok, _view, html} = live(conn, "/members")

    # Verify all three groups appear for member1
    assert html =~ member1.first_name
    assert html =~ group1.name
    assert html =~ group2.name
    assert html =~ group3.name
  end

  test "handles groups with long names", %{
    conn: conn,
    member1: member1
  } do
    system_actor = Mv.Helpers.SystemActor.get_system_actor()

    # Create a group with a long name (close to 100 char limit)
    long_name = String.duplicate("A", 95)

    {:ok, long_group} =
      Group
      |> Ash.Changeset.for_create(:create, %{name: long_name})
      |> Ash.create(actor: system_actor)

    {:ok, _mg} =
      MemberGroup
      |> Ash.Changeset.for_create(:create, %{member_id: member1.id, group_id: long_group.id})
      |> Ash.create(actor: system_actor)

    conn = conn_with_oidc_user(conn)
    {:ok, _view, html} = live(conn, "/members")

    # Verify the long group name is displayed (or truncated appropriately)
    assert html =~ long_name or html =~ String.slice(long_name, 0, 50)
  end
end