local-it/vikunja-frontend
0
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

feat: changed green "Done" button to read "Mark task done" (#1340)

Browse source 
The green button can be confusing because the wording "Done" can be interpreted as "done editing the task" or "the task should be marked as done". Changing the text in the button makes the description more precise.

Co-authored-by: David Morlitz <david@morlitz.com>
Reviewed-on: https://kolaente.dev/vikunja/frontend/pulls/1340
Reviewed-by: konrad <k@knt.li>
Co-authored-by: dmorlitz <david@morlitz.com>
Co-committed-by: dmorlitz <david@morlitz.com>
This commit is contained in:
dmorlitz 2022-01-08 21:18:06 +00:00 committed by konrad
parent 0473c385d6
commit 044f2b927d
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cypress/integration/task/task.spec.js
View file

@ -128,7 +128,7 @@ describe('Task', () => {
cy.visit(`/tasks/${tasks[0].id}`) cy.visit(`/tasks/${tasks[0].id}`)
cy.get('.task-view .action-buttons .button') cy.get('.task-view .action-buttons .button')
.contains('Done!') .contains('Mark task done!')
.click() .click()
cy.get('.task-view .heading .is-done') cy.get('.task-view .heading .is-done')

4
src/i18n/lang/en.json
View file

@ -545,7 +545,7 @@
"chooseStartDate": "Click here to set a start date", "chooseStartDate": "Click here to set a start date",
"chooseEndDate": "Click here to set an end date", "chooseEndDate": "Click here to set an end date",
"move": "Move task to a different list", "move": "Move task to a different list",
"done": "Done!", "done": "Mark task done!",
"undone": "Mark as undone", "undone": "Mark as undone",
"created": "Created {0} by {1}", "created": "Created {0} by {1}",
"updated": "Updated {0}", "updated": "Updated {0}",
@ -781,7 +781,7 @@
"then": "then", "then": "then",
"task": { "task": {
"title": "Task Page", "title": "Task Page",
"done": "Mark a task as done", "done": "Done",
"assign": "Assign to a user", "assign": "Assign to a user",
"labels": "Add labels to this task", "labels": "Add labels to this task",
"dueDate": "Change the due date of this task", "dueDate": "Change the due date of this task",