local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 52 Pull requests 2 Projects 1 Releases 4 Packages 1 Activity Actions

fix: wrap field labels in join request view
Some checks failed
continuous-integration/drone/push Build is failing
Details

Browse source
This commit is contained in:
Simon 2026-05-06 11:52:48 +02:00
parent 6327ea00eb
commit 15e9a52bc9
Signed by: simon
GPG key ID: 40E7A58C4AA1EDB2
2 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

10
lib/mv_web/live/join_request_live/show.ex
View file

@ -222,9 +222,9 @@ defmodule MvWeb.JoinRequestLive.Show do
defp field_row(assigns) do defp field_row(assigns) do
~H""" ~H"""
<div class="flex gap-2"> <dl class="grid gap-1 md:grid-cols-[14rem_minmax(0,1fr)] md:gap-2">
<span class="text-base-content/60 min-w-32 shrink-0">{@label}:</span> <dt class="m-0 text-base-content/60 whitespace-normal break-words">{@label}:</dt>
<span> <dd class="m-0 min-w-0">
<%= if @value && @value != "" do %> <%= if @value && @value != "" do %>
{@value} {@value}
<% else %> <% else %>
@ -232,8 +232,8 @@ defmodule MvWeb.JoinRequestLive.Show do
{@empty_text || gettext("Not specified")} {@empty_text || gettext("Not specified")}
</span> </span>
<% end %> <% end %>
</span> </dd>
</div> </dl>
""" """
end end

6
test/mv_web/live/join_request_live/show_test.exs
View file

@ -63,9 +63,9 @@ defmodule MvWeb.JoinRequestLive.ShowTest do
{:ok, view, _html} = live(conn, "/join_requests/#{join_request.id}") {:ok, view, _html} = live(conn, "/join_requests/#{join_request.id}")
assert has_element?(view, "span", "#{custom_field.name}:") assert has_element?(view, "dt", "#{custom_field.name}:")
assert has_element?(view, "span", "Alice Example") assert has_element?(view, "dd", "Alice Example")
refute has_element?(view, "span", "#{custom_field.id}:") refute has_element?(view, "dt", "#{custom_field.id}:")
end end
end end
end end