local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 68 Pull requests 8 Projects 1 Releases Packages 1 Activity Actions

feat: coherent required boolean handling
Some checks failed
continuous-integration/drone/push Build is failing
Details

Browse source
This commit is contained in:
carla 2025-12-23 18:08:31 +01:00
parent ca702cf2c1
commit 1dd68bcaf2
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
lib/membership/member.ex
View file

@ -782,7 +782,8 @@ defmodule Mv.Membership.Member do
missing_names = Enum.map_join(sorted_missing_fields, ", ", & &1.name) missing_names = Enum.map_join(sorted_missing_fields, ", ", & &1.name)
{:error, {:error,
field: :custom_field_values, message: "Required custom fields missing: #{missing_names}"} field: :custom_field_values,
message: Gettext.dgettext(MvWeb.Gettext, "default", "Required custom fields missing: %{fields}", fields: missing_names)}
end end
# Helper function to check if a value is present for a given custom field type # Helper function to check if a value is present for a given custom field type

3
lib/mv_web/live/member_live/form.ex
View file

@ -144,8 +144,7 @@ defmodule MvWeb.MemberLive.Form do
field={value_form[:value]} field={value_form[:value]}
label={cf.name} label={cf.name}
type={custom_field_input_type(cf.value_type)} type={custom_field_input_type(cf.value_type)}
required={if cf.value_type == :boolean, do: false, else: cf.required} required={cf.required}
aria-required={if cf.required, do: "true", else: nil}
/> />
</.inputs_for> </.inputs_for>
<input <input