fix: fix tests and remove navbar remainings

lib/mv_web/components/layouts/navbar.ex

@@ -1,98 +0,0 @@
-defmodule MvWeb.Layouts.Navbar do
-  @moduledoc """
-  Navbar that is used in the rootlayout shown on every page
-  """
-  use MvWeb, :html
-  import MvWeb.Authorization
-
-  attr :current_user, :map,
-    required: true,
-    doc: "The current user - navbar is only shown when user is present"
-
-  attr :club_name, :string,
-    default: nil,
-    doc: "Optional club name - if not provided, will be loaded from database"
-
-  def navbar(assigns) do
-    club_name = assigns[:club_name] || get_club_name()
-    assigns = assign(assigns, :club_name, club_name)
-
-    ~H"""
-    <header class="shadow-sm navbar bg-base-100">
-      <div class="flex-1">
-        <a href="/members" class="btn btn-ghost text-xl">{@club_name}</a>
-        <ul class="menu menu-horizontal bg-base-200">
-          <li><.link navigate="/members">{gettext("Members")}</.link></li>
-          <li>
-            <details>
-              <summary>{gettext("Settings")}</summary>
-              <ul class="bg-base-200 rounded-t-none p-2 z-10 w-48">
-                <li>
-                  <.link navigate="/settings">{gettext("Global Settings")}</.link>
-                </li>
-                <%= if can_access_page?(@current_user, ~p"/admin/roles") do %>
-                  <li>
-                    <.link navigate={~p"/admin/roles"}>{gettext("Roles")}</.link>
-                  </li>
-                <% end %>
-              </ul>
-            </details>
-          </li>
-          <li><.link navigate="/users">{gettext("Users")}</.link></li>
-          <li>
-            <details>
-              <summary>{gettext("Contributions")}</summary>
-              <ul class="bg-base-200 rounded-t-none p-2 z-10">
-                <li>
-                  <.link navigate="/membership_fee_types">{gettext("Membership Fee Types")}</.link>
-                </li>
-                <li>
-                  <.link navigate="/membership_fee_settings">
-                    {gettext("Membership Fee Settings")}
-                  </.link>
-                </li>
-              </ul>
-            </details>
-          </li>
-        </ul>
-      </div>
-      <div class="flex gap-2">
-        <form method="post" action="/set_locale" class="mr-4">
-          <input type="hidden" name="_csrf_token" value={Plug.CSRFProtection.get_csrf_token()} />
-          <label class="sr-only" for="locale-select">{gettext("Select language")}</label>
-          <select
-            id="locale-select"
-            name="locale"
-            onchange="this.form.submit()"
-            class="select select-sm"
-            aria-label={gettext("Select language")}
-          >
-            <option value="de" selected={Gettext.get_locale() == "de"}>Deutsch</option>
-            <option value="en" selected={Gettext.get_locale() == "en"}>English</option>
-          </select>
-        </form>
-        <!-- Daisy UI Theme Toggle for dark and light mode-->
-        <label class="flex cursor-pointer gap-2" aria-label={gettext("Toggle dark mode")}>
-          <input
-            type="checkbox"
-            value="dark"
-            class="toggle toggle-sm theme-controller"
-            aria-label={gettext("Toggle dark mode")}
-          />
-          <.icon name="hero-sun" class="size-5" aria-hidden="true" />
-          <.icon name="hero-moon" class="size-5" aria-hidden="true" />
-        </label>
-      </div>
-    </header>
-    """
-  end
-
-  # Helper function to get club name from settings
-  # Falls back to "Mitgliederverwaltung" if settings can't be loaded
-  defp get_club_name do
-    case Mv.Membership.get_settings() do
-      {:ok, settings} -> settings.club_name
-      _ -> "Mitgliederverwaltung"
-    end
-  end
-end

lib/mv_web/components/layouts/sidebar.ex

@@ -34,12 +34,12 @@ defmodule MvWeb.Layouts.Sidebar do
     <div class="flex items-center gap-3 p-4 border-b border-base-300">
       <!-- Logo -->
       <img src={~p"/images/mila.svg"} alt="Mila Logo" class="size-8 shrink-0" />
-      
+
     <!-- Club Name -->
       <span class="menu-label text-lg font-bold truncate">
         {@club_name}
       </span>
-      
+
     <!-- Toggle Button (Desktop only) -->
       <%= unless @mobile do %>
         <button
@@ -47,6 +47,7 @@ defmodule MvWeb.Layouts.Sidebar do
           id="sidebar-toggle"
           class="hidden lg:flex ml-auto btn btn-ghost btn-sm btn-square"
           aria-label={gettext("Toggle sidebar")}
+          aria-controls="main-sidebar"
           aria-expanded="true"
           onclick="toggleSidebar()"
         >
@@ -86,18 +87,18 @@ defmodule MvWeb.Layouts.Sidebar do
         icon="hero-rectangle-group"
         label={gettext("Custom Fields")}
       />
-      
+
     <!-- Nested Menu: Contributions -->
       <.menu_group
         icon="hero-currency-dollar"
         label={gettext("Contributions")}
       >
         <.menu_subitem href="/contribution_types" label={gettext("Contribution Types")} />
-        <.menu_subitem href="/contribution_settings" label={gettext("Settings")} />
+        <.menu_subitem href="/membership_fee_settings" label={gettext("Settings")} />
       </.menu_group>
 
       <.menu_item
-        href="#"
+        href={~p"/settings"}
         icon="hero-cog-6-tooth"
         label={gettext("Settings")}
       />
@@ -146,7 +147,7 @@ defmodule MvWeb.Layouts.Sidebar do
           {render_slot(@inner_block)}
         </ul>
       </details>
-      
+
     <!-- Collapsed Mode: Dropdown -->
       <div class="collapsed-menu-group dropdown dropdown-right">
         <button
@@ -207,10 +208,10 @@ defmodule MvWeb.Layouts.Sidebar do
           <option value="en" selected={Gettext.get_locale() == "en"}>English</option>
         </select>
       </form>
-      
+
     <!-- Theme Toggle (immer sichtbar) -->
       <.theme_toggle />
-      
+
     <!-- User Menu (nur wenn current_user existiert) -->
       <%= if @current_user do %>
         <.user_menu current_user={@current_user} />