Move require Logger to module level
All checks were successful
continuous-integration/drone/push Build is passing

Move require Logger statements from function/case level to module level
for better code organization and consistency with Elixir best practices
This commit is contained in:
Moritz 2026-01-21 08:35:34 +01:00
parent 1c5bd04661
commit d07f1984cd
3 changed files with 4 additions and 12 deletions

View file

@ -203,8 +203,6 @@ defmodule Mv.Membership.Member do
{:ok, member, notifications}
{:error, reason} ->
require Logger
Logger.warning(
"Failed to regenerate cycles for member #{member.id}: #{inspect(reason)}"
)
@ -962,8 +960,6 @@ defmodule Mv.Membership.Member do
# Runs cycle generation synchronously (for test environment)
defp handle_cycle_generation_sync(member, initiator) do
require Logger
case Mv.MembershipFees.CycleGenerator.generate_cycles_for_member(
member.id,
today: Date.utc_today(),
@ -1015,8 +1011,6 @@ defmodule Mv.Membership.Member do
sync: sync?,
initiator: initiator
) do
require Logger
sync_label = if sync?, do: "", else: " (async)"
initiator_info = get_initiator_info(initiator)
@ -1030,8 +1024,6 @@ defmodule Mv.Membership.Member do
# Logs cycle generation errors
defp log_cycle_generation_error(member, reason, sync: sync?, initiator: initiator) do
require Logger
sync_label = if sync?, do: "", else: " (async)"
initiator_info = get_initiator_info(initiator)