local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 67 Pull requests 6 Projects 3 Releases Packages 1 Activity Actions

Move require Logger to module level
All checks were successful
continuous-integration/drone/push Build is passing
Details

Browse source 
Move require Logger statements from function/case level to module level
for better code organization and consistency with Elixir best practices
This commit is contained in:
Moritz 2026-01-21 08:35:34 +01:00
parent 1c5bd04661
commit d07f1984cd
3 changed files with 4 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

8
lib/membership/member.ex
View file

@ -203,8 +203,6 @@ defmodule Mv.Membership.Member do
{:ok, member, notifications} {:ok, member, notifications}
{:error, reason} -> {:error, reason} ->
require Logger
Logger.warning( Logger.warning(
"Failed to regenerate cycles for member #{member.id}: #{inspect(reason)}" "Failed to regenerate cycles for member #{member.id}: #{inspect(reason)}"
) )
@ -962,8 +960,6 @@ defmodule Mv.Membership.Member do
# Runs cycle generation synchronously (for test environment) # Runs cycle generation synchronously (for test environment)
defp handle_cycle_generation_sync(member, initiator) do defp handle_cycle_generation_sync(member, initiator) do
require Logger
case Mv.MembershipFees.CycleGenerator.generate_cycles_for_member( case Mv.MembershipFees.CycleGenerator.generate_cycles_for_member(
member.id, member.id,
today: Date.utc_today(), today: Date.utc_today(),
@ -1015,8 +1011,6 @@ defmodule Mv.Membership.Member do
sync: sync?, sync: sync?,
initiator: initiator initiator: initiator
) do ) do
require Logger
sync_label = if sync?, do: "", else: " (async)" sync_label = if sync?, do: "", else: " (async)"
initiator_info = get_initiator_info(initiator) initiator_info = get_initiator_info(initiator)
@ -1030,8 +1024,6 @@ defmodule Mv.Membership.Member do
# Logs cycle generation errors # Logs cycle generation errors
defp log_cycle_generation_error(member, reason, sync: sync?, initiator: initiator) do defp log_cycle_generation_error(member, reason, sync: sync?, initiator: initiator) do
require Logger
sync_label = if sync?, do: "", else: " (async)" sync_label = if sync?, do: "", else: " (async)"
initiator_info = get_initiator_info(initiator) initiator_info = get_initiator_info(initiator)

4
lib/mv/accounts/user/validations/email_not_used_by_other_member.ex
View file

@ -9,6 +9,8 @@ defmodule Mv.Accounts.User.Validations.EmailNotUsedByOtherMember do
""" """
use Ash.Resource.Validation use Ash.Resource.Validation
require Logger
@doc """ @doc """
Validates email uniqueness across linked User-Member pairs. Validates email uniqueness across linked User-Member pairs.
@ -92,8 +94,6 @@ defmodule Mv.Accounts.User.Validations.EmailNotUsedByOtherMember do
{:error, field: :email, message: "is already used by another member", value: email} {:error, field: :email, message: "is already used by another member", value: email}
{:error, reason} -> {:error, reason} ->
require Logger
Logger.warning( Logger.warning(
"Email uniqueness validation query failed for user email '#{email}': #{inspect(reason)}. Allowing operation to proceed (fail-open)." "Email uniqueness validation query failed for user email '#{email}': #{inspect(reason)}. Allowing operation to proceed (fail-open)."
) )

4
lib/mv/membership/member/validations/email_not_used_by_other_user.ex
View file

@ -10,6 +10,8 @@ defmodule Mv.Membership.Member.Validations.EmailNotUsedByOtherUser do
use Ash.Resource.Validation use Ash.Resource.Validation
alias Mv.Helpers alias Mv.Helpers
require Logger
@doc """ @doc """
Validates email uniqueness across linked Member-User pairs. Validates email uniqueness across linked Member-User pairs.
@ -64,8 +66,6 @@ defmodule Mv.Membership.Member.Validations.EmailNotUsedByOtherUser do
{:error, field: :email, message: "is already used by another user", value: email} {:error, field: :email, message: "is already used by another user", value: email}
{:error, reason} -> {:error, reason} ->
require Logger
Logger.warning( Logger.warning(
"Email uniqueness validation query failed for member email '#{email}': #{inspect(reason)}. Allowing operation to proceed (fail-open)." "Email uniqueness validation query failed for member email '#{email}': #{inspect(reason)}. Allowing operation to proceed (fail-open)."
) )