Commit graph

886 commits

Author SHA1 Message Date
5c3657fed1 Use SystemActor opts for cycle deletion operations
Pass actor_opts to delete_cycles/1 to ensure proper authorization
when MembershipFeeCycle policies are enforced
2026-01-21 08:02:32 +01:00
006b1aaf06 Replace Mix.env() with Config.sql_sandbox?() in SystemActor
Use Application config instead of Mix.env() to prevent
runtime crashes in production releases where Mix is not available
2026-01-21 08:02:31 +01:00
5eadd5f090 Refactor test setup into helper functions
All checks were successful
continuous-integration/drone/push Build is passing
Extract setup code into reusable helper functions to reduce
duplication and improve maintainability.
2026-01-20 23:16:40 +01:00
c5bd58e7d3 Add @spec type annotations to SystemActor functions
Add type specifications for all private functions to improve
static analysis with Dialyzer and documentation quality.
2026-01-20 23:16:39 +01:00
a3cf8571ff Document System Actor pattern in code guidelines
Add section explaining when and how to use system actor for systemic operations.
Include examples and distinction between user mode and system mode.
2026-01-20 22:10:11 +01:00
f1bb6a0f9a Add tests for System Actor helper
Test system actor retrieval, caching, fallback behavior,
and auto-creation in test environment.
2026-01-20 22:09:21 +01:00
c64b74588f Use system actor for cycle generation
Update cycle generator, member hooks, and job to use system actor.
Remove actor parameters as cycle generation is a mandatory side effect.
2026-01-20 22:09:20 +01:00
f0169c95b7 Use system actor for email uniqueness validation
Update email validation modules to use system actor for queries.
This ensures data integrity checks always run regardless of user permissions.
2026-01-20 22:09:19 +01:00
8acd92e8d4 Use system actor for email synchronization
Update email sync loader and changes to use system actor instead of user actor.
This ensures email sync always works regardless of user permissions.
2026-01-20 22:09:18 +01:00
d993bd3913 Create system user in seeds
Add system@mila.local user with admin role for systemic operations.
This user is used by SystemActor helper for mandatory side effects.
2026-01-20 22:09:17 +01:00
ddb1252831 Add System Actor helper for systemic operations
Introduce Mv.Helpers.SystemActor module with lazy loading
for operations that must always run regardless of user permissions.
System actor has admin role and auto-creates in test environment.
2026-01-20 22:09:16 +01:00
264323504f Merge pull request 'Small refactoring' (#360) from refactor into main
All checks were successful
continuous-integration/drone/push Build is passing
Reviewed-on: #360
2026-01-20 17:59:22 +01:00
2dc0bce8cb
chore: rm todo list
All checks were successful
continuous-integration/drone/push Build is passing
2026-01-20 17:04:42 +01:00
235154a102 test: Remove outdated TODO for auto-assignment feature
Some checks reported errors
continuous-integration/drone/push Build was killed
Auto-assignment of default membership fee type is already implemented
via SetDefaultMembershipFeeType change. Test assertion is now active.
2026-01-20 16:33:50 +01:00
c6dd0cd09d i18n: Add missing German translations for member form errors
- Add translations for validation error messages
- Add translations for save failure messages
2026-01-20 16:30:43 +01:00
0d8141837e
chore: update gettext 2026-01-20 16:15:01 +01:00
433f008af8 refactor: Reduce function complexity and nesting depth
- Extract helper functions from process_chunk to reduce nesting
- Extract format_error_message from extract_changeset_error
- Split extract_error_message into smaller functions to reduce complexity
- Fixes Credo refactoring opportunities
2026-01-20 16:05:32 +01:00
0abcf540bb refactor: Replace length/1 with empty list comparison
Replace expensive length/1 calls with direct list comparison
to fix Credo warnings about performance
2026-01-20 15:58:15 +01:00
32e0adb664
test: Add tests for UserLive.Show and RoleLive.Show
- Add comprehensive tests for UserLive.Show
- Add comprehensive tests for RoleLive.Show
- Cover mount, display, navigation, and error handling
2026-01-20 15:50:08 +01:00
cafd1d4ebc
refactor: Remove deprecated LiveViews
- Remove CustomFieldValueLive (Index, Form, Show)
- Remove ContributionTypeLive.Index
- Remove ContributionPeriodLive.Show
- Remove corresponding routes from router
- Remove references in CustomFieldValueLive.Index
2026-01-20 15:50:08 +01:00
9c2cff6307
docs: Update domain Public API documentation 2026-01-20 15:50:08 +01:00
4fe30d9546 Merge pull request 'Update docs' (#349) from docs/update into main
Reviewed-on: #349
2026-01-20 14:37:35 +01:00
b380f63cf6
chore: update docs 2026-01-20 14:31:13 +01:00
58c088833a
chore: update docs 2026-01-20 14:10:41 +01:00
b84431879c Merge pull request 'fix admin database seeding closes #357' (#358) from bugfix/reseeding-database-not-working into main
Reviewed-on: #358
2026-01-19 14:17:12 +01:00
d9b659e5ea
fix: linting + tests 2026-01-19 14:09:19 +01:00
bc4bcd0089
fix: change creation of admin user 2026-01-19 13:40:28 +01:00
fef2cce283 Merge pull request 'Implements error capping' (#356) from feature/334_Ash_persistence into main
Reviewed-on: #356
2026-01-19 13:14:59 +01:00
584442076e
fix: add error message to form 2026-01-19 12:47:17 +01:00
ac0e272cca refactor: change length for performance 2026-01-19 12:37:39 +01:00
bf93b4aa42 docs: update implementation plan 2026-01-19 12:31:39 +01:00
b70dd3d98f formatting 2026-01-19 12:02:34 +01:00
3cbd90ecdd feat: adds error capping 2026-01-19 12:02:28 +01:00
c31392e4fe Merge pull request 'Implements row validation closes #333' (#355) from feature/333_validation into main
Reviewed-on: #355
2026-01-19 11:46:59 +01:00
24426c7786 Merge branch 'main' into feature/333_validation 2026-01-19 11:46:14 +01:00
7da037d81d refactor: adds schemales changeset and validation constant 2026-01-19 11:43:51 +01:00
14a8417fdf i18n: adds translation 2026-01-19 11:24:51 +01:00
8b3cc6a6b2 feat: adds row validation 2026-01-19 11:22:11 +01:00
07de1b4b6a Merge pull request 'Reorder Sidebar Menu entries and smaller fixes' (#353) from feature/reorder-sidebar-menu into main
Reviewed-on: #353
Reviewed-by: carla <carla@noreply.git.local-it.org>
2026-01-19 11:07:43 +01:00
467b36784f
fix: remove !important statements 2026-01-16 17:26:52 +01:00
54d96136b7
fix: link/button semantics 2026-01-16 17:16:06 +01:00
c86ae6aa9d
fix: sidebar accessibility 2026-01-16 14:17:15 +01:00
c3515b4105
feat: adjust display of submenu 2026-01-16 13:53:31 +01:00
d6173571b5
test: make tests more structural, less dependend on specific values 2026-01-16 12:48:35 +01:00
3381fd88db
test: increase test worker pool size 2026-01-16 12:47:46 +01:00
74af41c8ab
feat: reorder sidebar 2026-01-16 12:46:45 +01:00
9be5dc8751 Merge pull request 'implements header normalization closes #332' (#352) from feature/332_header_normalization into main
Reviewed-on: #352
2026-01-15 17:01:50 +01:00
6dc398fa5a refactor: reduce complexity 2026-01-15 17:00:17 +01:00
67072f0c52 feat: adds header header normalization 2026-01-15 16:11:09 +01:00
0673684cc1 test: adds tests for header normalization 2026-01-15 16:11:02 +01:00