local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 51 Pull requests 14 Projects 1 Releases Packages 1 Activity Actions

Custom Fields: Harden implementation closes #194 #204

Merged
carla merged 5 commits from feature/harden-custom-fields into main 2025-11-17 17:01:32 +01:00
Conversation 2 Commits 5 Files changed 39 +2337 -1269
moritz commented 2025-11-13 18:00:46 +01:00
Owner
Copy link

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

#194

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues

Additional Notes

## Description of the implemented changes The changes were: - [ ] Bugfixing - [ ] New Feature - [x] Breaking Change - [x] Refactoring https://git.local-it.org/local-it/mitgliederverwaltung/issues/194 ## Definition of Done ### Code Quality - [x] No new technical depths - [x] Linting passed - [ ] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [ ] axe-core dev tools show no critical or major issues ## Additional Notes
moritz self-assigned this 2025-11-13 18:00:46 +01:00
moritz added 1 commit 2025-11-13 18:00:48 +01:00
refactor: Rename Property/PropertyType to CustomFieldValue/CustomField
Some checks failed
continuous-integration/drone/push Build is failing
Details
dc438863d3 
Complete refactoring of resources, database tables, code references, tests, and documentation for improved naming consistency.
moritz force-pushed feature/harden-custom-fields from dc438863d3 to 8400e727a7 2025-11-13 18:05:04 +01:00 Compare
moritz added 2 commits 2025-11-13 18:40:38 +01:00
fix: Allow optional email values in custom fields
All checks were successful
continuous-integration/drone/push Build is passing
Details
2b3c94d3b2
moritz added 2 commits 2025-11-13 18:50:39 +01:00
feat: Add Custom Fields link to navbar
Some checks failed
continuous-integration/drone/push Build is failing
Details
d9ebbab5a4
requested reviews from simon, carla 2025-11-13 18:51:04 +01:00
moritz changed title from WIP: Custom Fields: Harden implementation closes #194 to Custom Fields: Harden implementation closes #194 2025-11-13 18:51:37 +01:00
moritz force-pushed feature/harden-custom-fields from d9ebbab5a4 to 158ac52d97 2025-11-13 18:52:35 +01:00 Compare
carla approved these changes 2025-11-17 16:56:23 +01:00
Dismissed
carla left a comment
Owner
Copy link

Great work!!! 💯

Great work!!! 💯
docs/database-schema-readme.md
@ -124,2 +124,2 @@
### Property System
- Maximum one property per type per member
### CustomFieldValue System
- Maximum one custom field value per custom field per member
carla commented 2025-11-17 16:42:05 +01:00
Owner
Copy link

We would not think about enums here, right? Because in case of that or lists we would have more than one value per custom field...

We would not think about enums here, right? Because in case of that or lists we would have more than one value per custom field...
moritz commented 2025-11-20 13:35:14 +01:00
Author
Owner
Copy link

Enums will just enable a selection of different values. But inside the custom field value only one value will be stored.

Enums will just enable a selection of different values. But inside the `custom field value` only one value will be stored.
moritz marked this conversation as resolved
lib/mv_web/live/custom_field_value_live/form.ex
@ -0,0 +39,4 @@
<.header>
{@page_title}
<:subtitle>
{gettext("Use this form to manage custom_field_value records in your database.")}
carla commented 2025-11-17 16:51:28 +01:00
Owner
Copy link

Maybe without underscore?

Maybe without underscore?
moritz marked this conversation as resolved
carla approved these changes 2025-11-17 17:01:21 +01:00
carla left a comment
Owner
Copy link

Great work!! 💯

Great work!! 💯
carla merged commit a273b54c75 into main 2025-11-17 17:01:32 +01:00
carla deleted branch feature/harden-custom-fields 2025-11-17 17:01:33 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
simon
carla
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
high priority

   
invalid

Something is wrong

  
L

5 h

  
low priority

   
M

3 h

  
medium priority

   
needs refinement

   
question

More information is needed

  
S

1 h

  
UX research

   
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
question
S
UX research
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
moritz
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: local-it/mitgliederverwaltung#204
No description provided.
Delete branch "feature/harden-custom-fields"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?