local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 62 Pull requests 8 Projects 1 Releases Packages 1 Activity Actions

Membership Fee - Database Schema & Ash Domain Foundation closes #275 #283

Merged
moritz merged 2 commits from feature/275_member_fee_domain into main 2025-12-16 14:06:46 +01:00
Conversation 1 Commits 2 Files changed 14 +1478 -7
moritz commented 2025-12-11 16:28:55 +01:00
Owner
Copy link

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues
## Description of the implemented changes The changes were: - [ ] Bugfixing - [x] New Feature - [ ] Breaking Change - [ ] Refactoring ## Definition of Done ### Code Quality - [ ] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [ ] axe-core dev tools show no critical or major issues
moritz added this to the Membership Fees milestone 2025-12-11 16:28:55 +01:00
moritz self-assigned this 2025-12-11 16:28:55 +01:00
moritz added 1 commit 2025-12-11 16:28:57 +01:00
feat(membership-fees): add database schema and Ash domain structure
All checks were successful
continuous-integration/drone/push Build is passing
Details
b37c312b15
moritz added 1 commit 2025-12-11 17:07:05 +01:00
fix(membership-fees): add DB constraints for enum and decimal precision
Some checks failed
continuous-integration/drone/push Build is failing
Details
174b7696d3
moritz force-pushed feature/275_member_fee_domain from 174b7696d3 to caebcefb8c 2025-12-11 18:34:47 +01:00 Compare
moritz changed title from WIP: Membership Fee - Database Schema & Ash Domain Foundation closes #275 to Membership Fee - Database Schema & Ash Domain Foundation closes #275 2025-12-11 18:35:38 +01:00
moritz force-pushed feature/275_member_fee_domain from caebcefb8c to a3aa61a89e 2025-12-11 18:35:54 +01:00 Compare
moritz force-pushed feature/275_member_fee_domain from a3aa61a89e to ebbf347e42 2025-12-11 18:46:53 +01:00 Compare
moritz added a new dependency 2025-12-15 21:39:11 +01:00
#284 Calendar Cycle Calculation Logic closes #276
carla approved these changes 2025-12-16 12:12:25 +01:00
carla left a comment
Owner
Copy link

Good work. I just have the questions I mentioned, otherwise looks good to me :)

Good work. I just have the questions I mentioned, otherwise looks good to me :)
lib/membership_fees/membership_fee_type.ex
@ -0,0 +9,4 @@
## Attributes
- `name` - Unique name for the fee type (e.g., "Standard", "Reduced", "Family")
- `amount` - The fee amount in the default currency (decimal)
carla commented 2025-12-15 17:05:34 +01:00
Owner
Copy link

One member of the pilot clubs said they have the case that many members have individual fees. That would be possible that we define an amount on member level let's say?

One member of the pilot clubs said they have the case that many members have individual fees. That would be possible that we define an amount on member level let's say?
moritz commented 2025-12-16 13:58:33 +01:00
Author
Owner
Copy link

In that case this club needs to define a member type for each member that has an individual fee. I think it's a quite special case, but it could be covered this way.

In that case this club needs to define a member type for each member that has an individual fee. I think it's a quite special case, but it could be covered this way.
lib/mv/constants.ex
@ -17,2 +17,3 @@
:house_number,
:postal_code
:postal_code,
:membership_fee_start_date
carla commented 2025-12-15 16:48:07 +01:00
Owner
Copy link

I do not get why we need that as constant / member field? Isn't it always the join date + next cycle?

I do not get why we need that as constant / member field? Isn't it always the join date + next cycle?
moritz commented 2025-12-16 13:59:52 +01:00
Author
Owner
Copy link

Sometimes the member should start to pay later or earlier then the joining date. This way the date when the cycles were generated can be modified.

Sometimes the member should start to pay later or earlier then the joining date. This way the date when the cycles were generated can be modified.
priv/repo/migrations/20251211151449_add_membership_fees_tables.exs
@ -0,0 +50,4 @@
),
null: false
# RESTRICT: Cannot delete fee type if cycles reference it
carla commented 2025-12-15 16:52:03 +01:00
Owner
Copy link

What if members paid cycles in the past for a specific type and now this type changes?

What if members paid cycles in the past for a specific type and now this type changes?
moritz commented 2025-12-16 14:02:53 +01:00
Author
Owner
Copy link

As long as there are existing cycles paid in the past the referring type shouldn't be deleted, even if another type is now assigned to the member. Maybe we could implement in future a way to deactivate unused types. So they exist for the history but can not selected anymore.

As long as there are existing cycles paid in the past the referring type shouldn't be deleted, even if another type is now assigned to the member. Maybe we could implement in future a way to deactivate unused types. So they exist for the history but can not selected anymore.
moritz merged commit cb82c07cbf into main 2025-12-16 14:06:46 +01:00
moritz deleted branch feature/275_member_fee_domain 2025-12-16 14:06:47 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
carla
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
high priority

   
invalid

Something is wrong

  
L

5 h

  
low priority

   
M

3 h

  
medium priority

   
needs refinement

   
question

More information is needed

  
S

1 h

  
UX research

   
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
question
S
UX research
wontfix
Milestone
Clear milestone
No items
No milestone
Membership Fees
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
moritz
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#284 Calendar Cycle Calculation Logic closes #276
local-it/mitgliederverwaltung
Reference: local-it/mitgliederverwaltung#283
No description provided.
Delete branch "feature/275_member_fee_domain"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?