local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 61 Pull requests 12 Projects 1 Releases Packages 1 Activity Actions

Calendar Cycle Calculation Logic closes #276 #284

Open
moritz wants to merge 5 commits from feature/276_cycle_calculation into main
pull from: feature/276_cycle_calculation
merge into: local-it:main
Conversation 0 Commits 5 Files changed 16 +1988 -7
moritz commented 2025-12-11 19:46:32 +01:00
Owner
Copy link

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues
## Description of the implemented changes The changes were: - [ ] Bugfixing - [x] New Feature - [ ] Breaking Change - [ ] Refactoring ## Definition of Done ### Code Quality - [x] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [ ] axe-core dev tools show no critical or major issues
moritz added this to the Membership Fees milestone 2025-12-11 19:46:32 +01:00
moritz self-assigned this 2025-12-11 19:46:32 +01:00
moritz added 3 commits 2025-12-11 19:46:33 +01:00
fix(membership-fees): add DB constraints for enum and decimal precision
All checks were successful
continuous-integration/drone/push Build is passing
Details
ebbf347e42
feat: implement calendar-based cycle calculation functions
All checks were successful
continuous-integration/drone/push Build is passing
Details
822d06ed54 
Add CalendarCycles module with functions for all interval types.
Includes comprehensive tests for edge cases.
moritz added 1 commit 2025-12-11 20:08:27 +01:00
refactor: improve CalendarCycles API and tests based on code review
All checks were successful
continuous-integration/drone/push Build is passing
Details
b257c9897f
moritz added 1 commit 2025-12-11 20:21:28 +01:00
docs: fix CalendarCycles documentation to match actual implementation
All checks were successful
continuous-integration/drone/push Build is passing
Details
ecddf55331
moritz changed title from WIP: Calendar Cycle Calculation Logic closes #276 to Calendar Cycle Calculation Logic closes #276 2025-12-11 20:47:13 +01:00
All checks were successful
continuous-integration/drone/push Build is passing
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feature/276_cycle_calculation:feature/276_cycle_calculation
git checkout feature/276_cycle_calculation

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout main
git merge --no-ff feature/276_cycle_calculation
git checkout feature/276_cycle_calculation
git rebase main
git checkout main
git merge --ff-only feature/276_cycle_calculation
git checkout feature/276_cycle_calculation
git rebase main
git checkout main
git merge --no-ff feature/276_cycle_calculation
git checkout main
git merge --squash feature/276_cycle_calculation
git checkout main
git merge --ff-only feature/276_cycle_calculation
git checkout main
git merge feature/276_cycle_calculation
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
high priority

   
invalid

Something is wrong

  
L

5 h

  
low priority

   
M

3 h

  
medium priority

   
needs refinement

   
question

More information is needed

  
S

1 h

  
UX research

   
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
question
S
UX research
wontfix
Milestone
Clear milestone
No items
No milestone
Membership Fees
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
moritz
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: local-it/mitgliederverwaltung#284
No description provided.
Delete branch "feature/276_cycle_calculation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?