local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 66 Pull requests 6 Projects 3 Releases Packages 1 Activity Actions

Cycle Generation System closes #277 #290

Merged
moritz merged 11 commits from feature/277_cycle_generation into main 2025-12-18 11:53:12 +01:00
Conversation 1 Commits 11 Files changed 17 +3076 -29
moritz commented 2025-12-12 16:56:35 +01:00
Owner
Copy link

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues
## Description of the implemented changes The changes were: - [ ] Bugfixing - [x] New Feature - [ ] Breaking Change - [ ] Refactoring ## Definition of Done ### Code Quality - [ ] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [ ] axe-core dev tools show no critical or major issues
moritz added this to the Membership Fees milestone 2025-12-12 16:56:35 +01:00
moritz self-assigned this 2025-12-12 16:56:36 +01:00
moritz added 2 commits 2025-12-12 16:56:37 +01:00
fix(membership-fees): add DB constraints for enum and decimal precision
All checks were successful
continuous-integration/drone/push Build is passing
Details
ebbf347e42
moritz added a new dependency 2025-12-15 21:38:28 +01:00
#291 Membership Fee Type Resource & Settings closes #278
moritz added a new dependency 2025-12-15 21:38:52 +01:00
#284 Calendar Cycle Calculation Logic closes #276
moritz force-pushed feature/277_cycle_generation from 82897d5cd3 to 5acf4364fa 2025-12-16 15:07:11 +01:00 Compare
moritz force-pushed feature/277_cycle_generation from 5acf4364fa to ed083830b9 2025-12-16 16:40:20 +01:00 Compare
requested review from carla 2025-12-17 07:59:45 +01:00
carla approved these changes 2025-12-17 10:55:15 +01:00
carla left a comment
Owner
Copy link

Nice work :)
Just the small thing with the docs.
And I asked myself if it might be performance wise an issue if a lot of members are imported the first time...

Nice work :) Just the small thing with the docs. And I asked myself if it might be performance wise an issue if a lot of members are imported the first time...
lib/membership/member.ex
@ -80,7 +80,7 @@ defmodule Mv.Membership.Member do
argument :user, :map, allow_nil?: true
# Accept member fields plus membership_fee_type_id (belongs_to FK)
carla commented 2025-12-17 08:02:17 +01:00
Owner
Copy link
  • membership fee start date
+ membership fee start date
lib/membership/setting.ex
@ -12,2 +12,4 @@
- `member_field_visibility` - JSONB map storing visibility configuration for member fields
(e.g., `%{"street" => false, "house_number" => false}`). Fields not in the map default to `true`.
- `include_joining_cycle` - Whether to include the joining cycle in membership fee generation (default: true)
- `default_membership_fee_type_id` - Default membership fee type for new members (optional)
carla commented 2025-12-17 08:04:02 +01:00
Owner
Copy link

Good idea!

Good idea!
moritz marked this conversation as resolved
lib/mv/membership_fees/cycle_generation_job.ex
@ -0,0 +128,4 @@
- Has a membership_fee_type assigned
- Has a join_date set
- Is active (no exit_date or exit_date >= today)
carla commented 2025-12-17 08:16:18 +01:00
Owner
Copy link

We thought about payment status "suspended", should we keep that in mind somehow?

We thought about payment status "suspended", should we keep that in mind somehow?
moritz commented 2025-12-18 11:51:58 +01:00
Author
Owner
Copy link

The suspended status is implemented in another issue

The suspended status is implemented in another issue
moritz marked this conversation as resolved
moritz merged commit ff39448fd6 into main 2025-12-18 11:53:12 +01:00
moritz deleted branch feature/277_cycle_generation 2025-12-18 11:53:12 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
carla
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
high priority

   
invalid

Something is wrong

  
L

5 h

  
low priority

   
M

3 h

  
medium priority

   
needs refinement

   
optional

   
question

More information is needed

  
S

1 h

  
UX research

   
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
optional
question
S
UX research
wontfix
Milestone
Clear milestone
No items
No milestone
Membership Fees
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
moritz
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#291 Membership Fee Type Resource & Settings closes #278
local-it/mitgliederverwaltung
Depends on
#284 Calendar Cycle Calculation Logic closes #276
local-it/mitgliederverwaltung
Reference: local-it/mitgliederverwaltung#290
No description provided.
Delete branch "feature/277_cycle_generation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?