Membership Fee Type Resource & Settings closes #278 #291

Open

moritz wants to merge 27 commits from feature/278_membership_fee_settings into main

pull from: feature/278_membership_fee_settings

merge into: local-it:main

local-it:main

local-it:feature/279_cycle_management

local-it:feature/223_memberfields_settings

local-it:feature/281_uxfixes

local-it:feature/277_cycle_generation

local-it:feature/276_cycle_calculation

local-it:feature/275_member_fee_domain

local-it:renovate/major-postgres

local-it:sidebar

local-it:speed-up-drone

local-it:feature/220_ui_issues_2

local-it:persist-sort-order

local-it:feature/151_roles_permissions_docs

local-it:manual_renovate_update

local-it:feature/#158-polish-README

local-it:feature/128_playwright_a11y_test

local-it:feature/119_member_user_relation_refactor

local-it:feature/119_user_as_member

local-it:feature/backpex-migration

local-it:feature/backpex_translation

local-it:feature/39_account_ressource

local-it:feature/74_memberfields

local-it:validation

local-it:feature/36_add_primerlive

Conversation 0 Commits 27 Files changed 44 +6334 -690

moritz commented 2025-12-12 18:12:29 +01:00

Owner

Copy link

Description of the implemented changes

The changes were:

• Bugfixing
• New Feature
• Breaking Change
• Refactoring

Definition of Done

Code Quality

• No new technical depths
• Linting passed
• Documentation is added were needed

Accessibility

• New elements are properly defined with html-tags
• Colour contrast follows WCAG criteria
• Aria labels are added when needed
• Everything is accessible by keyboard
• Tab-Order is comprehensible
• All interactive elements have a visible focus

Testing

• Tests for new code are written
• All tests pass
• axe-core dev tools show no critical or major issues

## Description of the implemented changes The changes were: - [ ] Bugfixing - [x] New Feature - [ ] Breaking Change - [ ] Refactoring ## Definition of Done ### Code Quality - [ ] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [x] axe-core dev tools show no critical or major issues

moritz added this to the Membership Fees milestone 2025-12-12 18:12:29 +01:00

moritz self-assigned this 2025-12-12 18:12:29 +01:00

moritz added 20 commits 2025-12-12 18:12:30 +01:00

feat(membership-fees): add database schema and Ash domain structure 4d1b33357e

fix(membership-fees): add DB constraints for enum and decimal precision ebbf347e42

feat: implement calendar-based cycle calculation functions ... 822d06ed54

Add CalendarCycles module with functions for all interval types.
Includes comprehensive tests for edge cases.

refactor: improve CalendarCycles API and tests based on code review b257c9897f

docs: fix CalendarCycles documentation to match actual implementation ecddf55331

feat: implement automatic cycle generation for members ... 162d06da21

- Add CycleGenerator module with advisory lock mechanism
- Add SetMembershipFeeStartDate change for auto-calculation
- Extend Settings with include_joining_cycle and default_membership_fee_type_id
- Add scheduled job skeleton for future Oban integration

refactor: use sql_sandbox config instead of env for sync/async ... 7e4d3e0a60

- Replace Application.get_env(:mv, :env) with :sql_sandbox config
- Remove redundant :env config from test.exs
- More explicit and less error-prone for test environment detection

feat: add error logging in after_action cycle generation hooks ... 2e8c9eeccb

- Log warnings when cycle generation fails in Member create/update
- Extract generate_fn to reduce code duplication
- Improves debuggability of silent failures

refactor: improve SetMembershipFeeStartDate change module ... b693ab1e26

- Add warning logging for unexpected errors (not missing prerequisites)
- Use CalendarCycles.interval() type instead of generic atom()
- Update moduledoc to reflect actual usage (no where clause needed)

feat: include inactive members in batch cycle generation ... a99f56969d

- Remove exit_date filter from generate_cycles_for_all_members query
- Inactive members now get cycles generated up to their exit_date
- Add tests for inactive member processing and exit_date boundary
- Document exit_date == cycle_start behavior (cycle still generated)

feat: improve error handling in CycleGenerator ... cf8a1fa30d

- Handle Task crashes in async_stream with {:exit, reason}
- Return {:error, {:partial_failure, successes, errors}} when some cycles fail
- Previously returned {:ok, successful} even on partial failures
- Improves debuggability and allows callers to handle partial failures

test: make CycleGenerator tests more robust ... 272a8a8afc

- Replace weak assertions (>= 0, if length > 0) with concrete expectations
- Remove unnecessary Process.sleep calls (tests run synchronously)
- Add get_member_cycles helper for direct cycle verification
- Tests now validate actual generated cycles instead of relying on async behavior

fix: CycleGenerator generates from last cycle, not filling gaps ... 0b986db635

- Change algorithm to start from last existing cycle instead of start_date
- Deleted cycles (gaps) are no longer automatically filled
- Add test to verify gaps remain unfilled
- Update documentation to clarify gap handling behavior

test: fix date dependencies in cycle generator tests ... f7fc1f4897

- Add create_member_with_cycles helper that uses fixed 'today' date
- Update tests to use explicit 'today:' option instead of Date.utc_today()
- Prevents test failures when current date changes (e.g., in 2026+)
- Tests now explicitly delete and regenerate cycles with fixed dates
- Ensures consistent test behavior regardless of execution date

fix: handle Ash notifications in CycleGenerator transactions ... e6ac5d1ab1

- Use return_notifications?: true when creating cycles within transaction
- Collect notifications and send them after transaction commits
- Prevents 'Missed notifications' warnings in test output
- Notifications are now properly sent via Ash.Notifier.notify/1

refactor: improve cycle generation code quality and documentation ... 82897d5cd3

- Remove Process.sleep calls from integration tests (tests run synchronously in SQL sandbox)
- Improve error handling: membership_fee_type_not_found now returns changeset error instead of just logging
- Clarify partial_failure documentation: successful_cycles are not persisted on rollback
- Update documentation: joined_at → join_date, left_at → exit_date
- Document PostgreSQL advisory locks per member (not whole table lock)
- Document gap handling: explicitly deleted cycles are not recreated

feat: implement full CRUD for membership fee types with settings UI ... da1fd3da73

- Add interval immutability and deletion prevention validations
- Add settings validation for default_membership_fee_type_id
- Create MembershipFeeSettingsLive for admin UI with form handling
- Add comprehensive test coverage (unit, integration, settings)

i18n: add German translations for membership fee settings 98b908abdb

refactor: replace ContributionSettingsLive mockup with MembershipFeeSettingsLive in navigation 96729cb2f4

fix: improve accessibility - WCAG 2 AA contrast and select label 5bdd769699

moritz added 1 commit 2025-12-12 18:17:07 +01:00

refactor: use Enum.map_join instead of Enum.map |> Enum.join af7ae2b722

moritz changed title from Membership Fee Type Resource & Settings to Membership Fee Type Resource & Settings closes #278 2025-12-12 18:30:28 +01:00

moritz added 6 commits 2025-12-12 19:10:56 +01:00

feat: prevent deletion of membership fee type when used as default in settings c445b78157

feat: improve error handling in settings validation for default_membership_fee_type_id 9e441213be

refactor: migrate MembershipFeeSettingsLive to AshPhoenix.Form 8cbd481709

docs: document require_atomic? false in MembershipFeeType actions 569d88ccdf

chore: update gettext b3016f0c81

feat: add 4 example membership fee types to seed script f39fd49af3

All checks were successful

Hide all checks

continuous-integration/drone/push Build is passing

Details

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin feature/278_membership_fee_settings:feature/278_membership_fee_settings

git checkout feature/278_membership_fee_settings

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout main

git merge --no-ff feature/278_membership_fee_settings

git checkout feature/278_membership_fee_settings

git rebase main

git checkout main

git merge --ff-only feature/278_membership_fee_settings

git checkout feature/278_membership_fee_settings

git rebase main

git checkout main

git merge --no-ff feature/278_membership_fee_settings

git checkout main

git merge --squash feature/278_membership_fee_settings

git checkout main

git merge --ff-only feature/278_membership_fee_settings

git checkout main

git merge feature/278_membership_fee_settings

git push origin main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

high priority

  

invalid

Something is wrong

  

L

5 h

  

low priority

  

M

3 h

  

medium priority

  

needs refinement

  

question

More information is needed

  

S

1 h

  

UX research

  

wontfix

This won't be fixed

No labels

bug

duplicate

enhancement

help wanted

high priority

invalid

L

low priority

M

medium priority

needs refinement

question

S

UX research

wontfix

Milestone

Clear milestone

No items

No milestone

Membership Fees

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

moritz

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: local-it/mitgliederverwaltung#291

No description provided.