Cycle Management & Member Integration closes #279 #294

Merged

moritz merged 22 commits from feature/279_cycle_management into main 2025-12-18 15:01:58 +01:00

Conversation 0 Commits 22 Files changed 12 +1832 -342

moritz commented 2025-12-15 11:38:39 +01:00

Owner

Copy link

Description of the implemented changes

The changes were:

• Bugfixing
• New Feature
• Breaking Change
• Refactoring

Definition of Done

Code Quality

• No new technical depths
• Linting passed
• Documentation is added were needed

Accessibility

• New elements are properly defined with html-tags
• Colour contrast follows WCAG criteria
• Aria labels are added when needed
• Everything is accessible by keyboard
• Tab-Order is comprehensible
• All interactive elements have a visible focus

Testing

• Tests for new code are written
• All tests pass
• axe-core dev tools show no critical or major issues

## Description of the implemented changes The changes were: - [ ] Bugfixing - [x] New Feature - [ ] Breaking Change - [ ] Refactoring ## Definition of Done ### Code Quality - [x] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [ ] axe-core dev tools show no critical or major issues

moritz self-assigned this 2025-12-15 11:38:39 +01:00

moritz added 31 commits 2025-12-15 11:38:41 +01:00

feat(membership-fees): add database schema and Ash domain structure 4d1b33357e

fix(membership-fees): add DB constraints for enum and decimal precision ebbf347e42

feat: implement calendar-based cycle calculation functions ... 822d06ed54

Add CalendarCycles module with functions for all interval types.
Includes comprehensive tests for edge cases.

refactor: improve CalendarCycles API and tests based on code review b257c9897f

docs: fix CalendarCycles documentation to match actual implementation ecddf55331

feat: implement automatic cycle generation for members ... 162d06da21

- Add CycleGenerator module with advisory lock mechanism
- Add SetMembershipFeeStartDate change for auto-calculation
- Extend Settings with include_joining_cycle and default_membership_fee_type_id
- Add scheduled job skeleton for future Oban integration

refactor: use sql_sandbox config instead of env for sync/async ... 7e4d3e0a60

- Replace Application.get_env(:mv, :env) with :sql_sandbox config
- Remove redundant :env config from test.exs
- More explicit and less error-prone for test environment detection

feat: add error logging in after_action cycle generation hooks ... 2e8c9eeccb

- Log warnings when cycle generation fails in Member create/update
- Extract generate_fn to reduce code duplication
- Improves debuggability of silent failures

refactor: improve SetMembershipFeeStartDate change module ... b693ab1e26

- Add warning logging for unexpected errors (not missing prerequisites)
- Use CalendarCycles.interval() type instead of generic atom()
- Update moduledoc to reflect actual usage (no where clause needed)

feat: include inactive members in batch cycle generation ... a99f56969d

- Remove exit_date filter from generate_cycles_for_all_members query
- Inactive members now get cycles generated up to their exit_date
- Add tests for inactive member processing and exit_date boundary
- Document exit_date == cycle_start behavior (cycle still generated)

feat: improve error handling in CycleGenerator ... cf8a1fa30d

- Handle Task crashes in async_stream with {:exit, reason}
- Return {:error, {:partial_failure, successes, errors}} when some cycles fail
- Previously returned {:ok, successful} even on partial failures
- Improves debuggability and allows callers to handle partial failures

test: make CycleGenerator tests more robust ... 272a8a8afc

- Replace weak assertions (>= 0, if length > 0) with concrete expectations
- Remove unnecessary Process.sleep calls (tests run synchronously)
- Add get_member_cycles helper for direct cycle verification
- Tests now validate actual generated cycles instead of relying on async behavior

fix: CycleGenerator generates from last cycle, not filling gaps ... 0b986db635

- Change algorithm to start from last existing cycle instead of start_date
- Deleted cycles (gaps) are no longer automatically filled
- Add test to verify gaps remain unfilled
- Update documentation to clarify gap handling behavior

test: fix date dependencies in cycle generator tests ... f7fc1f4897

- Add create_member_with_cycles helper that uses fixed 'today' date
- Update tests to use explicit 'today:' option instead of Date.utc_today()
- Prevents test failures when current date changes (e.g., in 2026+)
- Tests now explicitly delete and regenerate cycles with fixed dates
- Ensures consistent test behavior regardless of execution date

fix: handle Ash notifications in CycleGenerator transactions ... e6ac5d1ab1

- Use return_notifications?: true when creating cycles within transaction
- Collect notifications and send them after transaction commits
- Prevents 'Missed notifications' warnings in test output
- Notifications are now properly sent via Ash.Notifier.notify/1

refactor: improve cycle generation code quality and documentation ... 82897d5cd3

- Remove Process.sleep calls from integration tests (tests run synchronously in SQL sandbox)
- Improve error handling: membership_fee_type_not_found now returns changeset error instead of just logging
- Clarify partial_failure documentation: successful_cycles are not persisted on rollback
- Update documentation: joined_at → join_date, left_at → exit_date
- Document PostgreSQL advisory locks per member (not whole table lock)
- Document gap handling: explicitly deleted cycles are not recreated

feat: implement full CRUD for membership fee types with settings UI ... da1fd3da73

- Add interval immutability and deletion prevention validations
- Add settings validation for default_membership_fee_type_id
- Create MembershipFeeSettingsLive for admin UI with form handling
- Add comprehensive test coverage (unit, integration, settings)

i18n: add German translations for membership fee settings 98b908abdb

refactor: replace ContributionSettingsLive mockup with MembershipFeeSettingsLive in navigation 96729cb2f4

fix: improve accessibility - WCAG 2 AA contrast and select label 5bdd769699

refactor: use Enum.map_join instead of Enum.map |> Enum.join af7ae2b722

feat: prevent deletion of membership fee type when used as default in settings c445b78157

feat: improve error handling in settings validation for default_membership_fee_type_id 9e441213be

refactor: migrate MembershipFeeSettingsLive to AshPhoenix.Form 8cbd481709

docs: document require_atomic? false in MembershipFeeType actions 569d88ccdf

chore: update gettext b3016f0c81

feat: add 4 example membership fee types to seed script f39fd49af3

feat: add status management actions to MembershipFeeCycle 48d98b97b2

feat: add cycle status calculations to Member resource 6763d4f2eb

feat: add validation for same-interval membership fee type changes 7994303166

feat: regenerate cycles when membership fee type changes (same interval) ... cad8cac9a8

- Implemented regenerate_cycles_on_type_change helper in Member resource
- Cycles that haven't ended yet (cycle_end >= today) are deleted and regenerated
- Paid and suspended cycles remain unchanged (not deleted)
- CycleGenerator reloads member with new membership_fee_type_id
- Adjusted tests to work with current cycles only (no future cycles)
- All integration tests passing

Phase 4 completed: Cycle regeneration on type change

moritz force-pushed feature/279_cycle_management from cad8cac9a8 to 06324d77c5 2025-12-15 11:39:37 +01:00 Compare

moritz changed title from Cycle Management & Member Integration to Cycle Management & Member Integration closes #279 2025-12-15 11:40:14 +01:00

moritz added 1 commit 2025-12-15 11:50:26 +01:00

refactor: reduce nesting depth and improve code readability ... e9c53cc520

- Replace Enum.map |> Enum.join with Enum.map_join for efficiency
- Extract helper functions to reduce nesting depth from 4 to 2
- Rename is_current_cycle? to current_cycle? following Elixir conventions

moritz added 10 commits 2025-12-15 12:41:38 +01:00

fix: make cycle regeneration atomic on type change ... 1e5f84fd88

Make cycle regeneration synchronous in the same transaction as the member
update to ensure atomicity.

fix: implement fail-closed behavior in ValidateSameInterval ... 032db2a4ba

Change validation to fail closed instead of fail open when types cannot
be loaded. This prevents inconsistent data states and provides clearer
error messages to users.

fix: prevent nil assignment for membership_fee_type_id ... 28b2be1125

Reject attempts to set membership_fee_type_id to nil when a current type
exists.

test: remove Process.sleep from type change integration tests f08b520e66

test: add monthly interval tests for cycle calculations 9f33db3fed

docs: update architecture docs for atomic cycle regeneration bbae62313d

fix: remove unused variable warning in ValidateSameInterval 446f75bcc1

test: update test to reflect nil assignment prevention ba6b81e155

fix: prevent deadlocks by detecting existing transactions b81ed99571

refactor: reduce complexity of with_advisory_lock function ... 34aabaec47

Split the complex with_advisory_lock function into smaller, focused
functions to improve readability and reduce cyclomatic complexity:

- with_advisory_lock_in_transaction: Handles case when already in transaction
- with_advisory_lock_new_transaction: Handles case when starting new transaction
- execute_within_transaction: Executes function within transaction
- normalize_fun_result: Normalizes function results to consistent format
- handle_transaction_result: Handles transaction results and sends notifications

This fixes Credo warnings:
- Function body nested too deep (was 3, now max 2)
- Function too complex (was 11, now max 9)

moritz force-pushed feature/279_cycle_management from 34aabaec47 to 65d1561803 2025-12-15 13:38:43 +01:00 Compare

moritz added 1 commit 2025-12-15 15:27:31 +01:00

fix: resolve notification handling and maintain after_action for cycle regeneration bb5851bc23

moritz added 1 commit 2025-12-15 16:01:56 +01:00

refactor: implement proper notification handling via after_action hooks ... 666c7b8802

Refactor notification handling according to Ash best practices

moritz added 2 commits 2025-12-15 21:26:54 +01:00

fix: address notification handling review feedback ... c3ccecd138

1. Fix misleading comment in async create_member path
2. Use skip_lock?: true in test case for create_member
3. Fix generate_cycles_for_all_members/1

refactor: reduce nesting depth in process_batch function 342ebb73b9

moritz added a new dependency 2025-12-15 21:38:03 +01:00

#291 Membership Fee Type Resource & Settings closes #278

moritz force-pushed feature/279_cycle_management from 342ebb73b9 to 3860ec51f2 2025-12-16 15:17:29 +01:00 Compare

moritz force-pushed feature/279_cycle_management from 3860ec51f2 to 017ee5bc0c 2025-12-18 15:01:13 +01:00 Compare

moritz merged commit b6bc182510 into main 2025-12-18 15:01:58 +01:00

moritz deleted branch feature/279_cycle_management 2025-12-18 15:01:59 +01:00

moritz referenced this pull request from a commit 2025-12-18 15:02:00 +01:00

Merge pull request 'Cycle Management & Member Integration closes #279' (#294) from feature/279_cycle_management into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

high priority

  

invalid

Something is wrong

  

L

5 h

  

low priority

  

M

3 h

  

medium priority

  

needs refinement

  

optional

  

question

More information is needed

  

S

1 h

  

UX research

  

wontfix

This won't be fixed

No labels

bug

duplicate

enhancement

help wanted

high priority

invalid

L

low priority

M

medium priority

needs refinement

optional

question

S

UX research

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

moritz

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Depends on

#291 Membership Fee Type Resource & Settings closes #278

local-it/mitgliederverwaltung

Reference: local-it/mitgliederverwaltung#294

No description provided.