local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 68 Pull requests 8 Projects 1 Releases Packages 1 Activity Actions

Fix hidden empty custom fields closes #282 #313

Merged
carla merged 7 commits from bugfix/228_hidden_empty_custom_field_ into main 2025-12-23 18:24:19 +01:00
Conversation 0 Commits 7 Files changed 7 +273 -38
carla commented 2025-12-23 16:19:35 +01:00
Owner
Copy link

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

What has been changed?

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues

Additional Notes

## Description of the implemented changes The changes were: - [x] Bugfixing - [ ] New Feature - [ ] Breaking Change - [ ] Refactoring <!--- Describe the goal of the PR in a few words --> ## What has been changed? <!--- List the things you changed --> ## Definition of Done ### Code Quality - [x] No new technical depths - [x] Linting passed - [ ] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [ ] Tests for new code are written - [x] All tests pass - [ ] axe-core dev tools show no critical or major issues ## Additional Notes <!--- Add any additional information for the reviewers here -->
carla added 2 commits 2025-12-23 16:19:37 +01:00
fix: show custom field input fields also when empty
All checks were successful
continuous-integration/drone/push Build is passing
Details
5718a37aca
carla added 3 commits 2025-12-23 17:11:02 +01:00
feat: add accessible empty value also to member fields
Some checks failed
continuous-integration/drone/push Build is failing
Details
33652265b8
carla added 1 commit 2025-12-23 18:15:06 +01:00
fix linting errors
Some checks failed
continuous-integration/drone/push Build is failing
Details
3cf8244cd6
carla added 1 commit 2025-12-23 18:21:26 +01:00
fix tests
All checks were successful
continuous-integration/drone/push Build is passing
Details
f87e6d3e1d
carla merged commit e9b99e6749 into main 2025-12-23 18:24:19 +01:00
carla deleted branch bugfix/228_hidden_empty_custom_field_ 2025-12-23 18:24:20 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
high priority

   
invalid

Something is wrong

  
L

5 h

  
low priority

   
M

3 h

  
medium priority

   
needs refinement

   
optional

   
question

More information is needed

  
S

1 h

  
UX research

   
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
optional
question
S
UX research
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: local-it/mitgliederverwaltung#313
No description provided.
Delete branch "bugfix/228_hidden_empty_custom_field_"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?