Split the filter-builder component #641
Labels
No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
optional
question
S
security
technical improvement
UX Improvement
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
local-it/mitgliederverwaltung#641
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Motivation
lib/mv_web/components/add_filter_builder_component.exhas 1,775 lines and bundles four concerns: the field picker, sevenrender_value_control/1clauses, the chip catalog and the dispatch layer. The #548 review was deferred wholesale; this issue takes the part that still applies onmainc3d99735.The
date_filterswhole-map race (#548 ) is a correctness bug and goes to #549 (comment drafted ingitea-comments.md); the microcopy items are inissue-i18n-catalog-hygiene.md.Findings still open
FilterValueControlsandFilterChipsasindex/submodules;render/1(~230 lines) shrinks accordingly.test/mv_web/live/member_live/index_groups_filter_test.exs:5still name the removedMemberFilterComponent;index.ex's moduledoc message and URL-parameter lists omit what #548 added;export_payload.ex's moduledoc overclaims.period_tooltip/1clauses 1 and 3 identical (payment_aging.ex:291-305); option ordering defined twice (render/1vspicker_options/1);:exit_datedescriptor duplicates:active_former(editing an "Exited: …" chip opens "Filter: Active / former");scope_tooltip/3called twice per header cell. Re-verify each before changing.suspended_count/2(payment_aging.ex:417) has no caller;__paymentstill sent inindex_value_control_test.exs:275,456;handle_info({:reset_all_filters, …})(index.ex:334) unreachable; four unreferenceddata-testids (date-resolvedis the only handle on the local-format echo, so give that echo a real test).aria-haspopup="listbox"(line 155) while opening arole="dialog"; the match-count live region is inserted already filled (:if={@open_picker});role="option"buttons plusaria-activedescendantput every option in the Tab order (U7's<.combobox>may solve this); the payment scope badge mountsPopoverTooltipon a non-focusable<span>.index_payment_wiring_test.exscases are subsumed by the §2.9 property test;build_query_params/1threads six rebinds instead of a pipeline.Acceptance criteria
component_event_targets_test.exsgreen).