Split the filter builder, unify its controls and export columns in table order closes #641 #647

Merged
simon merged 21 commits from issue/mitgliederverwaltung-641 into main 2026-11-09 12:43:34 +01:00
Owner

closes #641

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

Member overview filters: the filter builder is split into small modules, and every filter now behaves the same way, opening, applying and staying in place while you choose.

What has been changed?

  • Check that every filter-builder binding reaches the builder
  • Drop unreachable filter paths and helpers nothing calls
  • Pin the local-format range echo and drop wiring cases the payment property covers
  • Describe the filter builder and its URL parameters as they work today
  • Build the filter chips in a pure module
  • Derive the filter-builder messages in a pure module
  • Render the filter value controls as function components
  • Offer the exit date under one membership status filter the picker also finds by exit date
  • Call the filter row's reset button Clear filters instead of Clear all
  • Wrap many options into joined rows of one radio group and let rows fill the width
  • Pick the contribution period from whole calendar phrases like Last quarter
  • Return focus to the edited filter chip when its control closes
  • Give named popovers a role so screen readers announce their name
  • Export the columns in the order of the member table
  • Render the open value control from one place
  • Keep a filter's control open and in place while its values apply
  • Return only the parent messages from the filter dispatch
  • Pin that every filter choice keeps its control open and in place
  • Keep the chip row in place while a filter control is open, new values as chips of their own
  • Record the membership status filter, period phrases, steady filter controls and table-ordered export under Unreleased

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues

Additional Notes

  • Follows up the deferred #548 review. Eight of the issue's points were already done on main (all four accessibility items, option order, scope tooltip, build_query_params); the rest is here.
  • add_filter_builder_component.ex shrinks from 1,710 to about 590 lines. Logic moves to MemberLive.Index.FilterChips and FilterDispatch (pure, the dispatch returns the parent messages and the component sends them) and the markup to FilterValueControls (function components). component_event_targets_test.exs now opens every filter control on /members and fails on any binding that misses the component.
  • Larger commits: ad8432ec, 40a47a54, af1eaf09 (the three extractions, mostly moved code), baeecfc5 (period phrases, incl. gettext), 7e32a420 (export column order, incl. regenerated golden CSV fixtures), f0c7ed12 (membership status, incl. gettext), 61ad485e (stable chip row while a filter control is open).
  • Behaviour changes a reviewer may not expect: the "Exit date" picker entry is gone (the membership status filter holds the exit period and is found by "exit"/"former"); filter controls no longer close after a preset or a single choice; while a control is open, new chips line up behind the chip it hangs from and the row sorts on close; CSV/PDF columns follow the table order (address right after name and email), which changes the column positions of existing exports.
  • <.segmented> gains per_row and fill (DESIGN_GUIDELINES §5.2); <.popover> gains role (a named panel is a group, focus-taking panels pass dialog). The sidebar flyout keeps no role (navigation rule §21.2) and names its list instead.
  • The export payload no longer carries the unused column_order; the server keeps the payload's column order. Payloads from pages opened before the update still export (fee status appended).
  • Known and not part of this PR: at 320 px the overview is 1 px too wide and the wide filter panel clips "Suspended" (both on main already). The known date_filters race stays for #549.
  • The branch contains one merge of main (deps bundle #643).
closes #641 ## Description of the implemented changes The changes were: - [x] Bugfixing - [x] New Feature - [ ] Breaking Change - [x] Refactoring Member overview filters: the filter builder is split into small modules, and every filter now behaves the same way, opening, applying and staying in place while you choose. ## What has been changed? - Check that every filter-builder binding reaches the builder - Drop unreachable filter paths and helpers nothing calls - Pin the local-format range echo and drop wiring cases the payment property covers - Describe the filter builder and its URL parameters as they work today - Build the filter chips in a pure module - Derive the filter-builder messages in a pure module - Render the filter value controls as function components - Offer the exit date under one membership status filter the picker also finds by exit date - Call the filter row's reset button Clear filters instead of Clear all - Wrap many options into joined rows of one radio group and let rows fill the width - Pick the contribution period from whole calendar phrases like Last quarter - Return focus to the edited filter chip when its control closes - Give named popovers a role so screen readers announce their name - Export the columns in the order of the member table - Render the open value control from one place - Keep a filter's control open and in place while its values apply - Return only the parent messages from the filter dispatch - Pin that every filter choice keeps its control open and in place - Keep the chip row in place while a filter control is open, new values as chips of their own - Record the membership status filter, period phrases, steady filter controls and table-ordered export under Unreleased ## Definition of Done ### Code Quality - [ ] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [ ] axe-core dev tools show no critical or major issues ## Additional Notes - Follows up the deferred #548 review. Eight of the issue's points were already done on main (all four accessibility items, option order, scope tooltip, build_query_params); the rest is here. - `add_filter_builder_component.ex` shrinks from 1,710 to about 590 lines. Logic moves to `MemberLive.Index.FilterChips` and `FilterDispatch` (pure, the dispatch returns the parent messages and the component sends them) and the markup to `FilterValueControls` (function components). `component_event_targets_test.exs` now opens every filter control on `/members` and fails on any binding that misses the component. - Larger commits: ad8432ec, 40a47a54, af1eaf09 (the three extractions, mostly moved code), baeecfc5 (period phrases, incl. gettext), 7e32a420 (export column order, incl. regenerated golden CSV fixtures), f0c7ed12 (membership status, incl. gettext), 61ad485e (stable chip row while a filter control is open). - Behaviour changes a reviewer may not expect: the "Exit date" picker entry is gone (the membership status filter holds the exit period and is found by "exit"/"former"); filter controls no longer close after a preset or a single choice; while a control is open, new chips line up behind the chip it hangs from and the row sorts on close; CSV/PDF columns follow the table order (address right after name and email), which changes the column positions of existing exports. - `<.segmented>` gains `per_row` and `fill` (DESIGN_GUIDELINES §5.2); `<.popover>` gains `role` (a named panel is a `group`, focus-taking panels pass `dialog`). The sidebar flyout keeps no role (navigation rule §21.2) and names its list instead. - The export payload no longer carries the unused `column_order`; the server keeps the payload's column order. Payloads from pages opened before the update still export (fee status appended). - Known and not part of this PR: at 320 px the overview is 1 px too wide and the wide filter panel clips "Suspended" (both on main already). The known `date_filters` race stays for #549. - The branch contains one merge of main (deps bundle #643).
docs(changelog): record the membership status filter, period phrases, steady filter controls and table-ordered export under Unreleased
All checks were successful
continuous-integration/drone/push Build is passing
continuous-integration/drone/promote/production Build is passing
e502524d8d
simon merged commit 1199d38a2c into main 2026-11-09 12:43:34 +01:00
simon deleted branch issue/mitgliederverwaltung-641 2026-11-09 12:43:34 +01:00
Sign in to join this conversation.
No description provided.