Treat exit date as last day of membership; clarify exit dialog #644

Closed
opened 2026-11-04 15:10:02 +01:00 by simon · 0 comments
Owner

Expected Behavior

The exit date is inclusive: it is the last day of membership (German club convention "Austritt zum 31.12.", §§ 39, 188 BGB). A member with exit date 2026-12-31 is active everywhere up to and including that day, and counts as a former member from 2027-01-01. The exit dialog states this and its consequences.

Current Behavior

  • Member list, export, the "Former" filter and the "active on X" filter treat the exit day as already left (exit_date > today). Fee cycles treat it as still active (>=).
  • Statistics count a member as inactive as soon as any exit date is set, even one in the future.
  • The dialog asks "When did this member leave?", although future dates are allowed. It does not say whether the chosen day still counts, or what happens to the member.
  • After a future exit date is set, the status says "This member is deactivated".

Possible Solution

  • Active on X: exit_date is nil or exit_date >= X; former: exit_date < X. Statistics use the same rule.
  • Rename "Deactivate member" to "Austritt eintragen" and "Reactivate member" to "Austritt zurücknehmen". The submit button gets neutral styling, because it can be undone.
  • Dialog question: "Zu welchem Datum endet die Mitgliedschaft?"
  • Date field "Austrittsdatum", with the hint "Das Mitglied bleibt bis einschließlich diesem Tag Mitglied."
  • A consequence hint that updates with the chosen date, e.g. "Ab 01.01.2027 nicht mehr in Mitgliederliste und Export, bleibt unter „Ehemalige“ erhalten. Beiträge bis einschließlich Periode 2026."
  • Status: "Austritt zum 31.12.2026 eingetragen" for future exits, "Ausgetreten zum 31.12.2026" for past exits.
  • Open: should the date default to today or to the end of the year?

Steps to Reproduce

  1. Set a member's exit date to today.
  2. Open the member list or export: the member is missing.
  3. Set the exit date to a future date instead.
  4. Open the statistics page: the member is counted as inactive.
## Expected Behavior The exit date is inclusive: it is the last day of membership (German club convention "Austritt zum 31.12.", §§ 39, 188 BGB). A member with exit date 2026-12-31 is active everywhere up to and including that day, and counts as a former member from 2027-01-01. The exit dialog states this and its consequences. ## Current Behavior - Member list, export, the "Former" filter and the "active on X" filter treat the exit day as already left (`exit_date > today`). Fee cycles treat it as still active (`>=`). - Statistics count a member as inactive as soon as any exit date is set, even one in the future. - The dialog asks "When did this member leave?", although future dates are allowed. It does not say whether the chosen day still counts, or what happens to the member. - After a future exit date is set, the status says "This member is deactivated". ## Possible Solution - Active on X: `exit_date is nil or exit_date >= X`; former: `exit_date < X`. Statistics use the same rule. - Rename "Deactivate member" to "Austritt eintragen" and "Reactivate member" to "Austritt zurücknehmen". The submit button gets neutral styling, because it can be undone. - Dialog question: "Zu welchem Datum endet die Mitgliedschaft?" - Date field "Austrittsdatum", with the hint "Das Mitglied bleibt bis einschließlich diesem Tag Mitglied." - A consequence hint that updates with the chosen date, e.g. "Ab 01.01.2027 nicht mehr in Mitgliederliste und Export, bleibt unter „Ehemalige“ erhalten. Beiträge bis einschließlich Periode 2026." - Status: "Austritt zum 31.12.2026 eingetragen" for future exits, "Ausgetreten zum 31.12.2026" for past exits. - Open: should the date default to today or to the end of the year? ## Steps to Reproduce 1. Set a member's exit date to today. 2. Open the member list or export: the member is missing. 3. Set the exit date to a future date instead. 4. Open the statistics page: the member is counted as inactive.
simon closed this issue 2026-11-13 11:00:34 +01:00
Sign in to join this conversation.
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
local-it/mitgliederverwaltung#644
No description provided.