Treat the exit date as the last day of membership and clarify the exit dialog closes #644 #662

Merged
simon merged 20 commits from issue/mitgliederverwaltung-644 into main 2026-11-13 11:00:33 +01:00
Owner

closes #644

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

Exit date and exit dialog: a member stays in the member list, the export, the "Active" filter and the statistics up to and including their exit date and counts as former from the next day, and the exit dialog on the member page asks for the last day of membership, offers "Today" and "End of year" and shows what the chosen date means for list, export and fees.

What has been changed?

  • Count the exit date as the last day of membership
  • Drop overview filter tests the active/former suite already covers
  • Count active and former members by the member list rule
  • Ask for the last day of membership when recording an exit
  • Keep reversible dialog confirmations primary
  • Describe the exit date as the last day of membership

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues

Additional Notes

  • The rule "member on day X" now lives once as calculations on Mv.Membership.Member (active_on, not_left_by, left_before); the overview, export, as-of filter and statistics use them.
  • Existing exit dates are not migrated; the changelog tells admins who entered the day after the last day of membership to correct it.
  • Statistics no longer count members without a join date as active ("active on today" requires a join date up to today).
  • "Deactivate/Reactivate member" become "Record exit" and "Withdraw exit"; DeactivateComponent is renamed to ExitComponent. The confirm button is primary instead of red, recorded in DESIGN_GUIDELINES §5.
  • Larger commits: "Count the exit date as the last day of membership" (12 files, +212/−63), "Count active and former members by the member list rule" (8 files), "Ask for the last day of membership when recording an exit" (12 files, +1155/−528, mostly gettext catalogs and the renamed component and its test).
  • Pre-branch tests in date_filter_default_test.exs and date_filter_test.exs were removed because the active/former suite covers the same URLs with stronger assertions.
closes #644 ## Description of the implemented changes The changes were: - [x] Bugfixing - [x] New Feature - [ ] Breaking Change - [ ] Refactoring Exit date and exit dialog: a member stays in the member list, the export, the "Active" filter and the statistics up to and including their exit date and counts as former from the next day, and the exit dialog on the member page asks for the last day of membership, offers "Today" and "End of year" and shows what the chosen date means for list, export and fees. ## What has been changed? - Count the exit date as the last day of membership - Drop overview filter tests the active/former suite already covers - Count active and former members by the member list rule - Ask for the last day of membership when recording an exit - Keep reversible dialog confirmations primary - Describe the exit date as the last day of membership ## Definition of Done ### Code Quality - [ ] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [ ] axe-core dev tools show no critical or major issues ## Additional Notes - The rule "member on day X" now lives once as calculations on `Mv.Membership.Member` (`active_on`, `not_left_by`, `left_before`); the overview, export, as-of filter and statistics use them. - Existing exit dates are not migrated; the changelog tells admins who entered the day after the last day of membership to correct it. - Statistics no longer count members without a join date as active ("active on today" requires a join date up to today). - "Deactivate/Reactivate member" become "Record exit" and "Withdraw exit"; `DeactivateComponent` is renamed to `ExitComponent`. The confirm button is primary instead of red, recorded in DESIGN_GUIDELINES §5. - Larger commits: "Count the exit date as the last day of membership" (12 files, +212/−63), "Count active and former members by the member list rule" (8 files), "Ask for the last day of membership when recording an exit" (12 files, +1155/−528, mostly gettext catalogs and the renamed component and its test). - Pre-branch tests in `date_filter_default_test.exs` and `date_filter_test.exs` were removed because the active/former suite covers the same URLs with stronger assertions.
test(member-overview): drop Former and All URL tests the active/former suite already covers
All checks were successful
continuous-integration/drone/push Build is passing
continuous-integration/drone/promote/production Build is passing
2b10c71b08
simon merged commit 7f71b1c9b2 into main 2026-11-13 11:00:33 +01:00
simon deleted branch issue/mitgliederverwaltung-644 2026-11-13 11:00:34 +01:00
Sign in to join this conversation.
No description provided.