Gate function size, module coupling and duplication with a Credo ratchet closes #541 #677
No reviewers
Labels
No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
optional
question
S
security
technical improvement
UX Improvement
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
local-it/mitgliederverwaltung!677
Loading…
Reference in a new issue
No description provided.
Delete branch "issue/mitgliederverwaltung-541"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
closes #541
Description of the implemented changes
The changes were:
Code quality: CI now fails when a function grows too complex, a module depends on too many others or code is duplicated, with limits that only move down.
What has been changed?
Definition of Done
Code Quality
Accessibility
Testing
Additional Notes
lib/anddev/only. The issue suggested today's maximum or about 20 dependencies; measured onmain, today's maximum is 75/55 and 20 would flag most Ash resources, so the first step is 40/25 with the remaining excess marked. Later steps (ABC 35 → 30, dependencies 20 → 15, mass 35) are in the comment block in.credo.exs.# Ratchet (debt|flat|hub): <reason>and# credo:disable-for-next-line <check>directly above itsdefordefmodule(12 functions, 6 modules).test/mv/architecture/credo_ratchet_test.exspins the limits and the exact marker list, so a raised limit, a new marker or a file-wide disable fails CI.main.SpecsandVariableRebindingstay disabled, now with a reason in.credo.exs.