[FEATURE]: Edit member and account data per section #678

Open
opened 2026-11-13 16:15:16 +01:00 by simon · 0 comments
Owner

Description

Today the member page has one "Edit member" action that opens a single form for personal data, individual data fields and the membership fee. For members in self-service this button sits in the page header on "My data" (#665), far from the data it changes. The form also shows more than the member expected to change. The account page ("Sign-in & security") has no way for a member to change their own password: the only password form is the admin form, which does not ask for the current password and addresses "this user".

The design guidelines already plan for this: actions belong to the section they act on (§16.1), and member and user get per-section editing (§5, outlook).

Proposal

  • The detail page is also the edit view. Each editable section has "Edit" in its header (sm, soft primary). Clicking it turns only that section into a form, with "Cancel" and "Save" right-aligned in the section footer.
  • Exactly one section is open at a time, and the open section is clearly marked.
  • A section only offers "Edit" when the current user may change at least one field in it (field access from #664 and #669). Members and staff see the same sections in the same places. Only the frame around the page differs (#665).
  • The page-level "Edit member" action is removed. Creating a new member stays one form with one Save.
  • Account: "Password" becomes its own section on the account page.
    • A user changing their own password must enter the current password.
    • Admins setting someone else's password keep the existing admin path.
    • Role and member link are saved separately from the password.
  • /members/:id/edit and /users/:id/edit either redirect to the detail page or remain for staff. Decide this in the design round.

Open questions for the design round

  • What happens to unsaved changes when another section is opened or the page is left.
  • Focus after Save and after Cancel.
  • Update actions or accept lists per section, and their policies.
  • Whether a confirm-password field is needed. GOV.UK says it is not; use autocomplete="new-password" either way.
  • UX non-regression against the current one-form flow for staff (clicks, focus, information shown).
  • How change requests with board approval (#674) attach to a section's Save.

Acceptance criteria

  • Every editable section of the member page and the account page has its own "Edit" in the section header; the page header has no edit action.
  • Opening a section edits only that section; Save and Cancel are in its footer; only one section is open at a time.
  • A section without any field the current user may change shows no "Edit". A forged update of such a field is rejected.
  • A member can change their own password only after entering the current password; a wrong current password is rejected with a field error.
  • Changing a user's role and password in one visit persists both.
  • Creating a member is still one form.

Dependencies

  • #664 (member field access), #665 (self-service frame and account page), #669 (per-field member access).
  • Should land before #674 so change requests can hook into the per-section Save.
## Description Today the member page has one "Edit member" action that opens a single form for personal data, individual data fields and the membership fee. For members in self-service this button sits in the page header on "My data" (#665), far from the data it changes. The form also shows more than the member expected to change. The account page ("Sign-in & security") has no way for a member to change their own password: the only password form is the admin form, which does not ask for the current password and addresses "this user". The design guidelines already plan for this: actions belong to the section they act on (§16.1), and member and user get per-section editing (§5, outlook). ## Proposal - The detail page is also the edit view. Each editable section has "Edit" in its header (`sm`, soft primary). Clicking it turns only that section into a form, with "Cancel" and "Save" right-aligned in the section footer. - Exactly one section is open at a time, and the open section is clearly marked. - A section only offers "Edit" when the current user may change at least one field in it (field access from #664 and #669). Members and staff see the same sections in the same places. Only the frame around the page differs (#665). - The page-level "Edit member" action is removed. Creating a new member stays one form with one Save. - **Account:** "Password" becomes its own section on the account page. - A user changing their own password must enter the current password. - Admins setting someone else's password keep the existing admin path. - Role and member link are saved separately from the password. - `/members/:id/edit` and `/users/:id/edit` either redirect to the detail page or remain for staff. Decide this in the design round. ## Open questions for the design round - What happens to unsaved changes when another section is opened or the page is left. - Focus after Save and after Cancel. - Update actions or accept lists per section, and their policies. - Whether a confirm-password field is needed. GOV.UK says it is not; use `autocomplete="new-password"` either way. - UX non-regression against the current one-form flow for staff (clicks, focus, information shown). - How change requests with board approval (#674) attach to a section's Save. ## Acceptance criteria - [ ] Every editable section of the member page and the account page has its own "Edit" in the section header; the page header has no edit action. - [ ] Opening a section edits only that section; Save and Cancel are in its footer; only one section is open at a time. - [ ] A section without any field the current user may change shows no "Edit". A forged update of such a field is rejected. - [ ] A member can change their own password only after entering the current password; a wrong current password is rejected with a field error. - [ ] Changing a user's role and password in one visit persists both. - [ ] Creating a member is still one form. ## Dependencies - #664 (member field access), #665 (self-service frame and account page), #669 (per-field member access). - Should land before #674 so change requests can hook into the per-section Save.
Sign in to join this conversation.
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
local-it/mitgliederverwaltung#678
No description provided.