Limit password reset requests #681

Closed
opened 2026-11-13 16:48:00 +01:00 by simon · 0 comments
Owner

Current Behavior

The password reset request (/reset, POST /auth/user/password/reset_request) needs no sign-in and has no rate limit. Every request for a known address sends one reset mail through the club's SMTP account. A script can flood a member's mailbox and get the club's SMTP account rate-limited or blocklisted. The only limiter in the app covers the join form (MvWeb.JoinRateLimit).

Expected Behavior

Reset requests are limited per client IP and per e-mail address (Hammer, like the join form). A limited request looks the same to the requester as an accepted one, so the limit does not reveal whether an address exists.

Notes

  • Decide what a limited requester sees (same confirmation as today vs. a "try again later" message).
  • Same for the sign-in form (password guessing) if not covered elsewhere.
  • Checked on main 2d44acbe: still no limiter outside the join form.

Dependencies

  • Before #672: invitations reuse the reset token and mail path, so the limit must cover invitation mails too. #678 (own password change) does not send mails but should use the same limiter for wrong current-password attempts.
## Current Behavior The password reset request (`/reset`, POST `/auth/user/password/reset_request`) needs no sign-in and has no rate limit. Every request for a known address sends one reset mail through the club's SMTP account. A script can flood a member's mailbox and get the club's SMTP account rate-limited or blocklisted. The only limiter in the app covers the join form (`MvWeb.JoinRateLimit`). ## Expected Behavior Reset requests are limited per client IP and per e-mail address (Hammer, like the join form). A limited request looks the same to the requester as an accepted one, so the limit does not reveal whether an address exists. ## Notes - Decide what a limited requester sees (same confirmation as today vs. a "try again later" message). - Same for the sign-in form (password guessing) if not covered elsewhere. - Checked on main 2d44acbe: still no limiter outside the join form. ## Dependencies - Before #672: invitations reuse the reset token and mail path, so the limit must cover invitation mails too. #678 (own password change) does not send mails but should use the same limiter for wrong current-password attempts.
simon closed this issue 2026-11-14 14:03:15 +01:00
Sign in to join this conversation.
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
local-it/mitgliederverwaltung#681
No description provided.