Limit password reset requests and sign-in attempts closes #681 #687
No reviewers
Labels
No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
optional
question
S
security
technical improvement
UX Improvement
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
local-it/mitgliederverwaltung!687
Loading…
Reference in a new issue
No description provided.
Delete branch "issue/mitgliederverwaltung-681"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
closes #681
Description of the implemented changes
The changes were:
Sign-in security: password reset mails and password sign-in attempts are limited, and the reset page gives the same answer for every address.
What has been changed?
Definition of Done
Code Quality
Accessibility
Testing
Additional Notes
Mv.Accounts.AuthRateLimit(Hammer, ETS, sliding window) and theLimitAuthAttemptspreparation; "Limit password sign-in attempts per client IP and address" (8 files, +316); "Confirm a password reset request on the page in plain words" (10 files, +250, incl. translations); "Key client IP on the proxy-appended X-Forwarded-For entry" (+158).Mv.TaskSupervisor; the action itself always returns "no user", so known, unknown and limited addresses look the same from outside, including the response time.Mv.Accounts.AuthRateLimit;config :mv, :auth_rate_limit, <bucket>: [scale_ms:, limit:]overrides one.X-Real-IPor the lastX-Forwarded-Forentry. The proxy must append toX-Forwarded-For(or setX-Real-IP), otherwise all clients share the proxy's budget. The/auth/*HTTP routes only seeX-Forwarded-For./sign-in,/registerand/resetnow follow their heading;/registerwas titled "Sign in".