Let the board role decide join requests closes #667 #690
No reviewers
Labels
No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
optional
question
S
security
technical improvement
UX Improvement
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
local-it/mitgliederverwaltung!690
Loading…
Reference in a new issue
No description provided.
Delete branch "issue/mitgliederverwaltung-667"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
closes #667
Description of the implemented changes
The changes were:
The board reviews and decides join requests without getting the right to edit members: a new permission set
read_and_admit(read likeread_only, plus reading and deciding join requests), given to the seeded role "Vorstand" on existing and new installations. Roles onread_onlyandread_and_admitalso change the contact data of their own linked member, like members do.What has been changed?
Definition of Done
Code Quality
Accessibility
Testing
Additional Notes
JoinFlow.approve_join_request/2authorizes the reviewer's:approveby policy, then creates the member as the system actor in the same transaction. Deciding therefore needs no Member create permission. CODE_GUIDELINES §3.5 lists this as a legitimate system-actor use. A test fails if the member is created with the reviewer as actor.valuesare now limited to the required fields the request lacks. Before, a reviewer could set any member field through forged values (e.g. join date, notes, other data fields). Domain test with forged values.read_and_admit: direct writes to members, custom field values, fee types and cycles, and groups are refused and change nothing.approve/rejectbyread_only,own_dataor no actor are refused, the request stays undecided and no member is created.read_onlyandread_and_admitnow holdMember :update :linked, which reaches only:update_contact_data.CheckPagePermissionopens/members/:id/editfor any member only when the actor has Member update:all(FieldAccess.full_access?/1), otherwise only the own linked member. Before, the check was by theown_dataset name. Forged tests cover another member's id, board-only fields and an unlinked user. In the contact-only form, the read-only sections tell board and accounting users "You cannot change this here." instead of "Only the board can change this.". The leave hint stays for members.20261114120000_board_role_decides_join_requests: the role named "Vorstand" onread_onlymoves toread_and_admit. The description changes only while it is the seeded text. Other roles are untouched. Rollback restoresread_only. Seeds match. The role form lists the new set afterread_only.origin/main(#681) is merged in. The branch overlaps it only inrouter.exand gettext, with no conflict.Release: 1.6.0 (wave 1). The CHANGELOG has upgrade notes: the board role now sees and decides join requests including applicant data, and read-only roles may change their own contact data.
Proposed news entry (for the release file once #683 is merged):
read_only)