local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 51 Pull requests 13 Projects 1 Releases Packages 1 Activity Actions

create logical link between users and members closes #164 #172

Merged
moritz merged 14 commits from feature/user-member-relation into main 2025-10-16 16:29:49 +02:00
Conversation 2 Commits 14 Files changed 27 +2057 -245
moritz commented 2025-09-26 19:40:51 +02:00
Owner
Copy link

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

#164

What has been changed?

  • create a optional relation between users and members
  • View: show linked user or member in member detail view and user detail view (but keep it simple!), if those resources are linked

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues

Additional Notes

## Description of the implemented changes The changes were: - [ ] Bugfixing - [x] New Feature - [ ] Breaking Change - [ ] Refactoring https://git.local-it.org/local-it/mitgliederverwaltung/issues/164 ## What has been changed? - create a optional relation between users and members - View: show linked user or member in member detail view and user detail view (but keep it simple!), if those resources are linked ## Definition of Done ### Code Quality - [x] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [x] axe-core dev tools show no critical or major issues ## Additional Notes
moritz added this to the Accounts & Logins milestone 2025-09-26 19:40:51 +02:00
moritz self-assigned this 2025-09-26 19:40:51 +02:00
moritz added 2 commits 2025-09-26 19:40:52 +02:00
moritz added this to the Sprint 6 - 11.09 - 02.10. project 2025-09-26 19:40:53 +02:00
moritz force-pushed feature/user-member-relation from 37c948c91a to 84abe0a4b5 2025-09-26 19:57:22 +02:00 Compare
moritz force-pushed feature/user-member-relation from 84abe0a4b5 to cf364fc30e 2025-09-26 20:09:05 +02:00 Compare
moritz force-pushed feature/user-member-relation from cf364fc30e to e0d7de4712 2025-09-26 20:12:10 +02:00 Compare
moritz added 1 commit 2025-09-26 20:18:46 +02:00
moritz added 1 commit 2025-09-26 20:33:23 +02:00
moritz changed title from WIP: create logical link between users and members closes #164 to create logical link between users and members closes #164 2025-09-26 20:33:46 +02:00
requested reviews from simon, carla, rafael 2025-09-26 20:34:05 +02:00
moritz force-pushed feature/user-member-relation from 380382ea13 to b5c97fdecd 2025-09-26 20:34:52 +02:00 Compare
moritz added 1 commit 2025-09-26 20:49:06 +02:00
test ci
Some checks reported errors
continuous-integration/drone/push Build was killed
Details
dfc8881dba
moritz force-pushed feature/user-member-relation from dfc8881dba to b5c97fdecd 2025-09-26 20:49:43 +02:00 Compare
moritz force-pushed feature/user-member-relation from b5c97fdecd to bdc7b95d17 2025-09-30 14:29:28 +02:00 Compare
moritz added 1 commit 2025-09-30 14:50:41 +02:00
fix: security update ash 3.5.43 to 3.5.34
All checks were successful
continuous-integration/drone/push Build is passing
Details
b497064c82
simon requested changes 2025-09-30 17:58:18 +02:00
simon left a comment
Owner
Copy link

Looks solid to me! Left a few comments.

Also asked chatgpt for a review, leaving it here as I found some remarks interesting, without demanding an actual change now:

https://pad.local-it.org/D_bHD409R1WqPeeB5KD_2w?view

Looks solid to me! Left a few comments. Also asked chatgpt for a review, leaving it here as I found some remarks interesting, without demanding an actual change now: https://pad.local-it.org/D_bHD409R1WqPeeB5KD_2w?view
lib/accounts/user.ex Outdated
@ -128,0 +182,4 @@
if member_arg && member_arg[:id] && current_member_id &&
member_arg[:id] != current_member_id do
{:error,
field: :member, message: "User already has a member. Remove existing member first."}
simon commented 2025-09-30 17:44:09 +02:00
Owner
Copy link

For translation reasons, gettext should be used for all those error messages

For translation reasons, gettext should be used for all those error messages
moritz commented 2025-10-16 13:56:39 +02:00
Author
Owner
Copy link

These messages are translated by ash. Only the translation text was missing.

These messages are translated by ash. Only the translation text was missing.
moritz marked this conversation as resolved
priv/gettext/de/LC_MESSAGES/auth.po Outdated
@ -63,4 +63,1 @@
msgstr "Das Passwort wurde erfolgreich zurückgesetzt"
msgid "Sign in with Rauthy"
msgstr "Anmelden mit der Vereinscloud"
simon commented 2025-09-30 10:40:13 +02:00
Owner
Copy link

Is this deletion intentional?

Is this deletion intentional?
moritz commented 2025-10-16 14:27:02 +02:00
Author
Owner
Copy link

yes it was removed by the gettext command, because there is no string to be translated. The login page is another issue anyway.

yes it was removed by the gettext command, because there is no string to be translated. The login page is another issue anyway.
moritz marked this conversation as resolved
priv/gettext/de/LC_MESSAGES/default.po Outdated
@ -560,0 +561,4 @@
#: lib/mv_web/live/member_live/show.ex:41
#, elixir-autogen, elixir-format
msgid "Linked User"
msgstr "Verknüpfter Benutzer"
simon commented 2025-09-30 10:44:52 +02:00
Owner
Copy link

See our agreement on using gender-sensitive language.
But is still unclear whether e.g. Benutzer*in or Benutzer:in - see issue on our agenda for thursday

See our agreement on using gender-sensitive language. But is still unclear whether e.g. Benutzer*in or Benutzer:in - see issue on our agenda for thursday
moritz marked this conversation as resolved
carla modified the project from Sprint 6 - 11.09 - 02.10. to Sprint 7 - 02.10 - 23.10. 2025-10-02 12:55:30 +02:00
rafael approved these changes 2025-10-13 17:48:27 +02:00
rafael left a comment
Collaborator
Copy link

Looks great! I've clicked around the UI as well and everything seems to work fine.

Looks great! I've clicked around the UI as well and everything seems to work fine.
lib/accounts/user.ex Outdated
@ -61,3 +61,3 @@
actions do
defaults [:read, :create, :destroy, :update]
defaults [:read, :create, :destroy]
rafael commented 2025-10-13 17:01:57 +02:00
Collaborator
Copy link

Should we remove the :create here as well, in favor of the :create_user action?

Should we remove the `:create` here as well, in favor of the `:create_user` action?
moritz commented 2025-10-16 14:56:00 +02:00
Author
Owner
Copy link

Used by AshAdmin's generated "Create" UI and by generic AshPhoenix helpers that assume a default create action.

Used by AshAdmin's generated "Create" UI and by generic AshPhoenix helpers that assume a default create action.
moritz marked this conversation as resolved
lib/accounts/user.ex Outdated
@ -63,1 +63,3 @@
defaults [:read, :create, :destroy, :update]
defaults [:read, :create, :destroy]
update :update do
rafael commented 2025-10-13 17:01:34 +02:00
Collaborator
Copy link

Are we still using this? If so, can you add a comment explaining the difference to the :update_user action?

Are we still using this? If so, can you add a comment explaining the difference to the `:update_user` action?
moritz commented 2025-10-16 14:56:32 +02:00
Author
Owner
Copy link

Selected by AshAdmin's generated "Edit" UI and generic AshPhoenix helpers that assume a default update action.

Selected by AshAdmin's generated "Edit" UI and generic AshPhoenix helpers that assume a default update action.
moritz marked this conversation as resolved
lib/accounts/user.ex Outdated
@ -76,6 +115,7 @@ defmodule Mv.Accounts.User do
update :admin_set_password do
accept [:email]
argument :password, :string, allow_nil?: false, sensitive?: true
require_atomic? false
rafael commented 2025-10-13 17:02:58 +02:00
Collaborator
Copy link

Should we add this comment here as well?

      # Required because custom validation function cannot be done atomically
Should we add this comment here as well? ```elixir # Required because custom validation function cannot be done atomically ```
moritz marked this conversation as resolved
moritz force-pushed feature/user-member-relation from b497064c82 to 4699386d87 2025-10-16 12:08:39 +02:00 Compare
moritz force-pushed feature/user-member-relation from 4699386d87 to 908517641b 2025-10-16 12:31:16 +02:00 Compare
moritz added 6 commits 2025-10-16 15:29:29 +02:00
add tests for member deletion
All checks were successful
continuous-integration/drone/push Build is passing
Details
045ae1c3c7
moritz merged commit c116e39b56 into main 2025-10-16 16:29:49 +02:00
moritz deleted branch feature/user-member-relation 2025-10-16 16:29:50 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
carla
simon
rafael
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
high priority

   
invalid

Something is wrong

  
L

5 h

  
low priority

   
M

3 h

  
medium priority

   
needs refinement

   
question

More information is needed

  
S

1 h

  
UX research

   
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
question
S
UX research
wontfix
Milestone
Clear milestone
No items
No milestone
Accounts & Logins
Projects
Clear projects
No items
No project
Sprint 7 - 02.10 - 23.10.
Assignees
Clear assignees
No assignees
moritz
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: local-it/mitgliederverwaltung#172
No description provided.
Delete branch "feature/user-member-relation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?