local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 51 Pull requests 13 Projects 1 Releases Packages 1 Activity Actions

Custom Fields: Add slugs closes #195 #205

Merged
moritz merged 3 commits from feature/custom-field-slug into main 2025-11-20 14:27:58 +01:00
Conversation 1 Commits 3 Files changed 13 +788 -40
moritz commented 2025-11-13 19:19:18 +01:00
Owner
Copy link

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues
## Description of the implemented changes The changes were: - [ ] Bugfixing - [x] New Feature - [ ] Breaking Change - [ ] Refactoring [<!--- Describe the goal of the PR in a few words -->](https://git.local-it.org/local-it/mitgliederverwaltung/issues/195) ## Definition of Done ### Code Quality - [x] No new technical depths - [ ] Linting passed - [x] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [ ] axe-core dev tools show no critical or major issues
moritz self-assigned this 2025-11-13 19:19:19 +01:00
moritz added 6 commits 2025-11-13 19:19:20 +01:00
refactor: Rename Property/PropertyType to CustomFieldValue/CustomField
All checks were successful
continuous-integration/drone/push Build is passing
Details
8400e727a7 
Complete refactoring of resources, database tables, code references, tests, and documentation for improved naming consistency.
fix: Allow optional email values in custom fields
All checks were successful
continuous-integration/drone/push Build is passing
Details
2b3c94d3b2
feat: Add Custom Fields link to navbar
All checks were successful
continuous-integration/drone/push Build is passing
Details
158ac52d97
feat: add custom field slug
All checks were successful
continuous-integration/drone/push Build is passing
Details
0135dafa3a
requested reviews from simon, carla 2025-11-13 19:19:38 +01:00
carla added 1 commit 2025-11-18 08:52:09 +01:00
Merge branch 'main' into feature/custom-field-slug
All checks were successful
continuous-integration/drone/push Build is passing
Details
4cf493cd03
carla requested changes 2025-11-18 09:06:06 +01:00
carla left a comment
Owner
Copy link

Overall great work !! 💯
Just the question about showing the slug to the user, I think it might be more confusing for them.

Overall great work !! 💯 Just the question about showing the slug to the user, I think it might be more confusing for them.
lib/mv_web/live/custom_field_live/form.ex Outdated
@ -51,0 +54,4 @@
<%!-- Show slug in edit mode (read-only) --%>
<div :if={@custom_field} class="mb-4">
<label class="block text-sm font-semibold leading-6 text-zinc-800">
carla commented 2025-11-18 09:02:52 +01:00
Owner
Copy link

I asked myself if we should hide that information from the user as it is rather a technical info?

I asked myself if we should hide that information from the user as it is rather a technical info?
moritz marked this conversation as resolved
lib/mv_web/live/custom_field_live/index.ex Outdated
@ -44,3 +45,3 @@
row_click={fn {_id, custom_field} -> JS.navigate(~p"/custom_fields/#{custom_field}") end}
>
<:col :let={{_id, custom_field}} label="Id">{custom_field.id}</:col>
<:col :let={{_id, custom_field}} label="Slug">{custom_field.slug}</:col>
carla commented 2025-11-18 09:03:12 +01:00
Owner
Copy link

Same as above

Same as above
moritz marked this conversation as resolved
lib/mv_web/live/custom_field_live/show.ex Outdated
@ -48,6 +50,8 @@ defmodule MvWeb.CustomFieldLive.Show do
<.list>
<:item title="Id">{@custom_field.id}</:item>
<:item title="Slug">{@custom_field.slug}</:item>
carla commented 2025-11-18 09:03:49 +01:00
Owner
Copy link

And here :)

And here :)
moritz commented 2025-11-20 14:14:21 +01:00
Author
Owner
Copy link

It's the bridge between technical details and admin information. It will be used for debugging, import/export and other purposes, where the id is not practical. Therefore I think there should be places where the admin can inspect the slug.

It's the bridge between technical details and admin information. It will be used for debugging, import/export and other purposes, where the id is not practical. Therefore I think there should be places where the admin can inspect the slug.
👍 1
moritz marked this conversation as resolved
moritz added 2 commits 2025-11-20 14:23:02 +01:00
feat: add translation
All checks were successful
continuous-integration/drone/push Build is passing
Details
038299140b
moritz force-pushed feature/custom-field-slug from 038299140b to efb3e1cc37 2025-11-20 14:25:44 +01:00 Compare
moritz merged commit 21ec86839a into main 2025-11-20 14:27:58 +01:00
moritz deleted branch feature/custom-field-slug 2025-11-20 14:28:00 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
simon
carla
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
high priority

   
invalid

Something is wrong

  
L

5 h

  
low priority

   
M

3 h

  
medium priority

   
needs refinement

   
question

More information is needed

  
S

1 h

  
UX research

   
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
question
S
UX research
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
moritz
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: local-it/mitgliederverwaltung#205
No description provided.
Delete branch "feature/custom-field-slug"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?