local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 51 Pull requests 13 Projects 1 Releases Packages 1 Activity Actions

Adds Global Settings closes #211 #219

Merged
carla merged 7 commits from feature/211_globalsettings into main 2025-12-01 10:57:06 +01:00
Conversation 1 Commits 7 Files changed 17 +822 -103
carla commented 2025-11-27 15:57:21 +01:00
Owner
Copy link

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

Add a settings ressource to give the user the possibility to set the name of the club.

What has been changed?

  • settings ressource has been added
  • GlobalSettings live view has been added
  • env.example has been updated with ASSOCIATION_NAME

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues

Additional Notes

## Description of the implemented changes The changes were: - [ ] Bugfixing - [x] New Feature - [ ] Breaking Change - [ ] Refactoring <!--- Describe the goal of the PR in a few words --> Add a settings ressource to give the user the possibility to set the name of the club. ## What has been changed? - settings ressource has been added - GlobalSettings live view has been added - env.example has been updated with ASSOCIATION_NAME ## Definition of Done ### Code Quality - [x] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [ ] axe-core dev tools show no critical or major issues ## Additional Notes <!--- Add any additional information for the reviewers here -->
carla added this to the As Admin I can configure settings globally milestone 2025-11-27 15:57:21 +01:00
carla added 6 commits 2025-11-27 15:57:22 +01:00
adds tests
Some checks failed
continuous-integration/drone/push Build is failing
Details
8503c085cb
chore: adds settings ressource and migration
Some checks failed
continuous-integration/drone/push Build is failing
Details
936ed0ace1
test updated
All checks were successful
continuous-integration/drone/push Build is passing
Details
2027c993b4
chore: updated env example
All checks were successful
continuous-integration/drone/push Build is passing
Details
8e33eea9de
carla added this to the Sprint 9: 20.11 - 11.12 project 2025-11-27 15:57:23 +01:00
carla changed title from WIP: Adds Global Settings closes #211 to Adds Global Settings closes #211 2025-11-27 15:57:49 +01:00
requested reviews from moritz, simon 2025-11-27 15:57:58 +01:00
moritz approved these changes 2025-11-27 19:22:21 +01:00
moritz left a comment
Owner
Copy link

🚀

🚀
priv/repo/seeds.exs Outdated
@ -326,0 +334,4 @@
Membership.update_settings(existing_settings, %{club_name: default_club_name})
end
{:ok, nil} ->
moritz commented 2025-11-27 19:17:54 +01:00
Owner
Copy link

I think this branch is never reached, because get_settings already creates settings as fallback?

I think this branch is never reached, because get_settings already creates settings as fallback?
carla marked this conversation as resolved
carla force-pushed feature/211_globalsettings from 8e33eea9de to dfdf4c980b 2025-12-01 10:43:57 +01:00 Compare
carla added 1 commit 2025-12-01 10:54:28 +01:00
fix: remove unused branch in seeds and fixed translations
All checks were successful
continuous-integration/drone/push Build is passing
Details
f9ff6d3d2d
carla merged commit e803dbdf8b into main 2025-12-01 10:57:06 +01:00
carla deleted branch feature/211_globalsettings 2025-12-01 10:57:07 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
simon
moritz
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
high priority

   
invalid

Something is wrong

  
L

5 h

  
low priority

   
M

3 h

  
medium priority

   
needs refinement

   
question

More information is needed

  
S

1 h

  
UX research

   
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
question
S
UX research
wontfix
Milestone
Clear milestone
No items
No milestone
As Admin I can configure settings globally
Projects
Clear projects
No items
No project
Sprint 9: 20.11 - 11.12
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: local-it/mitgliederverwaltung#219
No description provided.
Delete branch "feature/211_globalsettings"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?