local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 51 Pull requests 13 Projects 1 Releases Packages 1 Activity Actions

WIP: Persist member overview sort settings #228

Draft
rafael wants to merge 2 commits from persist-sort-order into main
pull from: persist-sort-order
merge into: local-it:main
Conversation 1 Commits 2 Files changed 3 +304 -207
rafael commented 2025-12-01 21:42:05 +01:00
Collaborator
Copy link

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

Fix #213

What has been changed?

  • Create a hook for saving the sort order in a cookie when an event from the liveview arrives
  • Read the cookies when mounting the liveview and set the sort order

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

No changes to HTML UI

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues

Additional Notes

## Description of the implemented changes The changes were: - [ ] Bugfixing - [x] New Feature - [ ] Breaking Change - [ ] Refactoring Fix #213 ## What has been changed? - Create a hook for saving the sort order in a cookie when an event from the liveview arrives - Read the cookies when mounting the liveview and set the sort order ## Definition of Done ### Code Quality - [x] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility No changes to HTML UI ### Testing - [ ] Tests for new code are written - [ ] All tests pass - [ ] axe-core dev tools show no critical or major issues ## Additional Notes <!--- Add any additional information for the reviewers here -->
rafael added 2 commits 2025-12-01 21:42:07 +01:00
Format member overview liveview
All checks were successful
continuous-integration/drone/push Build is passing
Details
2eb8834a11
rafael changed title from Persist member overview sort settings to WIP: Persist member overview sort settings 2025-12-02 09:44:08 +01:00
rafael commented 2025-12-02 09:44:38 +01:00
Author
Collaborator
Copy link

Missing:

  • Tests
  • Don't overwrite URL sort params from cookie, if the URL sort params are already set
Missing: - [ ] Tests - [ ] Don't overwrite URL sort params from cookie, if the URL sort params are already set
All checks were successful
continuous-integration/drone/push Build is passing
Details
This pull request has changes conflicting with the target branch.
  • lib/mv_web/live/member_live/index.ex
  • lib/mv_web/live/member_live/index.html.heex
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin persist-sort-order:persist-sort-order
git checkout persist-sort-order

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout main
git merge --no-ff persist-sort-order
git checkout persist-sort-order
git rebase main
git checkout main
git merge --ff-only persist-sort-order
git checkout persist-sort-order
git rebase main
git checkout main
git merge --no-ff persist-sort-order
git checkout main
git merge --squash persist-sort-order
git checkout main
git merge --ff-only persist-sort-order
git checkout main
git merge persist-sort-order
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
high priority

   
invalid

Something is wrong

  
L

5 h

  
low priority

   
M

3 h

  
medium priority

   
needs refinement

   
question

More information is needed

  
S

1 h

  
UX research

   
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
question
S
UX research
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: local-it/mitgliederverwaltung#228
No description provided.
Delete branch "persist-sort-order"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?