local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 51 Pull requests 13 Projects 1 Releases Packages 1 Activity Actions

Mark required fields in UI #235

Merged
moritz merged 1 commit from mark-required-fields into main 2025-12-02 15:26:12 +01:00
Conversation 1 Commits 1 Files changed 5 +142 -94
rafael commented 2025-12-02 11:38:40 +01:00
Collaborator
Copy link

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

Fix #224

What has been changed?

Add a small red asterisk with a tooltip to all required input fields.

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus (should the asterisk be focusable, because of the tooltip?)

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues
## Description of the implemented changes The changes were: - [ ] Bugfixing - [x] New Feature - [ ] Breaking Change - [ ] Refactoring Fix #224 ## What has been changed? Add a small red asterisk with a tooltip to all required input fields. ## Definition of Done ### Code Quality - [x] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility - [x] New elements are properly defined with html-tags - [x] Colour contrast follows WCAG criteria - [x] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [x] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus (should the asterisk be focusable, because of the tooltip?) ### Testing - [ ] Tests for new code are written - [ ] All tests pass - [x] axe-core dev tools show no critical or major issues
rafael added 2 commits 2025-12-02 11:38:41 +01:00
Check translations when linting
All checks were successful
continuous-integration/drone/push Build is passing
Details
1073c380b7
rafael self-assigned this 2025-12-02 11:43:40 +01:00
requested review from carla 2025-12-02 11:43:51 +01:00
rafael force-pushed mark-required-fields from 1073c380b7 to 56173d423b 2025-12-02 11:59:33 +01:00 Compare
moritz approved these changes 2025-12-02 15:10:25 +01:00
moritz left a comment
Owner
Copy link

👍

👍
moritz force-pushed mark-required-fields from 56173d423b to a67a91cffa 2025-12-02 15:23:56 +01:00 Compare
moritz merged commit 88c5f3dde0 into main 2025-12-02 15:26:12 +01:00
moritz deleted branch mark-required-fields 2025-12-02 15:26:13 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
carla
moritz
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
high priority

   
invalid

Something is wrong

  
L

5 h

  
low priority

   
M

3 h

  
medium priority

   
needs refinement

   
question

More information is needed

  
S

1 h

  
UX research

   
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
question
S
UX research
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
rafael
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: local-it/mitgliederverwaltung#235
No description provided.
Delete branch "mark-required-fields"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?