local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 51 Pull requests 13 Projects 1 Releases Packages 1 Activity Actions

Implement dropdown to show/hide columns in member overview closes #209 #240

Merged
moritz merged 28 commits from feature/209_hide_field_dropdown into main 2025-12-03 19:01:15 +01:00
Conversation 3 Commits 28 Files changed 19 +2456 -65
carla commented 2025-12-02 15:03:05 +01:00
Owner
Copy link

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

What has been changed?

  • Dropdown Component has been added to core components
  • Field visibility dropdown has been added as live component using this
  • showing and hiding is possible now

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues

Additional Notes

The fields that are shown are for now just saved in the URL, saving and getting it from cookies is handled in a different issue: #252

## Description of the implemented changes The changes were: - [ ] Bugfixing - [x] New Feature - [ ] Breaking Change - [ ] Refactoring <!--- Describe the goal of the PR in a few words --> ## What has been changed? - Dropdown Component has been added to core components - Field visibility dropdown has been added as live component using this - showing and hiding is possible now ## Definition of Done ### Code Quality - [x] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility - [x] New elements are properly defined with html-tags - [x] Colour contrast follows WCAG criteria - [x] Aria labels are added when needed - [x] Everything is accessible by keyboard - [x] Tab-Order is comprehensible - [x] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [x] axe-core dev tools show no critical or major issues ## Additional Notes The fields that are shown are for now just saved in the URL, saving and getting it from cookies is handled in a different issue: https://git.local-it.org/local-it/mitgliederverwaltung/issues/252
carla added 8 commits 2025-12-02 15:03:07 +01:00
feat: adds member visibility to live view
Some checks failed
continuous-integration/drone/push Build is failing
Details
7f0da693ee
formatting and refactor member fields constant
All checks were successful
continuous-integration/drone/push Build is passing
Details
d039e4bb7d
feat: adds field visibility dropdown live component
Some checks failed
continuous-integration/drone/push Build is failing
Details
0fb43a0816
carla added this to the Sprint 9: 20.11 - 11.12 project 2025-12-02 15:03:09 +01:00
requested reviews from moritz, simon, rafael 2025-12-02 15:03:29 +01:00
moritz commented 2025-12-02 15:46:39 +01:00
Owner
Copy link

I just tried out this feature a little bit and recognized that the search isn't working anymore.

I just tried out this feature a little bit and recognized that the search isn't working anymore.
carla commented 2025-12-02 16:21:59 +01:00
Author
Owner
Copy link

@moritz wrote in #240 (comment):

I just tried out this feature a little bit and recognized that the search isn't working anymore.

I will have a look later , thanks !

@moritz wrote in https://git.local-it.org/local-it/mitgliederverwaltung/pulls/240#issuecomment-15373: > I just tried out this feature a little bit and recognized that the search isn't working anymore. I will have a look later , thanks !
carla added 1 commit 2025-12-02 18:46:28 +01:00
fix: search
Some checks failed
continuous-integration/drone/push Build is failing
Details
206e733511
carla force-pushed feature/209_hide_field_dropdown from 206e733511 to f62d1fbf51 2025-12-03 08:05:15 +01:00 Compare
carla force-pushed feature/209_hide_field_dropdown from f62d1fbf51 to 206e733511 2025-12-03 10:31:41 +01:00 Compare
carla added 1 commit 2025-12-03 12:52:25 +01:00
Merge branch 'main' into feature/209_hide_field_dropdown
Some checks failed
continuous-integration/drone/push Build is failing
Details
f0613fe1e5
carla added 4 commits 2025-12-03 14:56:49 +01:00
fix: hide paid column and add tests
Some checks reported errors
continuous-integration/drone/push Build was killed
Details
c9678231f9
carla added 1 commit 2025-12-03 14:58:07 +01:00
Merge branch 'main' into feature/209_hide_field_dropdown
Some checks failed
continuous-integration/drone/push Build is failing
Details
c17445975c
removed review requests for moritz, simon 2025-12-03 14:58:34 +01:00
carla changed title from WIP: Implement dropdown to show/hide columns in member overview to Implement dropdown to show/hide columns in member overview 2025-12-03 14:58:38 +01:00
removed review request for rafael 2025-12-03 14:58:39 +01:00
moritz removed this from the Sprint 9: 20.11 - 11.12 project 2025-12-03 15:47:50 +01:00
moritz changed title from Implement dropdown to show/hide columns in member overview to Implement dropdown to show/hide columns in member overview closes #209 2025-12-03 17:15:40 +01:00
requested review from moritz 2025-12-03 17:20:27 +01:00
moritz added 1 commit 2025-12-03 17:40:08 +01:00
Merge branch 'main' into feature/209_hide_field_dropdown
Some checks failed
continuous-integration/drone/push Build is failing
Details
f5b67de870
moritz added 11 commits 2025-12-03 18:50:21 +01:00 
Fixes bug where globally hidden custom fields could not be enabled via dropdown
Removes dead code and fixes initialization to use FieldVisibility module
Use Enum.map_join and reduce nesting in format_custom_field_label
Remove fuzzy flags and add correct translations for Columns, None, Options, etc
Adapts icon distribution test for dynamic fields, restores empty cell test
Allows users to enable globally hidden custom fields in the table view
refactor: DRY - use Mv.Constants.custom_field_prefix() instead of string literals
All checks were successful
continuous-integration/drone/push Build is passing
Details
cf6a108049
moritz added 1 commit 2025-12-03 19:00:11 +01:00
Merge branch 'main' into feature/209_hide_field_dropdown
All checks were successful
continuous-integration/drone/push Build is passing
Details
5ae4450444
moritz approved these changes 2025-12-03 19:01:01 +01:00
moritz merged commit 702eebd110 into main 2025-12-03 19:01:15 +01:00
moritz deleted branch feature/209_hide_field_dropdown 2025-12-03 19:01:16 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
moritz
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
high priority

   
invalid

Something is wrong

  
L

5 h

  
low priority

   
M

3 h

  
medium priority

   
needs refinement

   
question

More information is needed

  
S

1 h

  
UX research

   
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
question
S
UX research
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: local-it/mitgliederverwaltung#240
No description provided.
Delete branch "feature/209_hide_field_dropdown"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?